From nobody Wed May 1 05:06:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+53294+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+53294+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1579146496; cv=none; d=zohomail.com; s=zohoarc; b=gdiFfm+MNCCp+JqnJa8v1l1BC47jYGiDQWHMW4YNWVlojMl8M1hjMDNp+Di7DOCPp0lkIqwbTkEwFn6+/Cb6UiIwi1/ew5j7/nfNJJ6IaQhEfRjztCAL4jf41jkaahf3ENZ+q5tw9LAyxPVH8XrjUmJEREfg/yfQ/n2X/dAJ1Oc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579146496; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=IaoljzAkGSAEdRkWyoW5Quzrwd6x3Q6IwuKkuTcTOWo=; b=Cf/GVZ35ukiJXnlHRFbD072cfzL7seNbQDqHFbABBNdcYgWSkbUJ8VXmNX5jfL2lQT9Bc/r353Uj61DTq4cNz0McUJ5ltP30h6g4y4wan98nxOP76MIfL5v81Gy0ueTY+3boKI2Q9BrIqSWjvIJ4CXeQcJsOgVYlWiNd7sq6Oak= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+53294+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 15791464960201012.5074233499082; Wed, 15 Jan 2020 19:48:16 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id xEz1YY1788612x7nFHynze0Z; Wed, 15 Jan 2020 19:48:15 -0800 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web09.4112.1579146494866144524 for ; Wed, 15 Jan 2020 19:48:15 -0800 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2020 19:48:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,324,1574150400"; d="scan'208";a="218383377" X-Received: from lgao4-mobl.ccr.corp.intel.com ([10.255.31.229]) by orsmga008.jf.intel.com with ESMTP; 15 Jan 2020 19:48:13 -0800 From: "Liming Gao" To: devel@edk2.groups.io Cc: Zhiguang Liu Subject: [edk2-devel] [Patch] MdePkg Base.h: Use correct style to check the defined macro Date: Thu, 16 Jan 2020 11:48:05 +0800 Message-Id: <20200116034805.1560-1-liming.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,liming.gao@intel.com X-Gm-Message-State: 8Cf7EIpOXrnPnNQve3UpJnQux1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1579146495; bh=HeNmpB68+K3CwpbYhdwKyWla4hS4lhRL9+0P5XuwSWY=; h=Cc:Date:From:Reply-To:Subject:To; b=C9rk2MlU1p2o1j/qHNErAX/0kr3wKFcG9gHM0QJNMt2PmQOEbkGWyJBg6GEilA3ANv+ Eb7I9xZ6nUMTkLIY9ZaN8C0ilcYC5YfgyKQRV4hBeAIXfFXinH9LdRwz08c4OC5STYK3c ApFBHneQz2Bt37TbZzex0fxIav+SBMiJ5hc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" #if MACRO is not good style. It should be changed to #ifdef MACRO style or #if defined (MACRO) style. Signed-off-by: Zhiguang Liu Reviewed-by: Liming Gao --- MdePkg/Include/Base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h index e0bcd0ae67..321d729c04 100644 --- a/MdePkg/Include/Base.h +++ b/MdePkg/Include/Base.h @@ -195,7 +195,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent /// #define ASM_PFX(name) _CONCATENATE (__USER_LABEL_PREFIX__, name) =20 -#if __APPLE__ +#ifdef __APPLE__ // // Apple extension that is used by the linker to optimize code size // with assembly functions. Put at the end of your .S files @@ -799,7 +799,7 @@ typedef UINTN *BASE_LIST; **/ #ifdef MDE_CPU_EBC #define STATIC_ASSERT(Expression, Message) -#elif _MSC_EXTENSIONS +#elif defined(_MSC_EXTENSIONS) #define STATIC_ASSERT static_assert #else #define STATIC_ASSERT _Static_assert --=20 2.24.1.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53294): https://edk2.groups.io/g/devel/message/53294 Mute This Topic: https://groups.io/mt/69740997/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-