From nobody Fri Apr 19 16:09:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+53170+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+53170+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1578865140; cv=none; d=zohomail.com; s=zohoarc; b=PtzyP/mRZ2DJ56ProVraT24ERt9ll92X9tyvJ9OMrHN8ZN0eCXLDsoXbXIjWElOU1C7XQPDECYZnlUo7KEEkQATDot/+goPP+U0h0QCJLZXBSxfRLdEKhG6hZvZ7cpdbKt1vaHqTCj42SXG+d1isl2Vz8txS3iI55TK+D0aPL7o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578865140; h=Content-Type:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=S/JspytJ4XuVMT31w7PwMF+kQqP5jbF+qvLDrWfGDvA=; b=VcrJ6q1Ilsw/OoQTnr7FCE8yaL2HVRjP7VjUv0usO+F65++LryaLkIOCYwobazB54X67tqaFHKEm9zMW2wgBYRWE7U/9WwA404xNMh59oY47O2D6bZKOPgPlz1NLtPgpwSfoXjNE/ob7AUEEMHMf6Ehuko7Uh+rfMtKxCPVTr+0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+53170+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1578865140777191.29635014335304; Sun, 12 Jan 2020 13:39:00 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id blVxYY1788612xHuTolopeUp; Sun, 12 Jan 2020 13:39:00 -0800 X-Received: from mail-40134.protonmail.ch (mail-40134.protonmail.ch [185.70.40.134]) by mx.groups.io with SMTP id smtpd.web10.28038.1578865138140981471 for ; Sun, 12 Jan 2020 13:38:59 -0800 Date: Sun, 12 Jan 2020 21:38:49 +0000 To: devel@edk2.groups.io From: "Vitaly Cheptsov via Groups.Io" Reply-To: devel@edk2.groups.io,vit9696@protonmail.com Subject: [edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles without device paths Message-ID: <20200112213845.96853-2-vit9696@protonmail.com> In-Reply-To: <20200112213845.96853-1-vit9696@protonmail.com> References: <20200112213845.96853-1-vit9696@protonmail.com> Feedback-ID: p9QuX-L1wMgUm6nrSvNrf8juLupNs0VSnzXGVXuYDxlEahFdWtaedWDMB9zpwGDklGt7kzs1-RBc0cqz327Gcg==:Ext:ProtonMail MIME-Version: 1.0 X-Spam-Status: No, score=3.3 required=7.0 tests=ALL_TRUSTED,BAYES_50, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,FREEMAIL_REPLYTO_END_DIGIT shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 X-Spam-Level: *** X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.protonmail.ch Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io X-Gm-Message-State: AIPsOALEpuEFTuZANoIx7sZNx1787277AA= Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha256; boundary="---------------------24d2cdfb310e37a22cbd59992c763e27"; charset=UTF-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1578865140; bh=mQX0JV8pkFjs6Ti4XakUVC2sgRXq8SWjZLcFYdUAp1g=; h=Content-Type:Date:From:Reply-To:Subject:To; b=BtKuDe6uluBmxNRmuX9G9iMKSOFxWA9dKE0kNTjKhZwqhFMLvNQHMKXIo2sC+vbdo2A Pj5xw8gRYT8f5FQkGv8RfWQ26ITTPCHYUBCAD0X6bKZa6MCtN21aAnQ5rLd5wJLbEFXpG uMJygU1yx9EkXYeNhAzhoehQuDt7Zl98NK0= X-Zoho-Virus-Status: 1 X-ZohoMail-DKIM: pass (identity @groups.io) -----------------------24d2cdfb310e37a22cbd59992c763e27 Content-Transfer-Encoding: quoted-printable Date: Mon, 13 Jan 2020 00:38:45 +0300 From: Vitaly Cheptsov In-Reply-To: <20200112213845.96853-1-vit9696@protonmail.com> Message-Id: <20200112213845.96853-2-vit9696@protonmail.com> Mime-Version: 1.0 References: <20200112213845.96853-1-vit9696@protonmail.com> Subject: [PATCH 1/1] ShellPkg: Do not connect handles without device paths To: devel@edk2.groups.io X-Mailer: git-send-email 2.21.0 (Apple Git-122.2) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2460 Doing this reduces the amount of needless work during device connection and resolves issues with firmwares that freeze when connecting handles without device paths. Signed-off-by: Vitaly Cheptsov --- ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c b/ShellPkg/= Library/UefiShellLevel2CommandsLib/Load.c index b6e7c952fa..083aac0dba 100644 --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c @@ -32,8 +32,8 @@ ConnectAllEfi ( UINTN Index; =20 Status =3D gBS->LocateHandleBuffer ( - AllHandles, - NULL, + ByProtocol, + &gEfiDevicePathProtocolGuid, NULL, &HandleCount, &HandleBuffer --=20 2.21.0 (Apple Git-122.2) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53170): https://edk2.groups.io/g/devel/message/53170 Mute This Topic: https://groups.io/mt/69653841/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- -----------------------24d2cdfb310e37a22cbd59992c763e27 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: ProtonMail wsBmBAEBCAAQBQJeG5HoCRBPsoxt7Hy0xQAKCRBPsoxt7Hy0xV0VB/42eqzn TCGsJ2Sa61hSyO267J+wvL1wlxDhPu3paMLBpTurrMkcsbqkBEA2mvwmy9de aQurii4IGgyVGOIuNHSmjWpV1aaokq1sdmYkEpBFf4DZ3k8WSdkhAd1X+zNE Usbvw4kHFezqVE0jbGqesjPUsFOWmu7yEIMu8rm4QdURWhPbcGGxRFKnmhNF cl7QYC9WMdSkV6L5SqP4+Xwpca2C9i9qg6g1in+fYuDWk7P2xcFDu8diWoYu 3K7rh7xk2o68NhJupxIYvujee6Dt9SUyeDeX4g22/OVlFiuVTH7G6TRHWxdu T9lv6v9gSCkCvJQ2sXCe0K1wIzr0G90747Xs =tkkD -----END PGP SIGNATURE----- -----------------------24d2cdfb310e37a22cbd59992c763e27--