From nobody Mon Feb 9 17:23:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+53070+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+53070+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578567368; cv=none; d=zohomail.com; s=zohoarc; b=n9crKgLUISu1EvXMjIBrRgM48B0Nfx/1WjfCVD4mdttACIgDI14LvLzhRnLKwNshpqi4dtI09TlDW+s7l/2yNJRvMrpFBHKlPuo+K8NoLfOaaKwgC2nFROsszRxX4YaRKWwFAnpUnAiMX623kAOz+rFXwY4e0NNF3Td2WubIUYI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578567368; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=MtwBU3GxLZJ03c6e0aatqyIFsDOlhag2X3qZtUxEisQ=; b=e5NuF1gsSJ51n3nnkSxYWrD3O2JB5YqK+tXHCeDS/R5CCe5nCf5Swt7qopX7xRv+MSNyWqNNB9uJTd9YkFh8fqgekUgRYG/17UbjSYUT7Fcr3VpEvSFdX+eQyCAlKefTm7AFLg+CsCk3ghMU9Nyxio3Xhlss4UlC3F9vIhRz0Vs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+53070+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 157856736849766.99763236905414; Thu, 9 Jan 2020 02:56:08 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id oKpVYY1788612xMRu2ivprma; Thu, 09 Jan 2020 02:56:08 -0800 X-Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web10.7052.1578567367421275217 for ; Thu, 09 Jan 2020 02:56:07 -0800 X-Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-267-n5CFlZxVN9SBvPOoy5QDlQ-1; Thu, 09 Jan 2020 05:56:05 -0500 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 572E610054E3; Thu, 9 Jan 2020 10:56:04 +0000 (UTC) X-Received: from x1w.redhat.com (ovpn-204-107.brq.redhat.com [10.40.204.107]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D4A0460BE0; Thu, 9 Jan 2020 10:56:02 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: Liming Gao , Bob Feng , devel@edk2.groups.io Cc: Philippe Mathieu-Daude Subject: [edk2-devel] [PATCH v4 4/4] BaseTools/PatchCheck.py: Check the committer email address Date: Thu, 9 Jan 2020 11:55:46 +0100 Message-Id: <20200109105546.30768-5-philmd@redhat.com> In-Reply-To: <20200109105546.30768-1-philmd@redhat.com> References: <20200109105546.30768-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: n5CFlZxVN9SBvPOoy5QDlQ-1 X-Mimecast-Spam-Score: 0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,philmd@redhat.com X-Gm-Message-State: NiRJylml09qHAwf7vLyzgqjYx1787277AA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1578567368; bh=bqIrz45KJOc/iR3qVAypZ91eFgYWkl30vHQpS0iAcr8=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=N+z8DBBhiARur39mLwDSaLkhawoXYl6zUDsviIrSk/nOkq9IUqdcVP9gf8QrzredX9S QD+2DO2bL+EdNea7HZcgxzNTOJC6lwDnzt+3SO79sBqP1OHagU0LnTGkDYRdwGV+vu0n/ qsJ0ST7dKkD+TYJxETjYHbM7PUKvKycoOdI= X-ZohoMail-DKIM: pass (identity @groups.io) To avoid patches committed with incorrect email address, use the EmailAddressCheck class on the committer email too. Cc: Bob Feng Cc: Liming Gao Reviewed-by: Bob Feng Signed-off-by: Philippe Mathieu-Daude --- BaseTools/Scripts/PatchCheck.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck= .py index e7b3c3bae47a..fe8e6a64f2bb 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -561,6 +561,8 @@ class CheckGitCommits: else: blank_line =3D True print('Checking git commit:', commit) + email =3D self.read_committer_email_address_from_git(commit) + self.ok &=3D EmailAddressCheck(email, 'Committer').ok patch =3D self.read_patch_from_git(commit) self.ok &=3D CheckOnePatch(commit, patch).ok if not commits: @@ -579,6 +581,10 @@ class CheckGitCommits: # Run git to get the commit patch return self.run_git('show', '--pretty=3Demail', '--no-textconv', c= ommit) =20 + def read_committer_email_address_from_git(self, commit): + # Run git to get the committer email + return self.run_git('show', '--pretty=3D%cn <%ce>', '--no-patch', = commit) + def run_git(self, *args): cmd =3D [ 'git' ] cmd +=3D args --=20 2.21.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53070): https://edk2.groups.io/g/devel/message/53070 Mute This Topic: https://groups.io/mt/69576949/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-