From nobody Mon Feb 9 14:38:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+53063+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+53063+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578566977; cv=none; d=zohomail.com; s=zohoarc; b=EeGfxV596+L9ES6s4jkeHtmU5BDIioo9PK9N9YPWxYb8o++piXqOAiDFM50d3Lc3r5SCvwaSeXGQDGnjJEnLdpTDBnHZHjzft62QhPBtCWi10GXl8FMWBVkT70j4epz9MPMwuDRHToE1gcPDm6QP2rswDfkiVU+RsE2gjmjTMXw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578566977; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=KAxS7X+Cq+82Wo7Zv2qSpwq3SlGnBcAeCriXaORGl1U=; b=nTs5mkbplXerlKrD21xf5UlWdll43azbUTA69BhfhtLreExY/s4FeW3QCVZ1tPjX4PqrNU74heyWpyZXB8P4XiCsHXvVvOWDSnVpUaxCCx/6uHvVQ/TFVtMLJeVPPzxIlA1EFEe1j+9rn+EaSwYpUV6CbD15lg4XF/Zg3PKpvug= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+53063+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1578566977714221.25506151897048; Thu, 9 Jan 2020 02:49:37 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 21sdYY1788612xefYqWiZXL0; Thu, 09 Jan 2020 02:49:37 -0800 X-Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web10.7015.1578566976695790755 for ; Thu, 09 Jan 2020 02:49:36 -0800 X-Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-296-JXfALxNmOBqADPhUWOqgug-1; Thu, 09 Jan 2020 05:49:34 -0500 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 24B8F107ACC5; Thu, 9 Jan 2020 10:49:33 +0000 (UTC) X-Received: from x1w.redhat.com (ovpn-204-107.brq.redhat.com [10.40.204.107]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A4E2860BE0; Thu, 9 Jan 2020 10:49:29 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: Liming Gao , Bob Feng , devel@edk2.groups.io Cc: Philippe Mathieu-Daude , Jordan Justen Subject: [edk2-devel] [PATCH v3 2/4] BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked Date: Thu, 9 Jan 2020 11:49:16 +0100 Message-Id: <20200109104918.29750-3-philmd@redhat.com> In-Reply-To: <20200109104918.29750-1-philmd@redhat.com> References: <20200109104918.29750-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: JXfALxNmOBqADPhUWOqgug-1 X-Mimecast-Spam-Score: 0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,philmd@redhat.com X-Gm-Message-State: 5TBMBUAMvUbvdEBDwHFLJE4Ax1787277AA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1578566977; bh=Qg4N6e9ouLWZOmeRJvKvFfr+mM1GxxZ70pCZ4F3GXPw=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=N4XtfrLOyyeD4fEk6Hqu+lq9P73CbTTJCfIpomV8tdkX84menGtkkemfAazMy202uIR FE+Uxx4d1hNYuA0fHOysij+1dFc8YFK1O6v0kikt+MpKDxLkXJHRDbsRoIkNACyEJRq3H eWwUX0nBifSAfG5G369yVqZHrDRw8yneYVY= X-ZohoMail-DKIM: pass (identity @groups.io) We are checking different emails from the signature list. We are going to check more. To be able to differency, add a description field, so the error reported is clearer. Cc: Liming Gao Cc: Jordan Justen Reviewed-by: Bob Feng Signed-off-by: Philippe Mathieu-Daude --- BaseTools/Scripts/PatchCheck.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck= .py index 3b6d77081e7e..42b923cb927e 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -26,18 +26,22 @@ class Verbose: class EmailAddressCheck: """Checks an email address.""" =20 - def __init__(self, email): + def __init__(self, email, description): self.ok =3D True =20 if email is None: self.error('Email address is missing!') return + if description is None: + self.error('Email description is missing!') + return =20 + self.description =3D "'" + description + "'" self.check_email_address(email) =20 def error(self, *err): if self.ok and Verbose.level > Verbose.ONELINE: - print('The email address is not valid:') + print('The ' + self.description + ' email address is not valid= :') self.ok =3D False if Verbose.level < Verbose.NORMAL: return @@ -174,7 +178,7 @@ class CommitMessageCheck: if s[2] !=3D ' ': self.error("There should be a space after '" + sig + ":'") =20 - EmailAddressCheck(s[3]) + EmailAddressCheck(s[3], sig) =20 return sigs =20 --=20 2.21.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53063): https://edk2.groups.io/g/devel/message/53063 Mute This Topic: https://groups.io/mt/69576885/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-