From nobody Mon Feb 9 16:51:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+52888+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+52888+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578306948; cv=none; d=zohomail.com; s=zohoarc; b=NbVGS2E8gk9NbbnNhMKpIVkCOKNxcuwIAMEWaUJjsgwQJD1N/oTDiFXffUtTqh9IMsdljnDu1q9DjdPRu/0/xFcTCokPtKGns8UzmgScYDGBiLyb8y/D5KzoremM/y1J2wMBXAwEn3EsqYiO6aK8Lzy0TTpT6sLfobfyN6pMIMs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578306948; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=SuvORUq+lwRMcchXJnDEq5I6N/Mez4eVfiYa8g6d6VY=; b=FyvXmQwRWLaDJ3gYHJKHCbKDQ3XZSHQdzPb/gfybwDADXTm2jcKicHYEL0J/ryoNq21QWTxf+C5Vo04JhEtNgCYRZN63VJknkZ3ZY0SE/902wB88ZL2IjSzEOften2CPumHHXqAa+NuY5MwKflLdRvLwnWxzQuZf66E7AYHiNEY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+52888+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1578306948898883.4244199861782; Mon, 6 Jan 2020 02:35:48 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id GJFLYY1788612x071jpraGcJ; Mon, 06 Jan 2020 02:35:48 -0800 X-Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web12.2050.1578306947814702369 for ; Mon, 06 Jan 2020 02:35:48 -0800 X-Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-156-fTgOwv0pPXeeVTFofx-Hmw-1; Mon, 06 Jan 2020 05:35:45 -0500 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8863B107ACC7; Mon, 6 Jan 2020 10:35:44 +0000 (UTC) X-Received: from x1w.redhat.com (ovpn-204-53.brq.redhat.com [10.40.204.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ACC985D9E1; Mon, 6 Jan 2020 10:35:42 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: devel@edk2.groups.io Cc: Michael D Kinney , Laszlo Ersek , Philippe Mathieu-Daude , Liming Gao , Jordan Justen Subject: [edk2-devel] [PATCH v2 3/4] BaseTools/PatchCheck.py: Check the patch author email address Date: Mon, 6 Jan 2020 11:35:27 +0100 Message-Id: <20200106103528.5438-4-philmd@redhat.com> In-Reply-To: <20200106103528.5438-1-philmd@redhat.com> References: <20200106103528.5438-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: fTgOwv0pPXeeVTFofx-Hmw-1 X-Mimecast-Spam-Score: 0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,philmd@redhat.com X-Gm-Message-State: lvjfPFZYsDCQTIYTji5skg4hx1787277AA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1578306948; bh=XT3klPzu1Fv4JNPrlCCFNzli90vW5mhbt1jV8dvGdKY=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=tgJUG/hEwMv9CEPXP3eJ7wq9MeK6jlvHCzsqTIls5ipl1cUW5uLcIlDLX7vSRF+LGup Sun+xFaBaKR+uXsXr6Mhwguw97u1PYFGQRHrwqaAT2GiTvJEIteawhiXT9PbkqsFH2CuF HRW/cRvpINyILKlkXmFj8geFXrLbtoojfK4= X-ZohoMail-DKIM: pass (identity @groups.io) To avoid patches committed with incorrect email address, use the EmailAddressCheck class on the author email too. Example: $ python BaseTools/Scripts/PatchCheck.py 1a04951309f Checking git commit: 1a04951309f The 'Author' email address is not valid: * The email address cannot contain a space: /o=3DIntel/ou=3DExternal \ (FYDIBOHF25SPDLT)/cn=3DRecipients/cn=3Dfe425ca7e5f4401abed22b904fe5d964 Cc: Liming Gao Cc: Jordan Justen Signed-off-by: Philippe Mathieu-Daude --- BaseTools/Scripts/PatchCheck.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck= .py index a0ff5ec0038a..f0e661bfd6e3 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -450,6 +450,9 @@ class CheckOnePatch: self.patch =3D patch self.find_patch_pieces() =20 + email_check =3D EmailAddressCheck(self.author_email, 'Author') + email_ok =3D email_check.ok + msg_check =3D CommitMessageCheck(self.commit_subject, self.commit_= msg) msg_ok =3D msg_check.ok =20 @@ -458,7 +461,7 @@ class CheckOnePatch: diff_check =3D GitDiffCheck(self.diff) diff_ok =3D diff_check.ok =20 - self.ok =3D msg_ok and diff_ok + self.ok =3D email_ok and msg_ok and diff_ok =20 if Verbose.level =3D=3D Verbose.ONELINE: if self.ok: @@ -536,6 +539,8 @@ class CheckOnePatch: self.commit_subject =3D self.commit_subject.replace('\n', '') self.commit_subject =3D self.subject_prefix_re.sub('', self.commit= _subject, 1) =20 + self.author_email =3D pmail['from'] + class CheckGitCommits: """Reads patches from git based on the specified git revision range. =20 --=20 2.21.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52888): https://edk2.groups.io/g/devel/message/52888 Mute This Topic: https://groups.io/mt/69462076/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-