From nobody Mon Feb 9 07:22:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+52887+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+52887+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578306948; cv=none; d=zohomail.com; s=zohoarc; b=nHmGnj4ev+8wEnlLYKHdV6CdokTOeGObjdNRfi1sW6OdEHgvIpcNl3AWvLmxpaxHz/y/QJL81GkmpXosw65LWQqICwTwxifhzkZ7tRb/lzioq6jvpmT/SUAhng6jIck4qIAdC6ugI+JqYJdbr17Hhn67iXjdX4lQJeyqUo/Ri3M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578306948; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=ll6APJErhLldiedaZ4hvFlVBN3IAorVnr4ym3HVIYsU=; b=nHmUm9nx4kFHnq1+yBE/MVOsT7aD14q00S6m+dbayryKseTO6pKNzQhfNX6XCS2sDBG9/MfR2owalu5KiuY/4ieJ9B7LrPVZIDmGs/Ctazc7EzkyqzwSUKo6wF27EJ/SY22hGQT8Yx/lhoy/0FW3Dbe3Wu06lRXX7teqY34y+RI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+52887+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1578306948359932.3030112639914; Mon, 6 Jan 2020 02:35:48 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 5J6VYY1788612x2NaMUosnS9; Mon, 06 Jan 2020 02:35:47 -0800 X-Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web10.1987.1578306947225055899 for ; Mon, 06 Jan 2020 02:35:47 -0800 X-Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-390-eYx6kxApM6OqdIdhrt0bUQ-1; Mon, 06 Jan 2020 05:35:43 -0500 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4B5C61005502; Mon, 6 Jan 2020 10:35:42 +0000 (UTC) X-Received: from x1w.redhat.com (ovpn-204-53.brq.redhat.com [10.40.204.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 31F0E5D9D6; Mon, 6 Jan 2020 10:35:38 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: devel@edk2.groups.io Cc: Michael D Kinney , Laszlo Ersek , Philippe Mathieu-Daude , Liming Gao , Jordan Justen Subject: [edk2-devel] [PATCH v2 2/4] BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked Date: Mon, 6 Jan 2020 11:35:26 +0100 Message-Id: <20200106103528.5438-3-philmd@redhat.com> In-Reply-To: <20200106103528.5438-1-philmd@redhat.com> References: <20200106103528.5438-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: eYx6kxApM6OqdIdhrt0bUQ-1 X-Mimecast-Spam-Score: 0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,philmd@redhat.com X-Gm-Message-State: esm7SH0vXikWYxFA9TdxS3Wux1787277AA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1578306947; bh=Youn3VXpi+IrqP7YMF2Jina1zFowUoP2/oRCT31xmNU=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=epQQ/95ny7UIdKE1c2bIziwZjpvHfSHlClikekGjNXlHbamOPSnjBYwMhUSwSuRETFm q4CxbVjI65b1KFXUQ7v98Vm2RNToW2HPhyGYiBepRUjeh0AkRPOYy6PZnNy/vMe8xD4Va ubpru9sl18igpIerxF5+h0LB2x5YdwdavOI= X-ZohoMail-DKIM: pass (identity @groups.io) We are checking different emails from the signature list. We are going to check more. To be able to differency, add a description field, so the error reported is clearer. Cc: Liming Gao Cc: Jordan Justen Signed-off-by: Philippe Mathieu-Daude --- BaseTools/Scripts/PatchCheck.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck= .py index 0e654345fcc8..a0ff5ec0038a 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -25,18 +25,22 @@ class Verbose: class EmailAddressCheck: """Checks an email address.""" =20 - def __init__(self, email): + def __init__(self, email, description): self.ok =3D True =20 if email is None: self.error('Email address is missing!') return + if description is None: + self.error('Email description is missing!') + return =20 + self.description =3D "'" + description + "'" self.check_email_address(email) =20 def error(self, *err): if self.ok and Verbose.level > Verbose.ONELINE: - print('The email address is not valid:') + print('The ' + self.description + ' email address is not valid= :') self.ok =3D False if Verbose.level < Verbose.NORMAL: return @@ -173,7 +177,7 @@ class CommitMessageCheck: if s[2] !=3D ' ': self.error("There should be a space after '" + sig + ":'") =20 - EmailAddressCheck(s[3]) + EmailAddressCheck(s[3], sig) =20 return sigs =20 --=20 2.21.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52887): https://edk2.groups.io/g/devel/message/52887 Mute This Topic: https://groups.io/mt/69462075/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-