BaseTools/Scripts/PatchCheck.py | 99 +++++++++++++++++++++++---------- 1 file changed, 69 insertions(+), 30 deletions(-)
Last month I cleaned the git-history incorrect email addresses: https://edk2.groups.io/g/devel/message/51834 but today I noticed more incorrect addresses got committed (see caa917491a4..33a3293651). To avoid having the same cleanup in the future, fix the problem once for all by having PatchCheck doing this automatically (on merge). Since we already have code to check email address in PatchCheck, factor the code out to reuse it, and add checks for committer/author addresses. Philippe Mathieu-Daude (4): BaseTools/PatchCheck.py: Extract email check code to EmailAddressCheck BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked BaseTools/PatchCheck.py: Check the patch author email address BaseTools/PatchCheck.py: Check the committer email address BaseTools/Scripts/PatchCheck.py | 99 +++++++++++++++++++++++---------- 1 file changed, 69 insertions(+), 30 deletions(-) -- 2.21.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52656): https://edk2.groups.io/g/devel/message/52656 Mute This Topic: https://groups.io/mt/69381374/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On 1/2/20 4:24 PM, Philippe Mathieu-Daude wrote: > Last month I cleaned the git-history incorrect email > addresses: https://edk2.groups.io/g/devel/message/51834 > but today I noticed more incorrect addresses got committed > (see caa917491a4..33a3293651). > To avoid having the same cleanup in the future, fix the > problem once for all by having PatchCheck doing this > automatically (on merge). > > Since we already have code to check email address in > PatchCheck, factor the code out to reuse it, and > add checks for committer/author addresses. > > Philippe Mathieu-Daude (4): > BaseTools/PatchCheck.py: Extract email check code to EmailAddressCheck > BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked > BaseTools/PatchCheck.py: Check the patch author email address > BaseTools/PatchCheck.py: Check the committer email address > > BaseTools/Scripts/PatchCheck.py | 99 +++++++++++++++++++++++---------- > 1 file changed, 69 insertions(+), 30 deletions(-) Please disregard this cover, I forgot to use the Cc tags: Cc: Liming Gao <liming.gao@intel.com> Cc: Jordan Justen <jordan.l.justen@intel.com> I hit ^C too late :S -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52662): https://edk2.groups.io/g/devel/message/52662 Mute This Topic: https://groups.io/mt/69381374/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.