From nobody Mon Apr 29 15:24:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+52650+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+52650+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1577967428; cv=none; d=zohomail.com; s=zohoarc; b=N1kaqgKdkQyRq9EjltCDvDW84sMXTFjwuzhRg3PL8h4WGpkeWDXkQl7Gg92o00K/25JWirg0QIJ+UKU7iayVxi9fXLuwbfJbT3HutlmBncr/l1QGhmi8i6e5gS1/qOYjHMCje6QgJKgmEP3qkBzhzFLuEbWt6iIDbpWWEaJHw2M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1577967428; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=ieN70qTFIYCPYtBeD0zHQM+3KzPlf5hfpvPMpxe05no=; b=kOmCliD9kCbg+ErCDcoXOLb23G8I3Fz82EkWoXWGd7piXkqO6ZGQeukyb4g7pDC2Mrt8G7FqrxUMOGH2UweWqOcE+g2q/9QR+uB1HkThgDyhG02CwUKih4V+2sLj7NGI3Aa1yCGeq8ysIGEKoW6ZJNYNpZsaQwnAzcx0ruK0Sc8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+52650+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1577967428221128.32895420570014; Thu, 2 Jan 2020 04:17:08 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id VhfWYY1788612xGKpezfpW6e; Thu, 02 Jan 2020 04:17:07 -0800 X-Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web12.10924.1577967426878145616 for ; Thu, 02 Jan 2020 04:17:07 -0800 X-Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-265-rYnEvh64NraE7xHrCX6Zeg-1; Thu, 02 Jan 2020 07:17:04 -0500 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 48AE018552A2; Thu, 2 Jan 2020 12:17:03 +0000 (UTC) X-Received: from x1w.redhat.com (ovpn-116-143.ams2.redhat.com [10.36.116.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 903C465E80; Thu, 2 Jan 2020 12:16:58 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: devel@edk2.groups.io Cc: Philippe Mathieu-Daude , Liming Gao , Jordan Justen , Yonghong Zhu , Zhichao Gao Subject: [edk2-devel] [PATCH v2] BaseTools/PatchCheck.py: Ignore CR and LF characters in subject length Date: Thu, 2 Jan 2020 13:16:56 +0100 Message-Id: <20200102121656.29572-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: rYnEvh64NraE7xHrCX6Zeg-1 X-Mimecast-Spam-Score: 0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,philmd@redhat.com X-Gm-Message-State: 8w9B5gkAPdfaK5s3HgoxUOKVx1787277AA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1577967427; bh=iCOUbk0PB0mn2jHQDEpBHtWi3vp5xfhsbu84/b90gMo=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=GizDl+2UqgdkOMDnxlkzCY2RGqVqmLC2hBRPkbqZi4RGjzYGwJbfHLSNsQPV8s0Vk57 RQc3usrMlxgu0KlHzHe2xTa6jdvsFEEDRxZQhH7IKdVfEq/M904M17hIPux64exAEzGhw 4zxW91rpJt6uLzVdaMlwgi4cRaDOLON6uQ8= X-ZohoMail-DKIM: pass (identity @groups.io) REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D113 Strip the trailing characters before checking the subject line is less than 72 characters. Fixes: e61406708c83f Cc: Liming Gao Cc: Jordan Justen Reviewed-by: Jordan Justen Signed-off-by: Philippe Mathieu-Daude Reviewed-by: Bob Feng --- Cc: Yonghong Zhu Cc: Zhichao Gao v2: Use rstrip() (Jordan Justen) v1: https://edk2.groups.io/g/devel/message/52425 --- BaseTools/Scripts/PatchCheck.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck= .py index 2a4e6f603e79..9668025798da 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -196,7 +196,7 @@ class CommitMessageCheck: self.error('Empty commit message!') return =20 - if count >=3D 1 and len(lines[0]) >=3D 72: + if count >=3D 1 and len(lines[0].rstrip()) >=3D 72: self.error('First line of commit message (subject line) ' + 'is too long.') =20 --=20 2.21.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52650): https://edk2.groups.io/g/devel/message/52650 Mute This Topic: https://groups.io/mt/69378760/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-