From nobody Sun May 19 02:06:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+52421+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+52421+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576764597; cv=none; d=zohomail.com; s=zohoarc; b=CbYvz5wWsRCHsOlciMMIWNK1ir63Kq+6XURqL38lY3m27ojOIQmrKLVlNY07qu0NZEiMLBXsFSCcGzCYS3KZPFrM7EExIzzGoLgPFlLWZgvTHAYFFzdTt3sIErHMdG5naLFsEC4Z24KzAPimjpikZve/2zXlA0iM1vg8x0PDP08= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576764597; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=5Sd6ZBHtOaaUhJX1A1kw0/9vr7ZYU8X/ugokLu1ZUlA=; b=Gp/BR/RCmlTqjoqdiCDUB9n7gOcy/wlpEcIq5J+jpv/6iHwdhR6hd6W8i/lVWbj3AO+B78OxEa49t5OPARmskX1wmvA3901PmVOOm+gI0w8AYQkU+C/v1mBqp3JUFzATAY0si2kwcoXpSW8M4TDlnCt/vBhIxrLTOsF1aZXfwjM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+52421+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1576764597487643.9077902774192; Thu, 19 Dec 2019 06:09:57 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id hAGEYY1788612xgngYUJ5gD1; Thu, 19 Dec 2019 06:09:56 -0800 X-Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web09.9772.1576764587189731204 for ; Thu, 19 Dec 2019 06:09:47 -0800 X-Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-98-r066dXewPDG0XWsWM6UeDw-1; Thu, 19 Dec 2019 09:09:42 -0500 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A3ABFDB61; Thu, 19 Dec 2019 14:09:41 +0000 (UTC) X-Received: from x1w.redhat.com (unknown [10.36.118.122]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1E7315C54A; Thu, 19 Dec 2019 14:09:39 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: devel@edk2.groups.io Cc: Ray Ni , Zhichao Gao , Philippe Mathieu-Daude Subject: [edk2-devel] [PATCH v2 1/2] ShellPkg: Document ParseCommandLineToArgs returns EFI_INVALID_PARAMETER Date: Thu, 19 Dec 2019 15:09:31 +0100 Message-Id: <20191219140932.25428-2-philmd@redhat.com> In-Reply-To: <20191219140932.25428-1-philmd@redhat.com> References: <20191219140932.25428-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: r066dXewPDG0XWsWM6UeDw-1 X-Mimecast-Spam-Score: 0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,philmd@redhat.com X-Gm-Message-State: cu4Zk3c0UEkd4akvbmRJazbGx1787277AA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1576764596; bh=S8uIa6rCtLRst/DTMGEi+C4fxpogoAL/nTzQomwfX+4=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=BdtjniakTfA8OMWJiqkZEJVU1hUiWsXdEWSBj42hixKsm+NJUoEpKhuraDxc3f8Q1RV y3Z2mObuck7BxLF/M+Nh5ag1+WYT22O/m0llhhLtCclnBMTy+FHxy3Ep8aODVWdUiJfXC IKjTO3uo/38JflFcR8fqFg9ul+/Yv5GLnxA= X-ZohoMail-DKIM: pass (identity @groups.io) ShellParametersProtocol::ParseCommandLineToArgs() can return a EFI_INVALID_PARAMETER value. Document it. Reviewed-by: Zhichao Gao Signed-off-by: Philippe Mathieu-Daude --- ShellPkg/Application/Shell/ShellParametersProtocol.h | 1 + ShellPkg/Application/Shell/ShellParametersProtocol.c | 1 + 2 files changed, 2 insertions(+) diff --git a/ShellPkg/Application/Shell/ShellParametersProtocol.h b/ShellPk= g/Application/Shell/ShellParametersProtocol.h index df0316a03091..da103086ab9a 100644 --- a/ShellPkg/Application/Shell/ShellParametersProtocol.h +++ b/ShellPkg/Application/Shell/ShellParametersProtocol.h @@ -167,6 +167,7 @@ RestoreStdInStdOutStdErr ( @param[in, out] Argc pointer to number of strings in Argv arr= ay =20 @return EFI_SUCCESS the operation was sucessful + @return EFI_INVALID_PARAMETER some parameters are invalid @return EFI_OUT_OF_RESOURCES a memory allocation failed. **/ EFI_STATUS diff --git a/ShellPkg/Application/Shell/ShellParametersProtocol.c b/ShellPk= g/Application/Shell/ShellParametersProtocol.c index bcd8f0ae2112..83fe4eda3fb8 100644 --- a/ShellPkg/Application/Shell/ShellParametersProtocol.c +++ b/ShellPkg/Application/Shell/ShellParametersProtocol.c @@ -185,6 +185,7 @@ DEBUG_CODE_END(); @param[in, out] Argc pointer to number of strings in Argv arr= ay =20 @return EFI_SUCCESS the operation was sucessful + @return EFI_INVALID_PARAMETER some parameters are invalid @return EFI_OUT_OF_RESOURCES a memory allocation failed. **/ EFI_STATUS --=20 2.21.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52421): https://edk2.groups.io/g/devel/message/52421 Mute This Topic: https://groups.io/mt/68831522/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 02:06:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+52422+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+52422+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576764604; cv=none; d=zohomail.com; s=zohoarc; b=DcCl9gUtf34vkMmsBAQLlcode7hMZBSYZY8vfb/ik8whfs/qv8WHRTWK5C2YBeqKghkWXG48Uaj1V8N5+YBKmg3wtm8H2YXW8wvqPNEIds2+3eoySd2fZ45S5aGt0SzDV4hoqpdUFcJnGx9og9q0+tR9Yj4Nh9puVCkrdNKHeMk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576764604; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=IAN+Egs9DfqpbS9g4/8chWggpNfKAvIB7SxToAMYtCM=; b=Xzc0DZ6Q3zHUYGhjDyoWzdICPlT0xPlHmuiyZQleYByqlvFOxv8lKveuPZw0XgiwBCUcdqkTe3TNmu/Q22ujhNH+FISoHf5uRRGsQW2/gelb1BTtWT/+hwZ0ccnn7asH5ILiRD4AXG/ktfC0BzFJAB5W12LxJK7W7rjrga2fFbQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+52422+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1576764604322672.6612957402341; Thu, 19 Dec 2019 06:10:04 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id OCOVYY1788612xywWA65oXIu; Thu, 19 Dec 2019 06:10:03 -0800 X-Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web10.10093.1576764587758410655 for ; Thu, 19 Dec 2019 06:09:48 -0800 X-Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-134-VGPUbdHmN-KHKBOFkApJLA-1; Thu, 19 Dec 2019 09:09:44 -0500 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C956D100550E; Thu, 19 Dec 2019 14:09:43 +0000 (UTC) X-Received: from x1w.redhat.com (unknown [10.36.118.122]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0BE175C3FA; Thu, 19 Dec 2019 14:09:41 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: devel@edk2.groups.io Cc: Ray Ni , Zhichao Gao , Philippe Mathieu-Daude Subject: [edk2-devel] [PATCH v2 2/2] ShellPkg: Document UpdateArgcArgv returns EFI_INVALID_PARAMETER Date: Thu, 19 Dec 2019 15:09:32 +0100 Message-Id: <20191219140932.25428-3-philmd@redhat.com> In-Reply-To: <20191219140932.25428-1-philmd@redhat.com> References: <20191219140932.25428-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: VGPUbdHmN-KHKBOFkApJLA-1 X-Mimecast-Spam-Score: 0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,philmd@redhat.com X-Gm-Message-State: WZYNfA3F5okP7AnNFEpCPG5Wx1787277AA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1576764603; bh=6VeoVCnNmM5JJvF6fmkKwqCE7fBjZBTUWSwnjVtXFiI=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=J5XxGjz8C3yB9TUouGJwRQNOz/srr9mmUIR6TKF8gNJbwBa4uMemTVFb6qHhjRgnVys NNq590HYg1ALFtkZYba7Z0ppVjhekFQR8eiDx0Dovg/7ncnqFpoQt5wEZdSjNjBbIUZrT MwkQdY1V0B2TzMFvI9EDYwnUKTxgEB4j0jM= X-ZohoMail-DKIM: pass (identity @groups.io) ShellParametersProtocol::UpdateArgcArgv() can return a EFI_INVALID_PARAMETER value. Document it. Reviewed-by: Zhichao Gao Signed-off-by: Philippe Mathieu-Daude --- ShellPkg/Application/Shell/ShellParametersProtocol.h | 1 + ShellPkg/Application/Shell/ShellParametersProtocol.c | 1 + 2 files changed, 2 insertions(+) diff --git a/ShellPkg/Application/Shell/ShellParametersProtocol.h b/ShellPk= g/Application/Shell/ShellParametersProtocol.h index da103086ab9a..721cb34f5835 100644 --- a/ShellPkg/Application/Shell/ShellParametersProtocol.h +++ b/ShellPkg/Application/Shell/ShellParametersProtocol.h @@ -71,6 +71,7 @@ CleanUpShellParametersProtocol ( @param[out] OldArgc pointer to old number of items in = Argv list =20 @retval EFI_SUCCESS operation was sucessful, Argv and = Argc are valid + @return EFI_INVALID_PARAMETER some parameters are invalid @retval EFI_OUT_OF_RESOURCES a memory allocation failed. **/ EFI_STATUS diff --git a/ShellPkg/Application/Shell/ShellParametersProtocol.c b/ShellPk= g/Application/Shell/ShellParametersProtocol.c index 83fe4eda3fb8..4555a9639d95 100644 --- a/ShellPkg/Application/Shell/ShellParametersProtocol.c +++ b/ShellPkg/Application/Shell/ShellParametersProtocol.c @@ -1341,6 +1341,7 @@ RestoreStdInStdOutStdErr ( @param[out] OldArgc Pointer to old number of items in= Argv list. =20 @retval EFI_SUCCESS Operation was sucessful, Argv and = Argc are valid. + @return EFI_INVALID_PARAMETER Some parameters are invalid. @retval EFI_OUT_OF_RESOURCES A memory allocation failed. **/ EFI_STATUS --=20 2.21.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52422): https://edk2.groups.io/g/devel/message/52422 Mute This Topic: https://groups.io/mt/68831523/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-