[edk2-devel] [edk2-platforms][PATCH v2 0/4] Platform/RPi4: Add PCIe and xHCI support

Pete Batard posted 4 patches 4 years, 3 months ago
Failed in applying to current master (apply log)
Platform/RaspberryPi/RPi4/RPi4.dsc                                                            |   29 +-
Platform/RaspberryPi/RPi4/RPi4.fdf                                                            |   10 +-
Platform/RaspberryPi/RPi4/Readme.md                                                           |   23 +-
Silicon/Broadcom/Bcm27xx/Bcm27xx.dec                                                          |    4 +
Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h                                   |   71 +
Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.c            |  193 +++
Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.inf          |   51 +
Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLibConstructor.c |  235 ++++
Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.c                         | 1445 ++++++++++++++++++++
Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.inf                       |   35 +
10 files changed, 2078 insertions(+), 18 deletions(-)
create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.c
create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.inf
create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLibConstructor.c
create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.c
create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.inf
[edk2-devel] [edk2-platforms][PATCH v2 0/4] Platform/RPi4: Add PCIe and xHCI support
Posted by Pete Batard 4 years, 3 months ago
Changes from v1 (https://edk2.groups.io/g/devel/message/52160 - 52164):

* Ensure that read/write accesses are serialized in PciSegmentLib.
* Flesh out commit messages.
* Minor comments and code updates for whitespaces & capitalization.

Jeremy Linton (4):
  Silicon/Bcm27xx: Add PCIe constants to Bcm2711.h
  Silicon/Bcm27xx: Add segment library to handle nonstandard ECAM
  Silicon/Bcm27xx: Add PCIe host bridge config library
  Platform/RPi4: Build the PCIe and xHCI drivers into the firmware

 Platform/RaspberryPi/RPi4/RPi4.dsc                                                            |   29 +-
 Platform/RaspberryPi/RPi4/RPi4.fdf                                                            |   10 +-
 Platform/RaspberryPi/RPi4/Readme.md                                                           |   23 +-
 Silicon/Broadcom/Bcm27xx/Bcm27xx.dec                                                          |    4 +
 Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h                                   |   71 +
 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.c            |  193 +++
 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.inf          |   51 +
 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLibConstructor.c |  235 ++++
 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.c                         | 1445 ++++++++++++++++++++
 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.inf                       |   35 +
 10 files changed, 2078 insertions(+), 18 deletions(-)
 create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.c
 create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.inf
 create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLibConstructor.c
 create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.c
 create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.inf

-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52203): https://edk2.groups.io/g/devel/message/52203
Mute This Topic: https://groups.io/mt/68533744/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/4] Platform/RPi4: Add PCIe and xHCI support
Posted by Ard Biesheuvel 4 years, 3 months ago
On Fri, 13 Dec 2019 at 18:07, Pete Batard <pete@akeo.ie> wrote:
>
> Changes from v1 (https://edk2.groups.io/g/devel/message/52160 - 52164):
>
> * Ensure that read/write accesses are serialized in PciSegmentLib.
> * Flesh out commit messages.
> * Minor comments and code updates for whitespaces & capitalization.
>
> Jeremy Linton (4):
>   Silicon/Bcm27xx: Add PCIe constants to Bcm2711.h
>   Silicon/Bcm27xx: Add segment library to handle nonstandard ECAM
>   Silicon/Bcm27xx: Add PCIe host bridge config library
>   Platform/RPi4: Build the PCIe and xHCI drivers into the firmware
>

Thanks Pete

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

I have touched up a couple of style issues, and pushed the series as
c682c58b3a29..9c8c79542eae


>  Platform/RaspberryPi/RPi4/RPi4.dsc                                                            |   29 +-
>  Platform/RaspberryPi/RPi4/RPi4.fdf                                                            |   10 +-
>  Platform/RaspberryPi/RPi4/Readme.md                                                           |   23 +-
>  Silicon/Broadcom/Bcm27xx/Bcm27xx.dec                                                          |    4 +
>  Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h                                   |   71 +
>  Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.c            |  193 +++
>  Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.inf          |   51 +
>  Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLibConstructor.c |  235 ++++
>  Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.c                         | 1445 ++++++++++++++++++++
>  Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.inf                       |   35 +
>  10 files changed, 2078 insertions(+), 18 deletions(-)
>  create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.c
>  create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.inf
>  create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLibConstructor.c
>  create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.c
>  create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.inf
>
> --
> 2.21.0.windows.1
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52209): https://edk2.groups.io/g/devel/message/52209
Mute This Topic: https://groups.io/mt/68533744/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/4] Platform/RPi4: Add PCIe and xHCI support
Posted by Pete Batard 4 years, 3 months ago
On 2019.12.13 17:40, Ard Biesheuvel wrote:
> On Fri, 13 Dec 2019 at 18:07, Pete Batard <pete@akeo.ie> wrote:
>>
>> Changes from v1 (https://edk2.groups.io/g/devel/message/52160 - 52164):
>>
>> * Ensure that read/write accesses are serialized in PciSegmentLib.
>> * Flesh out commit messages.
>> * Minor comments and code updates for whitespaces & capitalization.
>>
>> Jeremy Linton (4):
>>    Silicon/Bcm27xx: Add PCIe constants to Bcm2711.h
>>    Silicon/Bcm27xx: Add segment library to handle nonstandard ECAM
>>    Silicon/Bcm27xx: Add PCIe host bridge config library
>>    Platform/RPi4: Build the PCIe and xHCI drivers into the firmware
>>
> 
> Thanks Pete
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> 
> I have touched up a couple of style issues, and pushed the series as
> c682c58b3a29..9c8c79542eae

Much appreciated, thanks!

Since this RPi4 integration is moving fast, I'll use this opportunity to 
send a gentle ping for https://edk2.groups.io/g/devel/message/52131, 
which I sent before the v1 for the PCIe series.

Regards,

/Pete

> 
> 
>>   Platform/RaspberryPi/RPi4/RPi4.dsc                                                            |   29 +-
>>   Platform/RaspberryPi/RPi4/RPi4.fdf                                                            |   10 +-
>>   Platform/RaspberryPi/RPi4/Readme.md                                                           |   23 +-
>>   Silicon/Broadcom/Bcm27xx/Bcm27xx.dec                                                          |    4 +
>>   Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h                                   |   71 +
>>   Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.c            |  193 +++
>>   Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.inf          |   51 +
>>   Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLibConstructor.c |  235 ++++
>>   Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.c                         | 1445 ++++++++++++++++++++
>>   Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.inf                       |   35 +
>>   10 files changed, 2078 insertions(+), 18 deletions(-)
>>   create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.c
>>   create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.inf
>>   create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLibConstructor.c
>>   create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.c
>>   create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.inf
>>
>> --
>> 2.21.0.windows.1
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52210): https://edk2.groups.io/g/devel/message/52210
Mute This Topic: https://groups.io/mt/68533744/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-