From nobody Tue Feb 10 00:22:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+51829+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+51829+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1575630141; cv=none; d=zohomail.com; s=zohoarc; b=nrT2c4ncOzDD9CbUdfC0uR8YAJzxzd43eP2/CmXbQzeHKCOYLzf4binwTZMHm+EbwRS0sP4AZ5i7LXmpjjkE7chNxP0ecxL37bCaQbChYySKjHshTcU+wPfDBGlpBW/AIghycdeLpQbU8PF2iaK6LTg2mTWhAEnWtQmZI661whE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575630141; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=5J/oai3oDIQBxvm4fUXz256z5hn4mzbx70TmJUy4uT0=; b=a95CFiHZZmlrAhz06XMHBCcW87/ExC1odMlqnbF7F5YX2DSEC26nThMxIHGUPI65cST5O925E1NQcI/z2AY1mCAZgFvWEM4DqqK+z0W2y9DRZi5I//U4v93lOSJVJIrPtqV69BEN9Cs/xUCRFsZxcFSdPhiRYBORe3Xz61o4K/8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+51829+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 157563014124566.72215061765542; Fri, 6 Dec 2019 03:02:21 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id QQ5wYY1788612xbWZyUaxEN7; Fri, 06 Dec 2019 03:02:20 -0800 X-Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web10.2145.1575630139973117739 for ; Fri, 06 Dec 2019 03:02:20 -0800 X-Received: by mail-wm1-f65.google.com with SMTP id p17so6911297wmi.3 for ; Fri, 06 Dec 2019 03:02:19 -0800 (PST) X-Gm-Message-State: vDndbypieTVl4t8FxbtyIU4ix1787277AA= X-Google-Smtp-Source: APXvYqy9LqaPBTqSRxgRJS5SlHAPjlrhrjKAbvccJEVZpkSR6zSKO9cXe5fGxLqMWBWpD1wjcbCf2Q== X-Received: by 2002:a1c:6207:: with SMTP id w7mr10349542wmb.16.1575630137717; Fri, 06 Dec 2019 03:02:17 -0800 (PST) X-Received: from e123331-lin.cambridge.arm.com (fw-tnat-cam5.arm.com. [217.140.106.53]) by smtp.gmail.com with ESMTPSA id g2sm303001wrw.76.2019.12.06.03.02.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Dec 2019 03:02:16 -0800 (PST) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Sami Mujawar , Laszlo Ersek , Leif Lindholm Subject: [edk2-devel] [PATCH edk2-platforms 1/2] Platform/ARM/ArmJunoDxe: make mAcpiRegistration STATIC Date: Fri, 6 Dec 2019 11:02:18 +0000 Message-Id: <20191206110219.32190-2-ard.biesheuvel@linaro.org> In-Reply-To: <20191206110219.32190-1-ard.biesheuvel@linaro.org> References: <20191206110219.32190-1-ard.biesheuvel@linaro.org> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ard.biesheuvel@linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1575630140; bh=Iwj2PCo67hic0E6luUZt/DSbUPI/BAch7tm989jz+iU=; h=Cc:Date:From:Reply-To:Subject:To; b=kO7Ik+5Z1r+AYj3Jm4qW8G9eY2zPAy+E1jRIm72K1FjBVsdqE8MCbbVYfFaLZSfi2d7 4chxLNVtAQvys+EGyMA71zT0MVmY7jesDTQEmH5zZHUyJBwt319HP/WUeV1d+09nTERob 4H7JaXvg3sGtHsF+jUurcUTpfSaGKa9uR+4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Generally, variables should only have external linkage if needed, so make mAcpiRegistration STATIC, given that static linkage suffices for it. Signed-off-by: Ard Biesheuvel Reviewed-by: Laszlo Ersek --- Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c b/Platfor= m/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c index ea7591d70443..c0ad7ced2959 100644 --- a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c +++ b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c @@ -64,7 +64,7 @@ STATIC CONST EFI_PCI_ROOT_BRIDGE_DEVICE_PATH mPciRootComp= lexDevicePath =3D { } }; =20 -EFI_EVENT mAcpiRegistration =3D NULL; +STATIC EFI_EVENT mAcpiRegistration =3D NULL; =20 /** This function reads PCI ID of the controller. --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51829): https://edk2.groups.io/g/devel/message/51829 Mute This Topic: https://groups.io/mt/67467392/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-