From nobody Sun Apr 28 05:58:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+51807+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+51807+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1575596980; cv=none; d=zohomail.com; s=zohoarc; b=cPY3HM2/tn14V4dc31AMrV8qBQaAnClaTCsodsAyIB0oKcE+UykZ59+w3yTFGqsYOrkaufllBHWdqpbAYmnX4O7E/L97DMx/muJBVi3ho30/9Mm1b40QZHiG4MC4hnGKlSTo4Ekm6Twg/cDqH35edpi/Y1dGnorihdmpgbJIJ1g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575596980; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To; bh=aF55Cy7XSMrtQ9xgFtQvfAOJa3bPzUrS/DCxWKRI870=; b=Th1vUSLX8AGwzqDWrOMD9E9bLrwwHb4bXlGJ4DDBzbS+HKSvhqzTeZSSLAD5VQJx0k5MO9Zbs9q6kXF2uZic+6K6B252M0y20J4SgrrXMqPQ4MeuR5hey3oHJmosCQ9EAj55Oow5KOb+1m0WoDMfcGX6ev6nRDVuXzbdWenxo2Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+51807+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1575596980078431.01495900114094; Thu, 5 Dec 2019 17:49:40 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id aaaaYY1788612xaaaaaaaaaa; Thu, 05 Dec 2019 17:49:37 -0800 X-Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.7319.1575596976508656093 for ; Thu, 05 Dec 2019 17:49:36 -0800 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Dec 2019 17:49:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,282,1571727600"; d="scan'208";a="214297335" X-Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by orsmga006.jf.intel.com with ESMTP; 05 Dec 2019 17:49:34 -0800 From: "Zhang, Shenglei" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Chao Zhang Subject: [edk2-devel] [PATCH] SecurityPkg/Tpm2Help.c: Add boundary check for array Date: Fri, 6 Dec 2019 09:49:33 +0800 Message-Id: <20191206014933.36648-1-shenglei.zhang@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,shenglei.zhang@intel.com X-Gm-Message-State: aaaaaaaaaaaaaaaaaaaaaaaax1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1575596977; bh=neTZLMqToZQQtksV+oYvVLfbKA2Ufz7X+Z5NH2ayAgI=; h=Cc:Date:From:Reply-To:Subject:To; b=nB4Qo1z4c31WOSdZ7GwApBVsvOOaE6d1jctSfOrlNMMisH1KStzf6f1P2Gb+7bgTYxz ainbPBR92+/7c0QM7YlxGW05f3uqX1Y+Fnh15IxK8MRfPmsXkOnnLYrM8Tyu/YT2RfbNk aL05Qb/5u9S1DNDe/5VXitySpWZcvbOiteI= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Add 'Index < HASH_COUNT' to ensure things out of boundary of digests[] can not be visited. Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Shenglei Zhang --- SecurityPkg/Library/Tpm2CommandLib/Tpm2Help.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Help.c b/SecurityPkg/Li= brary/Tpm2CommandLib/Tpm2Help.c index 36c240d1221c..a7d4e3ab5373 100644 --- a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Help.c +++ b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Help.c @@ -299,7 +299,7 @@ GetDigestListSize ( UINT32 TotalSize; =20 TotalSize =3D sizeof(DigestList->count); - for (Index =3D 0; Index < DigestList->count; Index++) { + for (Index =3D 0; Index < DigestList->count, Index < HASH_COUNT; Index++= ) { DigestSize =3D GetHashSizeFromAlgo (DigestList->digests[Index].hashAlg= ); TotalSize +=3D sizeof(DigestList->digests[Index].hashAlg) + DigestSize; } --=20 2.18.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51807): https://edk2.groups.io/g/devel/message/51807 Mute This Topic: https://groups.io/mt/67403438/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-