From nobody Thu Apr 25 17:59:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+51549+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+51549+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575308009; cv=none; d=zohomail.com; s=zohoarc; b=Bg2yDLfCDE/enfO0P64K+z+6W0vpJ834PoA7lkRS8rCu0gn9dXkj7qR0yGUslLUEVMOGGcQHnlKDZfhxGm1MPVi3nqx3Y85R7KzzDgfmGIIXJCiifzGrvUHIIVDeI4YPR7VyAN69qNUQ0ilCDOCkAPBddvA6BjnNhYpYbANxWuo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575308009; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=hpz+IfBR3T5kTSMaie/hFqZwkMWP6DyZw6Vs82854Pw=; b=PBgEOHPumcFL6DiO2jMFnb6fNU5AzibPcoyDAtIGBJMoyf0MAYlfWZRcbgqfy2n1KjvUMRAabIrHUt+yxcl6/nzMr/c4UmOzk4oSj1N6IanXqXDPABGFBz8rCRua9ahw8Dz6jhO1B4PeDiO4VmSyqiSGmngXqMCDIGhUEHj0fcE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+51549+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1575308009674500.85715141583523; Mon, 2 Dec 2019 09:33:29 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id aaaaYY1788612xaaaaaaaaaa; Mon, 02 Dec 2019 09:33:29 -0800 X-Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web12.4498.1575308008197809981 for ; Mon, 02 Dec 2019 09:33:28 -0800 X-Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-150-ELbdsynCOYSWx3l_vEqSDw-1; Mon, 02 Dec 2019 12:33:26 -0500 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D1CA0107ACCA; Mon, 2 Dec 2019 17:33:24 +0000 (UTC) X-Received: from x1w.redhat.com (ovpn-204-21.brq.redhat.com [10.40.204.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EBFA419C68; Mon, 2 Dec 2019 17:33:18 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: devel@edk2.groups.io Cc: Sean Brogan , "Zhiju . Fan" , Bob Feng , Bret Barkelew , Liming Gao , Michael D Kinney , Philippe Mathieu-Daude Subject: [edk2-devel] [PATCH 1/2] BaseTools: Avoid "is" with a literal Python 3.8 warnings Date: Mon, 2 Dec 2019 18:33:08 +0100 Message-Id: <20191202173309.10411-2-philmd@redhat.com> In-Reply-To: <20191202173309.10411-1-philmd@redhat.com> References: <20191202173309.10411-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: ELbdsynCOYSWx3l_vEqSDw-1 X-Mimecast-Spam-Score: 0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,philmd@redhat.com X-Gm-Message-State: aaaaaaaaaaaaaaaaaaaaaaaax1787277AA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1575308009; bh=GjjHwNHzZNaqb0G//zVC93VVmfi8hjWHsUJHv1VfioE=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=tW5L+8VN9wm97os2IG1ctYCcp0dHPGEXJDcjHhEbBL5qkf8rjHkZ5mtdwH2fsGpsrjQ dzVhUEgMsFqNNC+YA7AEuHNHx3VEhFEcWl4gYEUkCffGrBtfgBgOFvu38yTuQrkfmN4BI W8h/CV8GcDeSjSFOL0yNzxg9JJvi/qA8iwI= X-ZohoMail-DKIM: pass (identity @groups.io) The following statement produces a SyntaxWarning with Python 3.8: if str(FdRegion.RegionType) is 'FILE' and self.Platform.VpdToolGuid in st= r(FdRegion.RegionDataList): BaseTools/Source/Python/AutoGen/WorkspaceAutoGen.py:168: SyntaxWarning: "= is" with a literal. Did you mean "=3D=3D"? Change the 'is' operator by the conventional '=3D=3D' comparator. Signed-off-by: Philippe Mathieu-Daude Reviewed-by: Bob Feng --- BaseTools/Source/Python/AutoGen/WorkspaceAutoGen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/AutoGen/WorkspaceAutoGen.py b/BaseTool= s/Source/Python/AutoGen/WorkspaceAutoGen.py index fde48b4b2788..ec0c25bd1487 100644 --- a/BaseTools/Source/Python/AutoGen/WorkspaceAutoGen.py +++ b/BaseTools/Source/Python/AutoGen/WorkspaceAutoGen.py @@ -165,7 +165,7 @@ class WorkspaceAutoGen(AutoGen): if Fdf.CurrentFdName and Fdf.CurrentFdName in Fdf.Profile.FdDi= ct: FdDict =3D Fdf.Profile.FdDict[Fdf.CurrentFdName] for FdRegion in FdDict.RegionList: - if str(FdRegion.RegionType) is 'FILE' and self.Platfor= m.VpdToolGuid in str(FdRegion.RegionDataList): + if str(FdRegion.RegionType) =3D=3D 'FILE' and self.Pla= tform.VpdToolGuid in str(FdRegion.RegionDataList): if int(FdRegion.Offset) % 8 !=3D 0: EdkLogger.error("build", FORMAT_INVALID, 'The = VPD Base Address %s must be 8-byte aligned.' % (FdRegion.Offset)) FdfProfile =3D Fdf.Profile --=20 2.21.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51549): https://edk2.groups.io/g/devel/message/51549 Mute This Topic: https://groups.io/mt/65079226/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu Apr 25 17:59:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+51550+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+51550+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575308014; cv=none; d=zohomail.com; s=zohoarc; b=BcRVnXAW2J9uvWXM5PABVqErq+tPeuZcOXI3va8QYL0rJSzS5012XglhorooMZ2uA4AoM4SLObd7AuruO8B7aiG6IRQn5H11KEGy+zUWe/mF8T66w7lt4NB3pbAgQY7CvtpTJ5MHC1aRR1fFGvjHxyz1GvtCOOGN/w5VmxJBz3Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575308014; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=4yyMwb7HBtXCkoyDjfkjDwiVYn+L0Mkox4LCqmkRLeA=; b=Aai0WUKRshpoHo8LcCNw0IOWeDvAjeMZDJnmgykUMZedGHgnX+iTakMkHTcZp5WG224oMgoodiK4UtUo847iAqI9wbYssMFMHllqoO/at444D7260SAdsjanR7QKv8A4p6hDFOLBIUOVcUBXrrO/QhWLulJBW/VJGwVyVijd9aM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+51550+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1575308014883183.4879676846126; Mon, 2 Dec 2019 09:33:34 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id aaaaYY1788612xaaaaaaaaaa; Mon, 02 Dec 2019 09:33:34 -0800 X-Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web10.4599.1575308013642392006 for ; Mon, 02 Dec 2019 09:33:33 -0800 X-Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-381-n_b-80idNaiKB3L9979fAQ-1; Mon, 02 Dec 2019 12:33:29 -0500 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3664E100551C; Mon, 2 Dec 2019 17:33:28 +0000 (UTC) X-Received: from x1w.redhat.com (ovpn-204-21.brq.redhat.com [10.40.204.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3F6CB19C68; Mon, 2 Dec 2019 17:33:25 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: devel@edk2.groups.io Cc: Sean Brogan , "Zhiju . Fan" , Bob Feng , Bret Barkelew , Liming Gao , Michael D Kinney , Philippe Mathieu-Daude Subject: [edk2-devel] [PATCH 2/2] .pytool: Avoid "is" with a literal Python 3.8 warnings in CI plugins Date: Mon, 2 Dec 2019 18:33:09 +0100 Message-Id: <20191202173309.10411-3-philmd@redhat.com> In-Reply-To: <20191202173309.10411-1-philmd@redhat.com> References: <20191202173309.10411-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: n_b-80idNaiKB3L9979fAQ-1 X-Mimecast-Spam-Score: 0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,philmd@redhat.com X-Gm-Message-State: aaaaaaaaaaaaaaaaaaaaaaaax1787277AA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1575308014; bh=mRiHg/qJEaeG8eLGw4yNzWuTiiRtBWQ90Ej4m88Q3yU=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=Z41vlxDuUbZUuBnlCLfKmoQTcM4d0JqTIaz3v2SSZn1Apy4WuySuJNFmF/lse0EMHcZ WetXZQROhZBMislOjoUmp/jyr13jyVvEhlYingha/KAJyeYcB5V2z7yWbVo/MCmJ1THdl KKwX2YNBpYcBwte/n+WduyPlnagwr0DQ2hE= X-ZohoMail-DKIM: pass (identity @groups.io) To avoid SyntaxWarning with Python 3.8, change the 'is' operator by the conventional '=3D=3D' comparator. Signed-off-by: Philippe Mathieu-Daude Reviewed-by: Bob Feng --- .pytool/Plugin/DscCompleteCheck/DscCompleteCheck.py | 2 +- .pytool/Plugin/LibraryClassCheck/LibraryClassCheck.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.pytool/Plugin/DscCompleteCheck/DscCompleteCheck.py b/.pytool/= Plugin/DscCompleteCheck/DscCompleteCheck.py index e2485f570841..9af4f72c8de3 100644 --- a/.pytool/Plugin/DscCompleteCheck/DscCompleteCheck.py +++ b/.pytool/Plugin/DscCompleteCheck/DscCompleteCheck.py @@ -61,7 +61,7 @@ class DscCompleteCheck(ICiBuildPlugin): abs_dsc_path =3D os.path.join(abs_pkg_path, pkgconfig["DscPath"].s= trip()) wsr_dsc_path =3D Edk2pathObj.GetEdk2RelativePathFromAbsolutePath(a= bs_dsc_path) =20 - if abs_dsc_path is None or wsr_dsc_path is "" or not os.path.isfil= e(abs_dsc_path): + if abs_dsc_path is None or wsr_dsc_path =3D=3D "" or not os.path.i= sfile(abs_dsc_path): tc.SetSkipped() tc.LogStdError("Package Dsc not found") return 0 diff --git a/.pytool/Plugin/LibraryClassCheck/LibraryClassCheck.py b/.pytoo= l/Plugin/LibraryClassCheck/LibraryClassCheck.py index 5dafcbc13f8a..a62a7e912b15 100644 --- a/.pytool/Plugin/LibraryClassCheck/LibraryClassCheck.py +++ b/.pytool/Plugin/LibraryClassCheck/LibraryClassCheck.py @@ -67,7 +67,7 @@ class LibraryClassCheck(ICiBuildPlugin): abs_dec_path =3D self.__GetPkgDec(abs_pkg_path) wsr_dec_path =3D Edk2pathObj.GetEdk2RelativePathFromAbsolutePath(a= bs_dec_path) =20 - if abs_dec_path is None or wsr_dec_path is "" or not os.path.isfil= e(abs_dec_path): + if abs_dec_path is None or wsr_dec_path =3D=3D "" or not os.path.i= sfile(abs_dec_path): tc.SetSkipped() tc.LogStdError("No DEC file {0} in package {1}".format(abs_dec= _path, abs_pkg_path)) return -1 --=20 2.21.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51550): https://edk2.groups.io/g/devel/message/51550 Mute This Topic: https://groups.io/mt/65079391/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-