From nobody Tue Feb 10 00:59:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+51525+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+51525+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1575287725; cv=none; d=zohomail.com; s=zohoarc; b=P1g8ph6c+A4Zf+ejNsCCAfwUlxuiLt9Zak7+4Dk3VTQ1nprStwpETIuNRuW8wwUOtsbAURFsf8LaYNlwiXys1WAvW9Khav3tGrlJAzRZVHx12cwGeVmm6TsDxbGG4F1Mu0+T35aPJ9NBiXbx9NBGKYxQzv6sshwm4gsVHTqjt8U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575287725; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=sCEHASP56HyySVrbiSC80GswJ9Ce5DGgkoTqPbgXJUY=; b=cai3ZgnCqMUOr9FdzcOk/zBnyorR7IxYDcVIKN6B1XJTBHfGrcu6/XGBm7qVbdc5vqcItZ+Ok0ISxn7aZdTnp+jh51A3AdrDfAUsM4VlTop/REVih9HT1bGgQ9cxLw+GdD3Bp/JxrVEaSxnupA9ec0N8zWrGu4GVqoDPOgzR/mo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+51525+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1575287725409378.3043105022373; Mon, 2 Dec 2019 03:55:25 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id CzC0YY1788612xwIdloKDimn; Mon, 02 Dec 2019 03:55:24 -0800 X-Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web11.47.1575287724049865400 for ; Mon, 02 Dec 2019 03:55:24 -0800 X-Received: by mail-wm1-f68.google.com with SMTP id p9so6474580wmc.2 for ; Mon, 02 Dec 2019 03:55:23 -0800 (PST) X-Gm-Message-State: 5OZmE4BEMr758g1vCLZw6gDox1787277AA= X-Google-Smtp-Source: APXvYqxeNpO1RHSI9wc7LZuC6g7XMAF0s9beGFP8vH9tJpn4Y+yKn93ECHDlRMRQEEEag1op+4mWkw== X-Received: by 2002:a05:600c:214f:: with SMTP id v15mr16733346wml.110.1575287721986; Mon, 02 Dec 2019 03:55:21 -0800 (PST) X-Received: from localhost.localdomain ([84.203.45.230]) by smtp.gmail.com with ESMTPSA id p10sm8500291wmi.15.2019.12.02.03.55.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Dec 2019 03:55:21 -0800 (PST) From: "Pete Batard" To: devel@edk2.groups.io Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org, philmd@redhat.com Subject: [edk2-devel] [edk2-platforms][PATCH 1/3] Silicon/Broadcom/Bcm283x: Rename Bcm2835 RNG driver Date: Mon, 2 Dec 2019 11:55:04 +0000 Message-Id: <20191202115506.4068-2-pete@akeo.ie> In-Reply-To: <20191202115506.4068-1-pete@akeo.ie> References: <20191202115506.4068-1-pete@akeo.ie> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pete@akeo.ie Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1575287724; bh=Xs8MffRTHyWD6duIf/o2qEA15ZPNNG52NIAgFb79DjE=; h=Cc:Date:From:Reply-To:Subject:To; b=N0nWkMgHaNW0hM8zNfph0hX2OthlLh/zErdByxfdIth390hsKMfDV09ipoYNZWbd43q WuklHDurlpyHNRTg2FvE0eTlYTwNX3ozLWwvYGq68vpcX0riMmUkIN9Ye0fXs8qJw6CtC KKmSDF1FkezeiL9RESIj2WoGgPdJ1GxFYXc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" The Bcm283x architecture provides multiple implementations of the Random Number Generator, that have incompatibilities with one another. Because we will need to add a new driver for the Bcm2838 RNG we rename the existing Bcm2835-compatible driver to Bcm2835RngDxe and update the one platform that depends on this driver (RPi3). We also rename the internal function calls from Bcm2836 to Bcm2835 since, if we ever add platform support for Pi models that use this SoC (original Pi, Pi Zero, etc), it may look confusing to reference a feature that seems to belongs to the next SoC iteration. Signed-off-by: Pete Batard Reviewed-by: Philippe Mathieu-Daude --- Platform/RaspberryPi/RPi3/RPi3.dsc = | 2 +- Platform/RaspberryPi/RPi3/RPi3.fdf = | 2 +- Silicon/Broadcom/Bcm283x/Drivers/{RngDxe/RngDxe.c =3D> Bcm2835RngDxe/Bcm28= 35RngDxe.c} | 16 ++++++++-------- Silicon/Broadcom/Bcm283x/Drivers/{RngDxe/RngDxe.inf =3D> Bcm2835RngDxe/Bcm= 2835RngDxe.inf} | 6 +++--- 4 files changed, 13 insertions(+), 13 deletions(-) diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3= /RPi3.dsc index 6a808b287ea9..945baa5021f8 100644 --- a/Platform/RaspberryPi/RPi3/RPi3.dsc +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc @@ -602,7 +602,7 @@ [Components.common] # # RNG # - Silicon/Broadcom/Bcm283x/Drivers/RngDxe/RngDxe.inf + Silicon/Broadcom/Bcm283x/Drivers/Bcm2835RngDxe/Bcm2835RngDxe.inf =20 # # UEFI application (Shell Embedded Boot Loader) diff --git a/Platform/RaspberryPi/RPi3/RPi3.fdf b/Platform/RaspberryPi/RPi3= /RPi3.fdf index fd4e490fdcdf..31730865601f 100644 --- a/Platform/RaspberryPi/RPi3/RPi3.fdf +++ b/Platform/RaspberryPi/RPi3/RPi3.fdf @@ -273,7 +273,7 @@ [FV.FvMain] # # RNG # - INF Silicon/Broadcom/Bcm283x/Drivers/RngDxe/RngDxe.inf + INF Silicon/Broadcom/Bcm283x/Drivers/Bcm2835RngDxe/Bcm2835RngDxe.inf =20 # # SCSI Bus and Disk Driver diff --git a/Silicon/Broadcom/Bcm283x/Drivers/RngDxe/RngDxe.c b/Silicon/Bro= adcom/Bcm283x/Drivers/Bcm2835RngDxe/Bcm2835RngDxe.c similarity index 93% rename from Silicon/Broadcom/Bcm283x/Drivers/RngDxe/RngDxe.c rename to Silicon/Broadcom/Bcm283x/Drivers/Bcm2835RngDxe/Bcm2835RngDxe.c index 722815d32f06..ea86f9b3877e 100644 --- a/Silicon/Broadcom/Bcm283x/Drivers/RngDxe/RngDxe.c +++ b/Silicon/Broadcom/Bcm283x/Drivers/Bcm2835RngDxe/Bcm2835RngDxe.c @@ -1,6 +1,6 @@ /** @file =20 - This driver produces an EFI_RNG_PROTOCOL instance for the Broadcom 2836 = RNG + This driver produces an EFI_RNG_PROTOCOL instance for the Broadcom 2835 = RNG =20 Copyright (C) 2019, Linaro Ltd. All rights reserved.
=20 @@ -59,7 +59,7 @@ STATIC EFI_STATUS EFIAPI -Bcm2836RngGetInfo ( +Bcm2835RngGetInfo ( IN EFI_RNG_PROTOCOL *This, IN OUT UINTN *RNGAlgorithmListSize, OUT EFI_RNG_ALGORITHM *RNGAlgorithmList @@ -116,7 +116,7 @@ Bcm2836RngGetInfo ( STATIC EFI_STATUS EFIAPI -Bcm2836RngGetRNG ( +Bcm2835RngGetRNG ( IN EFI_RNG_PROTOCOL *This, IN EFI_RNG_ALGORITHM *RNGAlgorithm, OPTIONAL IN UINTN RNGValueLength, @@ -168,9 +168,9 @@ Bcm2836RngGetRNG ( return EFI_SUCCESS; } =20 -STATIC EFI_RNG_PROTOCOL mBcm2836RngProtocol =3D { - Bcm2836RngGetInfo, - Bcm2836RngGetRNG +STATIC EFI_RNG_PROTOCOL mBcm2835RngProtocol =3D { + Bcm2835RngGetInfo, + Bcm2835RngGetRNG }; =20 // @@ -178,7 +178,7 @@ STATIC EFI_RNG_PROTOCOL mBcm2836RngProtocol =3D { // EFI_STATUS EFIAPI -Bcm2836RngEntryPoint ( +Bcm2835RngEntryPoint ( IN EFI_HANDLE ImageHandle, IN EFI_SYSTEM_TABLE *SystemTable ) @@ -186,7 +186,7 @@ Bcm2836RngEntryPoint ( EFI_STATUS Status; =20 Status =3D gBS->InstallMultipleProtocolInterfaces (&ImageHandle, - &gEfiRngProtocolGuid, &mBcm2836RngProtocol, + &gEfiRngProtocolGuid, &mBcm2835RngProtocol, NULL); ASSERT_EFI_ERROR (Status); =20 diff --git a/Silicon/Broadcom/Bcm283x/Drivers/RngDxe/RngDxe.inf b/Silicon/B= roadcom/Bcm283x/Drivers/Bcm2835RngDxe/Bcm2835RngDxe.inf similarity index 82% rename from Silicon/Broadcom/Bcm283x/Drivers/RngDxe/RngDxe.inf rename to Silicon/Broadcom/Bcm283x/Drivers/Bcm2835RngDxe/Bcm2835RngDxe.inf index 8eb90de85cfd..dc91c1a9ba7b 100644 --- a/Silicon/Broadcom/Bcm283x/Drivers/RngDxe/RngDxe.inf +++ b/Silicon/Broadcom/Bcm283x/Drivers/Bcm2835RngDxe/Bcm2835RngDxe.inf @@ -9,14 +9,14 @@ =20 [Defines] INF_VERSION =3D 0x0001001B - BASE_NAME =3D RngDxe + BASE_NAME =3D Bcm2835RngDxe FILE_GUID =3D 9743084e-c82a-4714-b2ba-f571f81cb021 MODULE_TYPE =3D DXE_DRIVER VERSION_STRING =3D 1.0 - ENTRY_POINT =3D Bcm2836RngEntryPoint + ENTRY_POINT =3D Bcm2835RngEntryPoint =20 [Sources] - RngDxe.c + Bcm2835RngDxe.c =20 [Packages] MdePkg/MdePkg.dec --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51525): https://edk2.groups.io/g/devel/message/51525 Mute This Topic: https://groups.io/mt/64721524/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-