From nobody Sat Feb 7 05:19:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+51464+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+51464+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1574952373; cv=none; d=zohomail.com; s=zohoarc; b=ilWpaLwSFJdJYSHKUDmQELlu3BiigMdixfgJtHoTc8tm0Uut0K60yNTuwBdk37RjMPIDJ6SA4H8/h4PXIWiAByMhTYAl8b4VzBJ0l0lTAc2RSPQ8TwDwXb41W3h9h1FzUCPCY/CKvDgnD/j7gLXBUjUcXxo6Fk8FGYjP6w0+rIo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1574952373; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=yXpBdKiZ9rwNwZAcPl3J4WUgLa4oN8NlFuoOCSRgkFY=; b=ZNDm6sE7TCiqtHV2sWfRe9ntkWYbk+SUIFToFcWnzuFrW+53QOkjY/r9KMw/tL/bMAw22miLeuvUNDXZlYNGxWDny2kb9wVlBWq567kcuqE1CtH7DUr/+tov2W/gj6jcopR0d+E8cJ0NKJRV0baqGERTO4PThPEy1n76/P2Fwgs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+51464+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1574952373986348.8154787556341; Thu, 28 Nov 2019 06:46:13 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id aaaaYY1788612xaaaaaaaaaa; Thu, 28 Nov 2019 06:46:13 -0800 X-Received: from mga05.intel.com (mga05.intel.com []) by mx.groups.io with SMTP id smtpd.web12.7366.1574952372108437936 for ; Thu, 28 Nov 2019 06:46:13 -0800 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2019 06:46:12 -0800 X-IronPort-AV: E=Sophos;i="5.69,253,1571727600"; d="scan'208";a="203451936" X-Received: from mrabeda-mobl.ger.corp.intel.com ([10.102.8.43]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 28 Nov 2019 06:46:11 -0800 From: "Maciej Rabeda" To: devel@edk2.groups.io Cc: Jiaxin Wu , Siyuan Fu Subject: [edk2-devel] [PATCH v1 1/1] NetworkPkg: Fixes to static code analysis hits Date: Thu, 28 Nov 2019 15:46:06 +0100 Message-Id: <20191128144606.2040-2-maciej.rabeda@linux.intel.com> In-Reply-To: <20191128144606.2040-1-maciej.rabeda@linux.intel.com> References: <20191128144606.2040-1-maciej.rabeda@linux.intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,maciej.rabeda@linux.intel.com X-Gm-Message-State: aaaaaaaaaaaaaaaaaaaaaaaax1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1574952373; bh=FrAZtoW8O97LCJvvScvIGrQKZ+FwwX6Z8cqEHm0F31k=; h=Cc:Date:From:Reply-To:Subject:To; b=MYSsidlB18INZxEAR/brmATHFUxjiR/TNtcKgD2Y6H+vx2UO+Kuqn4EtYcdOnYvMjcR CnmQTOJykDboz3k/KrmEhW7jXEOCeNPPXMhrfvTNCLf24kg578+KQoiN66rkwWw9+ESRQ 1c4U01BSsnpDdX+yUmPVJcbKf+Aetqlw7xs= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Introducing fixes to memory leak issues identified by static code analysis tool. Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Maciej Rabeda Reviewed-by: Jiaxin Wu Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Siyuan Fu --- NetworkPkg/Dhcp6Dxe/Dhcp6Io.c | 1 + NetworkPkg/Ip4Dxe/Ip4If.c | 6 +++++- NetworkPkg/TcpDxe/TcpDispatcher.c | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Io.c b/NetworkPkg/Dhcp6Dxe/Dhcp6Io.c index 4f8393cb36ce..613b42149cc1 100644 --- a/NetworkPkg/Dhcp6Dxe/Dhcp6Io.c +++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Io.c @@ -203,6 +203,7 @@ Dhcp6EnqueueRetry ( // // Unexpected message type. // + FreePool(TxCb); return EFI_DEVICE_ERROR; } =20 diff --git a/NetworkPkg/Ip4Dxe/Ip4If.c b/NetworkPkg/Ip4Dxe/Ip4If.c index 53a333037f94..348f2e076aed 100644 --- a/NetworkPkg/Ip4Dxe/Ip4If.c +++ b/NetworkPkg/Ip4Dxe/Ip4If.c @@ -491,9 +491,13 @@ Ip4CreateInterface ( IP4_INTERFACE *Interface; EFI_SIMPLE_NETWORK_MODE SnpMode; =20 + if (Mnp =3D=3D NULL) { + return NULL; + } + Interface =3D AllocatePool (sizeof (IP4_INTERFACE)); =20 - if ((Interface =3D=3D NULL) || (Mnp =3D=3D NULL)) { + if (Interface =3D=3D NULL) { return NULL; } =20 diff --git a/NetworkPkg/TcpDxe/TcpDispatcher.c b/NetworkPkg/TcpDxe/TcpDispa= tcher.c index 86beaf8cc513..9ae08ccc1c56 100644 --- a/NetworkPkg/TcpDxe/TcpDispatcher.c +++ b/NetworkPkg/TcpDxe/TcpDispatcher.c @@ -390,6 +390,7 @@ TcpAttachPcb ( ); if (EFI_ERROR (Status)) { IpIoRemoveIp (IpIo, Tcb->IpInfo); + FreePool (Tcb); return Status; } =20 --=20 2.24.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51464): https://edk2.groups.io/g/devel/message/51464 Mute This Topic: https://groups.io/mt/64137254/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-