From nobody Thu Mar 28 16:15:28 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+51446+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+51446+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1574938367; cv=none; d=zohomail.com; s=zohoarc; b=IVlv3N5XSaIGlI1qmm47QIkZRRKXeu372D4LLOadXNv4DSWkpXZaJgNsa/qnX6rWpv0CNYZkSfHTZPRGOyr5l5Rk+CLnxXS7w1hfjMS66QB4yeMmVs0oGZcEnBMnk9/lcphqAKs3VCPq5H9BTBlmLIA/GqiM304qdGXOWjVJWn8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1574938367; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=jMkZ0PVulOju4yUhHjaL/6YxoGgEZeTyQe9Y3voU0Ac=; b=bWrZAmslEk/rpGq4gGxJpthHw1HLL6qvIzvNjarS1alnsvwZFnPg7C7wQqe93S1kn9VoKivpF8Bt6uWk6U5rh2gVMWTtKN7HtYwx+NemMUari+SYaDiO0vsKDW7xRXOLOUQONO0ZtQdy1+lu2IZKXUNBI0J/OWIYBJXr/by0Wvc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+51446+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1574938367039132.93694415681477; Thu, 28 Nov 2019 02:52:47 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id CmuPYY1788612xo3WvSndslv; Thu, 28 Nov 2019 02:52:46 -0800 X-Received: from mail-yb1-f195.google.com (mail-yb1-f195.google.com [209.85.219.195]) by mx.groups.io with SMTP id smtpd.web10.3142.1574920612153467261 for ; Wed, 27 Nov 2019 21:56:52 -0800 X-Received: by mail-yb1-f195.google.com with SMTP id n3so6297446ybm.7 for ; Wed, 27 Nov 2019 21:56:52 -0800 (PST) X-Gm-Message-State: Pxe1NuF3UGO48B8dQciKhYnkx1787277AA= X-Google-Smtp-Source: APXvYqw4tjLPoItR4nqKHABAzsJZfgKSv0N+XooseN8qMndMozbGFUlsub5qs384TT3b4rQXImfxUA== X-Received: by 2002:a25:d951:: with SMTP id q78mr21309819ybg.102.1574920611215; Wed, 27 Nov 2019 21:56:51 -0800 (PST) X-Received: from localhost.localdomain (c-73-73-210-170.hsd1.il.comcast.net. [73.73.210.170]) by smtp.gmail.com with ESMTPSA id 64sm8139227ywg.103.2019.11.27.21.56.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Nov 2019 21:56:50 -0800 (PST) From: "Alex James" To: devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao Subject: [edk2-devel] [PATCH v1] MdePkg: Use __builtin_offset with CLANGPDB toolchain Date: Wed, 27 Nov 2019 23:56:45 -0600 Message-Id: <20191128055645.53053-1-theracermaster@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,theracermaster@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1574938366; bh=uT9A3tkS8N9Cf6kEZBPnGS9pvCLgbvAIqX3/YnzBjUc=; h=Cc:Date:From:Reply-To:Subject:To; b=SWz+73mwASjRf7ib2Rp6SOjctiJhgssON59PD+NuNNbocKLmHPmlj7KbpimHa2uPrWE bOBHxECk1ygaVGqgIWv7raFO8bjK/IEESvmJ7HT0TTiXjgr04iTJQrshqXUYne/2RfqgY eSte0oBg5rLnwo3NHey6RvE0Iq02QYq8tus= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" CLANGPDB does not define __GNUC__, but it does define __clang__. Check for the __clang__ preprocessor definition to use __builtin_offsetof to implement the OFFSET_OF macro. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Alex James Reviewed-by: Philippe Mathieu-Daude --- MdePkg/Include/Base.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h index 4680e64136..e0bcd0ae67 100644 --- a/MdePkg/Include/Base.h +++ b/MdePkg/Include/Base.h @@ -781,11 +781,9 @@ typedef UINTN *BASE_LIST; @return Offset, in bytes, of field. =20 **/ -#ifdef __GNUC__ -#if __GNUC__ >=3D 4 +#if (defined(__GNUC__) && __GNUC__ >=3D 4) || defined(__clang__) #define OFFSET_OF(TYPE, Field) ((UINTN) __builtin_offsetof(TYPE, Field)) #endif -#endif =20 #ifndef OFFSET_OF #define OFFSET_OF(TYPE, Field) ((UINTN) &(((TYPE *)0)->Field)) --=20 2.24.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51446): https://edk2.groups.io/g/devel/message/51446 Mute This Topic: https://groups.io/mt/64067723/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-