From nobody Tue Apr 30 17:58:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+50867+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+50867+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1574147514; cv=none; d=zoho.com; s=zohoarc; b=GAGM00S0UnJHW4Hn9BklrR+bynS0AxJm1Jx22MjGOS/lhE4hqaQIalzgS5z3jOLmdL6Yto1sP26v+5E6HfsCJ/2nlLFvsDMGgCoUUXnHC8WOZqVmvrdJE8msE8v7j8bUrp76p0R/HlSngDkhhaHmvLfzwNNUa9FVwfrciv7Bw/I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1574147514; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=vuStzgwC38hIocBoJ0Q8LjFSHgcVncwxSVIWsqjUP3Y=; b=bC1njlLdBmtkFPM1Sm8wyzqNmmUPHak3StM1DmbuGN23ARnU+iJVwAYH/aNCNm6yefZCU77JuAbvs6ccMcjqPdwOtpBzUs2dXEWnNCNc7CgYk/JXpKXgG5lL0hm3o8qYSMdAi5tZkuW0iTIbgiez0QTM6IPqxcwETTUVkIXjxyg= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+50867+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1574147514757354.7964834943888; Mon, 18 Nov 2019 23:11:54 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id aaaaYY1788612xaaaaaaaaaa; Mon, 18 Nov 2019 23:11:53 -0800 X-Received: from mga05.intel.com (mga05.intel.com []) by mx.groups.io with SMTP id smtpd.web11.17938.1574147512882678979 for ; Mon, 18 Nov 2019 23:11:53 -0800 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2019 23:11:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,322,1569308400"; d="scan'208";a="218155749" X-Received: from makuback-desk1.amr.corp.intel.com ([10.7.159.162]) by orsmga002.jf.intel.com with ESMTP; 18 Nov 2019 23:11:48 -0800 From: "Kubacki, Michael A" To: devel@edk2.groups.io Cc: Dandan Bi , Liming Gao , Jian J Wang , Hao A Wu Subject: [edk2-devel] [PATCH V3 1/2] MdeModulePkg PeiCore: Improve PeiInstallPeiMemory() description Date: Mon, 18 Nov 2019 23:11:40 -0800 Message-Id: <20191119071141.17192-2-michael.a.kubacki@intel.com> In-Reply-To: <20191119071141.17192-1-michael.a.kubacki@intel.com> References: <20191119071141.17192-1-michael.a.kubacki@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.a.kubacki@intel.com X-Gm-Message-State: aaaaaaaaaaaaaaaaaaaaaaaax1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1574147513; bh=d82Ijwl4R8Yxv1REJYa32vYtsjUHrZqRTd3Lq9otvpQ=; h=Cc:Date:From:Reply-To:Subject:To; b=MO0jKOvXj3vimB9wDt2h+UdTgKuMgKjLH2qY/BjiuLNDyBtfzAIJeZri51DnllxPeYd 3/HTFoCH85MYEOYhwgu4CAuS6/L2clKdcMDU9omR26H4UPKmS4IerQ1NuHyYynLAzIeCw RsLbU2ooJVaqaz/MJHzLgTOxpJIaz7UODK0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Updates the function description for PeiInstallPeiMemory () to be more helpful. The description is based on that given in the PI Specification Version 1.7. Cc: Dandan Bi Cc: Liming Gao Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Michael Kubacki Reviewed-by: Jian J Wang Reviewed-by: Liming Gao --- Notes: V3 Changes: 1. Remove the change to PiPeiCis.h as it is moved to a separate patch. =20 V2 Changes: 1. Updated the status code return values to those defined in the function description in the PI specification, Vol 1 v1.7. 2. Updated the EFI_PEI_INSTALL_PEI_MEMORY function description in PiPeiCis.h. MdeModulePkg/Core/Pei/PeiMain.h | 28 ++++++++++++++---- MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 30 ++++++++++++++------ 2 files changed, 43 insertions(+), 15 deletions(-) diff --git a/MdeModulePkg/Core/Pei/PeiMain.h b/MdeModulePkg/Core/Pei/PeiMai= n.h index f2aa97c664..0d3d62dbbe 100644 --- a/MdeModulePkg/Core/Pei/PeiMain.h +++ b/MdeModulePkg/Core/Pei/PeiMain.h @@ -898,15 +898,31 @@ InitializeMemoryServices ( ); =20 /** + Registers the found memory configuration with the PEI Foundation. =20 - Install the permanent memory is now available. - Creates HOB (PHIT and Stack). + This service enables PEIMs to register the permanent memory configuratio= n that has been initialized + with the PEI Foundation. The result of this call-set is the creation of = the appropriate Hand-Off Block + (HOB) describing the physical memory. =20 - @param PeiServices An indirect pointer to the EFI_PEI_SERVICES table= published by the PEI Foundation. - @param MemoryBegin Start of memory address. - @param MemoryLength Length of memory. + The usage model is that the PEIM that discovers the permanent memory sha= ll invoke this service. + This routine will store discovered memory information in the PeiCore's p= rivate data, and set the + SwitchStackSignal flag. After the PEIM who discovered memory is dispatch= ed, the PeiDispatcher will + migrate temporary memory to permanent memory. =20 - @return EFI_SUCCESS Always success. + The memory reported is a single contiguous run. It should be enough to a= llocate a PEI stack and + some HOB list. The full memory map will be reported using the appropriat= e memory HOBs. The + PEI Foundation will follow up with an installation of EFI_PEI_PERMANENT_= MEMORY_INSTALLED_PPI. + + Any invocations of this service after the first invocation which returns= EFI_SUCCESS will be ignored. + + @param[in] PeiServices An indirect pointer to the EFI_PEI_SERVICES t= able published by the PEI Foundation. + @param[in] MemoryBegin Start of memory address. + @param[in] MemoryLength Length of memory. + + @retval EFI_SUCCESS The region was successfully installed in a= HOB or this service was successfully + invoked earlier and no HOB modification wi= ll occur. + @retval EFI_INVALID_PARAMETER MemoryBegin and MemoryLength are illegal f= or this system. + @retval EFI_OUT_OF_RESOURCES There is no additional space for HOB creat= ion. =20 **/ EFI_STATUS diff --git a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c b/MdeModulePkg/C= ore/Pei/Memory/MemoryServices.c index 706837890f..679ac20493 100644 --- a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c +++ b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c @@ -1,7 +1,7 @@ /** @file EFI PEI Core memory services =20 -Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
+Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -55,19 +55,31 @@ InitializeMemoryServices ( } =20 /** + Registers the found memory configuration with the PEI Foundation. =20 - This function registers the found memory configuration with the PEI Foun= dation. + This service enables PEIMs to register the permanent memory configuratio= n that has been initialized + with the PEI Foundation. The result of this call-set is the creation of = the appropriate Hand-Off Block + (HOB) describing the physical memory. =20 The usage model is that the PEIM that discovers the permanent memory sha= ll invoke this service. - This routine will hold discoveried memory information into PeiCore's pri= vate data, - and set SwitchStackSignal flag. After PEIM who discovery memory is dispa= tched, - PeiDispatcher will migrate temporary memory to permenement memory. + This routine will store discovered memory information in the PeiCore's p= rivate data, and set the + SwitchStackSignal flag. After the PEIM who discovered memory is dispatch= ed, the PeiDispatcher will + migrate temporary memory to permanent memory. =20 - @param PeiServices An indirect pointer to the EFI_PEI_SERVICES ta= ble published by the PEI Foundation. - @param MemoryBegin Start of memory address. - @param MemoryLength Length of memory. + The memory reported is a single contiguous run. It should be enough to a= llocate a PEI stack and + some HOB list. The full memory map will be reported using the appropriat= e memory HOBs. The + PEI Foundation will follow up with an installation of EFI_PEI_PERMANENT_= MEMORY_INSTALLED_PPI. =20 - @return EFI_SUCCESS Always success. + Any invocations of this service after the first invocation which returns= EFI_SUCCESS will be ignored. + + @param[in] PeiServices An indirect pointer to the EFI_PEI_SERVICES t= able published by the PEI Foundation. + @param[in] MemoryBegin Start of memory address. + @param[in] MemoryLength Length of memory. + + @retval EFI_SUCCESS The region was successfully installed in a= HOB or this service was successfully + invoked earlier and no HOB modification wi= ll occur. + @retval EFI_INVALID_PARAMETER MemoryBegin and MemoryLength are illegal f= or this system. + @retval EFI_OUT_OF_RESOURCES There is no additional space for HOB creat= ion. =20 **/ EFI_STATUS --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#50867): https://edk2.groups.io/g/devel/message/50867 Mute This Topic: https://groups.io/mt/60551647/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 17:58:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+50868+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+50868+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1574147515; cv=none; d=zoho.com; s=zohoarc; b=NptxP7pnkaXf9rWbTpuF5bSE8IyVKGylId4awl6fgX5/I650+nZsPunmy/4orJ9PQA/FvPHG0vciY3Vhj7XRXtk/i4XFAnz9nvuf6zVcP0p2k8IOUq9eA8+Rnc5QjB5arbeNZkiSRVys2mmwXOs5KTfdGyx9gB9JxyuflmN//Zo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1574147515; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=fii4Nb02qrtoNA8QrDcg1e3MU5xpbCk63fHMVzsJvNo=; b=FKw5f08YukeVyszK7CzFG65/+aYIKrEd16wdm79vc1Flu60HfWvC91qW+5dFxkCBh3APda75JIw9Q+E1c8xtgpCb7ynv2IHOtMpHQgSrJBgTcN7/Sbh8HJYcNlNCAuOX2zcGwg7xIR2cOOVcomvSIrtSZAO8oE+Gx0QCb5DehCk= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+50868+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1574147515092944.1523328515376; Mon, 18 Nov 2019 23:11:55 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id aaaaYY1788612xaaaaaaaaaa; Mon, 18 Nov 2019 23:11:54 -0800 X-Received: from mga05.intel.com (mga05.intel.com []) by mx.groups.io with SMTP id smtpd.web11.17938.1574147512882678979 for ; Mon, 18 Nov 2019 23:11:54 -0800 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2019 23:11:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,322,1569308400"; d="scan'208";a="218155766" X-Received: from makuback-desk1.amr.corp.intel.com ([10.7.159.162]) by orsmga002.jf.intel.com with ESMTP; 18 Nov 2019 23:11:50 -0800 From: "Kubacki, Michael A" To: devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao Subject: [edk2-devel] [PATCH V1 2/2] MdePkg PiPeiCis.h: Improve PeiInstallPeiMemory() description Date: Mon, 18 Nov 2019 23:11:41 -0800 Message-Id: <20191119071141.17192-3-michael.a.kubacki@intel.com> In-Reply-To: <20191119071141.17192-1-michael.a.kubacki@intel.com> References: <20191119071141.17192-1-michael.a.kubacki@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.a.kubacki@intel.com X-Gm-Message-State: aaaaaaaaaaaaaaaaaaaaaaaax1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1574147514; bh=+iTINngqCLlCTfRjaVkX5NwSnMNUHrUKWQEPVmEjhYY=; h=Cc:Date:From:Reply-To:Subject:To; b=g0GzxFAZ1SDvM6aVwYdCfNfJ5251VRE15sMEcUsXZE0X77ZyXaR9k/fuUZV8LzGRK8x ZjOiXvxzTyaamzc1AjB0qQ76jBN1ZvN0WBOcoa0Qkw3rMj3qySRYO0KNBBL7fBgEIk2Ps vyUmBafBLp/9OZDSggS5DNbPn6vITKjEiUQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Updates the function description for PeiInstallPeiMemory () to be more helpful. The description is based on that given in the PI Specification Version 1.7. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Michael Kubacki Reviewed-by: Liming Gao --- MdePkg/Include/Pi/PiPeiCis.h | 26 ++++++++++++++++---- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/MdePkg/Include/Pi/PiPeiCis.h b/MdePkg/Include/Pi/PiPeiCis.h index d9d4ed7d41..e8c48acb21 100644 --- a/MdePkg/Include/Pi/PiPeiCis.h +++ b/MdePkg/Include/Pi/PiPeiCis.h @@ -422,13 +422,29 @@ EFI_STATUS ); =20 /** - This function registers the found memory configuration with the PEI Foun= dation. + Registers the found memory configuration with the PEI Foundation. =20 - @param PeiServices An indirect pointer to the EFI_PEI_SERVICES tab= le published by the PEI Foundation. - @param MemoryBegin The value of a region of installed memory. - @param MemoryLength The corresponding length of a region of install= ed memory. + This service enables PEIMs to register the permanent memory configuratio= n that has been initialized + with the PEI Foundation. The result of this call-set is the creation of = the appropriate Hand-Off Block + (HOB) describing the physical memory. =20 - @retval EFI_SUCCESS The region was successfully installed in a= HOB. + The usage model is that the PEIM that discovers the permanent memory sha= ll invoke this service. + This routine will store discovered memory information in the PeiCore's p= rivate data, and set the + SwitchStackSignal flag. After the PEIM who discovered memory is dispatch= ed, the PeiDispatcher will + migrate temporary memory to permanent memory. + + The memory reported is a single contiguous run. It should be enough to a= llocate a PEI stack and + some HOB list. The full memory map will be reported using the appropriat= e memory HOBs. The + PEI Foundation will follow up with an installation of EFI_PEI_PERMANENT_= MEMORY_INSTALLED_PPI. + + Any invocations of this service after the first invocation which returns= EFI_SUCCESS will be ignored. + + @param[in] PeiServices An indirect pointer to the EFI_PEI_SERVICES t= able published by the PEI Foundation. + @param[in] MemoryBegin Start of memory address. + @param[in] MemoryLength Length of memory. + + @retval EFI_SUCCESS The region was successfully installed in a= HOB or this service was successfully + invoked earlier and no HOB modification wi= ll occur. @retval EFI_INVALID_PARAMETER MemoryBegin and MemoryLength are illegal f= or this system. @retval EFI_OUT_OF_RESOURCES There is no additional space for HOB creat= ion. =20 --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#50868): https://edk2.groups.io/g/devel/message/50868 Mute This Topic: https://groups.io/mt/60551648/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-