From nobody Tue Feb 10 02:48:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+49796+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+49796+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1572588869; cv=none; d=zoho.com; s=zohoarc; b=fpJgrb9LtmfgP9rwWc7Jr8siHCxMBWvyyF4rGwpF9bpk8JEqFD7/TMRLmPjcs+6h1DA8PBq+j2uSjGsDMXj65EISwJsrSovC9QM/yxP4NvaU4ruNWIYwb9ZZQoCjhqPrjSpBBzyBnzgnJULk5zbl4xUcDRoALX/QHMNn76jRhnU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1572588869; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=iP8G13b28E2oEroX/Y+Bnws0xcb3E733v8u+Y4Mvt1c=; b=gi2fGaNOvOrEWX0ivEG3M48VpVk6hGpW1GFMGVl100JCgjX+QCZ9dnVgmQQKFU08DXb0AXmrkvbFX1C9zdfx/D7QoSFJ7Ix2HmL0M5yeWCcHd1YBBXJ1J9oonIduRDaPhjvwzieDnna42qWcRggIXZDpYD8AwWJshHJKbdHS/BE= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+49796+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1572588869342201.11797565908978; Thu, 31 Oct 2019 23:14:29 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id KXMEYY1788612xB3R4Z3vN9s; Thu, 31 Oct 2019 23:14:28 -0700 X-Received: from mga17.intel.com (mga17.intel.com []) by mx.groups.io with SMTP id smtpd.web11.565.1572588865857342767 for ; Thu, 31 Oct 2019 23:14:28 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Oct 2019 23:14:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,254,1569308400"; d="scan'208";a="204426480" X-Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by orsmga006.jf.intel.com with ESMTP; 31 Oct 2019 23:14:27 -0700 From: "Zhang, Shenglei" To: devel@edk2.groups.io Cc: Dandan Bi , Eric Dong Subject: [edk2-devel] [PATCH v3 2/4] MdeModulePkg/HiiDatabaseDxe: ASSERT StringPtr Date: Fri, 1 Nov 2019 14:14:15 +0800 Message-Id: <20191101061417.28896-3-shenglei.zhang@intel.com> In-Reply-To: <20191101061417.28896-1-shenglei.zhang@intel.com> References: <20191101061417.28896-1-shenglei.zhang@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,shenglei.zhang@intel.com X-Gm-Message-State: f8fP3PLftmjk0xTqykprmynGx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1572588868; bh=tnaLCUidL/llwyNdw47ls1fP1ZD+M+GxnSgEKJGMjJE=; h=Cc:Date:From:Reply-To:Subject:To; b=cfQgzFHVCQ3/GyB6CFZUMll1Ww281PmAAyFWEJxwRy5rPXx33vubUf80ZbjDYoOdvQY UbNjJ1LFPwRMKnfgFE/2csP03gccZZGm2CAaIY9ovo0iDmaF9Sj9HOz+jE7RV5/O3Pddd By+OiSgNnS1Ww7c0gopM1/xFGXGmcl9TKBs= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The caller of CompareAndMergeDefaultString has checked that AltCfgResp must contain AltConfigHdr. So we add ASSERT to assume StringPtr is not NULL. Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Shenglei Zhang Reviewed-by: Dandan Bi --- MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 1 + 1 file changed, 1 insertion(+) diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c b/MdeMod= ulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c index 71ea25bc19bf..2cad6d29f455 100644 --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c @@ -909,6 +909,7 @@ CompareAndMergeDefaultString ( // To find the with AltConfigHdr in AltCfgResp, ignore other <= AltResp> which follow it. // StringPtr =3D StrStr (*AltCfgResp, AltConfigHdr); + ASSERT (StringPtr !=3D NULL); StringPtrNext =3D StrStr (StringPtr + 1, L"&GUID"); if (StringPtrNext !=3D NULL) { TempCharA =3D *StringPtrNext; --=20 2.18.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49796): https://edk2.groups.io/g/devel/message/49796 Mute This Topic: https://groups.io/mt/40403788/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-