From nobody Fri Mar 29 10:32:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+49681+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+49681+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1572455080; cv=none; d=zoho.com; s=zohoarc; b=KRfauu19tMQUvZmjSI3K0zbiOHhdtsWIvmhzhJreTdb+7uc32hVCWGWuZIQUeLz0W8FIYwvep9dxVhgoKb50enLJ+8mDv4RFyJlu6F2r/FMNzdUC37W8vp4rfqQ5lLeh9Rlvwtdj0VAW/PExOENlkZhSYgTfnEnSk5ohOXo/3BQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1572455080; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=SbqgnhCrJLY23B2C5krjbfgp9mbOV47bkwo5pbWpxmU=; b=fwgM/i4WNE7esDfDcMn0ZEhcgFU/rHsOieUTKy3RgOLIK6ujOF1YMcR+pQQ8vCMD8mqVmVY6I/ll8SywncfNyQWHpOYWktQkdyKSi1AT3lydd2t1QqCkCx/4viftuP/nt/Lyx3o2FLvuMGDkeNkT94H+o7qGU6qwh6aHkucHchk= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+49681+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1572455079924965.5238064598601; Wed, 30 Oct 2019 10:04:39 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id aaaaYY1788612xaaaaaaaaaa; Wed, 30 Oct 2019 10:04:39 -0700 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.7795.1572455077896369576 for ; Wed, 30 Oct 2019 10:04:38 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 10:04:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,248,1569308400"; d="scan'208";a="198736462" X-Received: from paagyema-desk2.amr.corp.intel.com ([10.24.15.58]) by fmsmga008.fm.intel.com with ESMTP; 30 Oct 2019 10:04:36 -0700 From: "Agyeman, Prince" To: devel@edk2.groups.io Cc: Ankit Sinha , Nate DeSimone , Kubacki Michael A Subject: [edk2-devel] [edk2-platforms] [PATCH] SimicsOpenBoardPkg: Fix gcc build failure Date: Wed, 30 Oct 2019 10:04:36 -0700 Message-Id: <20191030170436.16708-1-prince.agyeman@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,prince.agyeman@intel.com X-Gm-Message-State: aaaaaaaaaaaaaaaaaaaaaaaax1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1572455079; bh=FbAdeRNWPHQ9MNZZxuxScnsKGjRIosRMoDc6xLGExyM=; h=Cc:Date:From:Reply-To:Subject:To; b=e2YLior4cjrRtRfTJPyneliODH+rlJsplxBqIyXuCJVu29MfEvqJRTdgm1MFz3IOY2h iCzs5vxqDJt6J9wx6y9ljP0iOO9ZyP0EKCI8mGFAn0Y3BUiSVYwgUoWGaaNTrDCP3mgCX mPOByfj/rTCX3GLPpkSkWAlrbPhX/dwGJZw= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2225 Currently, gcc 5 encounters an error "unused-but-set-variable" in BdsPlatform.c as a result of a Status variable not being used after it's set. This was fixed by printing the Status variable when EfiBootManagerDeleteLoadOptionVariable function encounters an error Cc: Ankit Sinha Cc: Nate DeSimone Cc: Kubacki Michael A Signed-off-by: Prince Agyeman Reviewed-by: Michael Kubacki Reviewed-by: Nate DeSimone --- .../Library/PlatformBootManagerLib/BdsPlatform.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerL= ib/BdsPlatform.c b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootMa= nagerLib/BdsPlatform.c index 7aa3860f75..a4b010be63 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsP= latform.c +++ b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsP= latform.c @@ -348,6 +348,10 @@ PlatformBootManagerBeforeConsole ( NvBootOptions =3D EfiBootManagerGetLoadOptions (&NvBootOptionCount, Load= OptionTypeBoot); for (Index =3D 0; Index < NvBootOptionCount; Index++) { Status =3D EfiBootManagerDeleteLoadOptionVariable (NvBootOptions[Index= ].OptionNumber, LoadOptionTypeBoot); + if(EFI_ERROR (Status)){ + DEBUG ((DEBUG_ERROR, + "%a: removing Boot#%04x %r\n", __FUNCTION__, (UINT32)NvBootOptio= ns[Index].OptionNumber, Status)); + } } =20 InstallDevicePathCallback (); --=20 2.19.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49681): https://edk2.groups.io/g/devel/message/49681 Mute This Topic: https://groups.io/mt/39839161/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-