From nobody Wed May 15 10:40:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+49572+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+49572+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1572313274; cv=none; d=zoho.com; s=zohoarc; b=k6DCkW1Q0sfWbc/zrh/MU3esk8L5tTgrujOkDqA5qsrz7t/y+0MOl9lVG8Yd3MOfu1YXrhJsQnDSObVk3nqytYNIosxhHxS0wg5fDD9Rj5fPS3fkpFV0i3lA+6z8679HifSBwnrhWX0REB7OtBsqvjR00kYkSb/ZI/5TlXhsqBQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1572313274; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=IId34PnaYNgrnG1zjBvipRfHRbVFk1Sz0URjpcgfkRE=; b=ctr+sGRCnS/zcsva0BWG89SYbdWmu0jg1LNg93BxN0E7cZ9ItqI/2l9wuQiEElYGjEzSL8BOtwSgbTQVu5aN0RD2QehoPfHG5Ic+uQZf3oAMqoT/rkzNe6jf3lCdOrnBBOTL7J3dpEFTS3oQDEiX4r+Tj1nSdfnbew2Wq7OLH+I= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+49572+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1572313274642489.9143253991649; Mon, 28 Oct 2019 18:41:14 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 8c3IYY1788612xf0Qc5XGu52; Mon, 28 Oct 2019 18:41:14 -0700 X-Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web09.6623.1572313273450321291 for ; Mon, 28 Oct 2019 18:41:13 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Oct 2019 18:41:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,242,1569308400"; d="scan'208";a="224817340" X-Received: from shwdeopenpsi787.ccr.corp.intel.com ([10.239.158.56]) by fmsmga004.fm.intel.com with ESMTP; 28 Oct 2019 18:41:12 -0700 From: "Siyuan, Fu" To: devel@edk2.groups.io Cc: Jiaxin Wu Subject: [edk2-devel] [Patch] NetworkPkg/SnpDxe: Use PcdGetBool() instead of FixedPcdGetBool in Snp.c Date: Tue, 29 Oct 2019 09:41:10 +0800 Message-Id: <20191029014110.18728-1-siyuan.fu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,siyuan.fu@intel.com X-Gm-Message-State: 56pxF4qGUPTg2Pgma3gUI0Qcx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1572313274; bh=FF8jn2A0blHCGDbA1Nft6neII/7mfE19N+ya2D0LGwA=; h=Cc:Date:From:Reply-To:Subject:To; b=VuCFB0NMoYPHAdKWLb7EmlAvMvzlMCIrPOIPcK8oVCHpR5zZYMnNVRNkpjCkWE0dECV 9ETI1npKUmpyucwJMJgJOyPzlB/3/+Nd65XkZ7pLLcLsqZHCRZjoFpGpIUynO8PxSYOL/ oFbg040x7CU4aZaF30ar3MgRRoB7PUVeh8E= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" This patch fixes a problem introduced by commit 61bb6eeb4d93c0a34c1995d87914ab41398f9550. The PcdSnpCreateExitBootServicesEvent is not guaranteed to be FixedAtBuild, so use PcdGetBool() to supports both fixed and patchable PCD. Change-Id: Ic1791bb598306e9251792113797c3bad317d0dda Cc: Jiaxin Wu Signed-off-by: Siyuan Fu Reviewed-by: Jiaxin Wu --- NetworkPkg/SnpDxe/Snp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NetworkPkg/SnpDxe/Snp.c b/NetworkPkg/SnpDxe/Snp.c index 9fb007f7ae..1099dbfa6a 100644 --- a/NetworkPkg/SnpDxe/Snp.c +++ b/NetworkPkg/SnpDxe/Snp.c @@ -647,7 +647,7 @@ SimpleNetworkDriverStart ( PxeShutdown (Snp); PxeStop (Snp); =20 - if (FixedPcdGetBool (PcdSnpCreateExitBootServicesEvent)) { + if (PcdGetBool (PcdSnpCreateExitBootServicesEvent)) { // // Create EXIT_BOOT_SERIVES Event // @@ -780,7 +780,7 @@ SimpleNetworkDriverStop ( return Status; } =20 - if (FixedPcdGetBool (PcdSnpCreateExitBootServicesEvent)) { + if (PcdGetBool (PcdSnpCreateExitBootServicesEvent)) { // // Close EXIT_BOOT_SERIVES Event // --=20 2.19.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49572): https://edk2.groups.io/g/devel/message/49572 Mute This Topic: https://groups.io/mt/39177854/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-