From nobody Sat Apr 27 11:54:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+49154+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+49154+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1571293279; cv=none; d=zoho.com; s=zohoarc; b=aDVi7mHv9NYJQRrUCKc5hthjiT8fhxXiYRv9n9bk0eVOVvdJIW1HWuui0/luYyuT71Y9b5Dg/hhxvQn4P2KKlgUIT5FqxQyAekUgbSA4RJnyb00buW1Y7YVoRXagk94nDjpRYzkaOJLBHv6UxCg1+fxsmO4KQ82V/eyfoKG4dek= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571293279; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=3ej8ofGp/4riA9XYIGksS9TOYQlWU68ec4ClsWqK6Vs=; b=mCbvyGTMxOWVkIHvcTgjjFfnly6cAzQnMd8nUyl+z2qHhPjCmnKXY54Wx8zLZ1RMtf1pNLNfq4+DVcaripIu1xYTpUGNUsKsX+X76Vvt7hqAeDEXRU6MoOvKcrvnt59lttf2P6ckZeX21NnLSEkn89/VXdNH5qTPU/ECMNoc9OE= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+49154+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1571293278971819.0894558971294; Wed, 16 Oct 2019 23:21:18 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id hENXYY1788612x3ffZFMY4m6; Wed, 16 Oct 2019 23:21:18 -0700 X-Received: from mga04.intel.com (mga04.intel.com []) by mx.groups.io with SMTP id smtpd.web12.2806.1571293275521352376 for ; Wed, 16 Oct 2019 23:21:16 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2019 23:21:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,306,1566889200"; d="scan'208";a="208164434" X-Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by orsmga002.jf.intel.com with ESMTP; 16 Oct 2019 23:21:15 -0700 From: "Zhang, Shenglei" To: devel@edk2.groups.io Cc: Hao A Wu , Ray Ni Subject: [edk2-devel] [PATCH] MdeModulePkg/SdBlockIoPei: Add check for DeviceIndex Date: Thu, 17 Oct 2019 14:21:11 +0800 Message-Id: <20191017062111.10568-2-shenglei.zhang@intel.com> In-Reply-To: <20191017062111.10568-1-shenglei.zhang@intel.com> References: <20191017062111.10568-1-shenglei.zhang@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,shenglei.zhang@intel.com X-Gm-Message-State: fRfFeIeLSh1KhTuWbwRCN34ux1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1571293278; bh=aSLokrlYVzGnPLtwJn5uWgldXgDz6YFz2imuqpYVqC4=; h=Cc:Date:From:Reply-To:Subject:To; b=d0mzt/JNwdlSy6XYBviWwcYrw2GG3XHx3vh2DUCRbL+j2A1lDnZBVDvcEs85ZAveIX7 xaq5Gbui1Ju0o/C3GhAg24HJbCAis/Y5FI4qDYFDnOsFsJAFzttNFLME9qbzzzyK10Csn breI7Fbyu6/eEbiWXoWfsv7aLjS542Z4ZbY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" DeviceIndex is used as index in Slot[]. The max size of Slot[] is SD_PEIM_MAX_SLOTS. So DeviceIndex should be checked before used. Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Shenglei Zhang --- MdeModulePkg/Bus/Sd/SdBlockIoPei/SdBlockIoPei.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdBlockIoPei.c b/MdeModulePkg= /Bus/Sd/SdBlockIoPei/SdBlockIoPei.c index 8fa58d65b22c..25530dcb34ce 100644 --- a/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdBlockIoPei.c +++ b/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdBlockIoPei.c @@ -174,7 +174,7 @@ SdBlockIoPeimGetMediaInfo ( =20 Private =3D GET_SD_PEIM_HC_PRIVATE_DATA_FROM_THIS (This); =20 - if ((DeviceIndex =3D=3D 0) || (DeviceIndex > Private->TotalBlkIoDevices)= ) { + if ((DeviceIndex =3D=3D 0) || (DeviceIndex > Private->TotalBlkIoDevices)= || (DeviceIndex > (SD_PEIM_MAX_SLOTS - 1))) { return EFI_INVALID_PARAMETER; } =20 @@ -252,7 +252,7 @@ SdBlockIoPeimReadBlocks ( return EFI_SUCCESS; } =20 - if ((DeviceIndex =3D=3D 0) || (DeviceIndex > Private->TotalBlkIoDevices)= ) { + if ((DeviceIndex =3D=3D 0) || (DeviceIndex > Private->TotalBlkIoDevices)= || (DeviceIndex > (SD_PEIM_MAX_SLOTS - 1))) { return EFI_INVALID_PARAMETER; } =20 --=20 2.18.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49154): https://edk2.groups.io/g/devel/message/49154 Mute This Topic: https://groups.io/mt/34685173/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-