From nobody Fri May 3 10:04:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+49061+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+49061+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=hpe.com ARC-Seal: i=1; a=rsa-sha256; t=1571211675; cv=none; d=zoho.com; s=zohoarc; b=D8q+lFIQ4OVQGfRnX4PVBrZBaS/nmxkjCb9A9YcD08YsRAgK16ocAkhSDFJtAsJJUeOAuDNXAONiNI1BHES8wpNZyuaSyqKDQ0FlKdv6I/BuT3jMFpiw9n5ZSS1IDnjxR5H1YANy9nnimyRb4SLfF4urkDCNQCefcEqdSrQ8F24= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571211675; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=jrRfczPqyPxwvfZQeWpc5wRalgDy2WECr4hv2sFiiaE=; b=B8szqEOA1022aIwrJkclzZ0lNpYrYd5vNfgBcOmgUSqwE7PXDSkmGFsvm9ko2FgD8cSiAp7x2BKPmmV7EgfqCu2aWU+k1OF3y8lQLgn4zLU+AcEFJpEF/z73NaEGX9UJjm5OWLqGrTdD4zhLdialrwrYmYurM+aqHH7vmmBTZhM= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+49061+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1571211675333321.8072541098088; Wed, 16 Oct 2019 00:41:15 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id LYVPYY1788612xlUaLUhlT0i; Wed, 16 Oct 2019 00:41:14 -0700 X-Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web11.2640.1571211672920526609 for ; Wed, 16 Oct 2019 00:41:13 -0700 X-Received: from pps.filterd (m0150242.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x9G7fBDj021166; Wed, 16 Oct 2019 07:41:11 GMT X-Received: from g2t2354.austin.hpe.com (g2t2354.austin.hpe.com [15.233.44.27]) by mx0a-002e3701.pphosted.com with ESMTP id 2vnwfn1h0u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Oct 2019 07:41:11 +0000 X-Received: from g2t2360.austin.hpecorp.net (g2t2360.austin.hpecorp.net [16.196.225.135]) by g2t2354.austin.hpe.com (Postfix) with ESMTP id DC758A2; Wed, 16 Oct 2019 07:40:44 +0000 (UTC) X-Received: from HAC31CEDWY.asiapacific.hpqcorp.net (hac31cedwy.asiapacific.hpqcorp.net [10.76.8.171]) by g2t2360.austin.hpecorp.net (Postfix) with ESMTP id 331A439; Wed, 16 Oct 2019 07:40:42 +0000 (UTC) From: "Wang, Sunny (HPS SW)" To: devel@edk2.groups.io Cc: Sunny Wang , Ray Ni , Zhichao Gao , Walon Li Subject: [edk2-devel] [PATCH] MdeModulePkg/BdsDxe: Make PlatformRecovery work regardless of OsIndications Date: Wed, 16 Oct 2019 15:40:07 +0800 Message-Id: <20191016074007.17572-1-sunnywang@hpe.com> MIME-Version: 1.0 X-HPE-SCL: -1 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunnywang@hpe.com X-Gm-Message-State: aU7msEql27jjwDSAnsmYbyWqx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1571211674; bh=jX2Pwh+aKwSOjQoKrqe78NVws6Ykq9eofqpmlp+7aPA=; h=Cc:Date:From:Reply-To:Subject:To; b=Z/rJE2yiCj/wPbF/fOkVs3E0gIi5TZmHFFFRutbkf1IlvS5qmHUS7idZf4Hw34n4fQY 1FHpzyEUMwAczp1DE6tf2+P9P/8zJb8vRYGW0Kkw7g2Hj1jKB4g0kb0z+1kcqiRI5O1Tm NunzUH3YUpcTjQdrN9MmRG7u3mA4ItNX/tI= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" According to the UEFI specification section 3.4.1 and 3.4.2, the OsRecovery= and PlatformRecovery options should still be processed regardless of the v= alue of OsIndications variable if processing of BootOrder does not result i= n success. Therefore, update the code to check PcdPlatformRecoverySupport i= nstead of the value of OsIndications variable (PlatformRecovery). Cc: Ray Ni Cc: Zhichao Gao Cc: Walon Li Signed-off-by: Sunny Wang Acked-by: Jian J Wang --- MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c b/MdeModulePkg/Univer= sal/BdsDxe/BdsEntry.c index d6ec31118c..d387dbe7ac 100644 --- a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c +++ b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c @@ -6,7 +6,7 @@ to enter BDS phase. =20 Copyright (c) 2004 - 2019, Intel Corporation. All rights reserved.
-(C) Copyright 2016 Hewlett Packard Enterprise Development LP
+(C) Copyright 2016-2019 Hewlett Packard Enterprise Development LP
(C) Copyright 2015 Hewlett-Packard Development Company, L.P.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -1069,7 +1069,7 @@ BdsEntry ( } =20 if (!BootSuccess) { - if (PlatformRecovery) { + if (PcdGetBool (PcdPlatformRecoverySupport)) { LoadOptions =3D EfiBootManagerGetLoadOptions (&LoadOptionCount, Load= OptionTypePlatformRecovery); ProcessLoadOptions (LoadOptions, LoadOptionCount); EfiBootManagerFreeLoadOptions (LoadOptions, LoadOptionCount); --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49061): https://edk2.groups.io/g/devel/message/49061 Mute This Topic: https://groups.io/mt/34557852/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-