From nobody Mon Apr 29 07:12:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+48863+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+48863+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1570866189; cv=none; d=zoho.com; s=zohoarc; b=A+3bC7GWRmeRRrT2tftikd90tdKzaP+u0bVdFXUt3lkvjfWfpU7p2buCdqZm/UHNhxh2OkHEPIDRWARnsn38bUaMTGf8yG75uaTmFnsMPEIoQaTu1673ldCCV6Cbi/n9tKI3GxQa1XLe49a5xcc8Ah8tkw/zdnTkX7TvPId9+SE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570866189; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=4sX18MhPLCpfGssgfKuukzxa3ROpLXy517tNyR1EzHA=; b=i+NJMXhGOm6jyTTo6OXIjn+9sf134CEGrKkBDEOuIH9x2LCNPzPmZsb6t+QGLj1CG/YaLlWZEABJGMIPcKErWiLkUiH9DafhSpbR7Sv+4FViYDuoPplNx7bUtTibQ9ehT4Wgcb9ASbdKj/gfr9vFn5gKKZEfE33VPV1ktsEUSv4= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+48863+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1570866189531645.9845576675691; Sat, 12 Oct 2019 00:43:09 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 1mzuYY1788612xr64nxyCbmV; Sat, 12 Oct 2019 00:43:08 -0700 X-Received: from mga05.intel.com (mga05.intel.com []) by mx.groups.io with SMTP id smtpd.web12.2688.1570866187085018288 for ; Sat, 12 Oct 2019 00:43:08 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Oct 2019 00:43:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,286,1566889200"; d="scan'208";a="198925960" X-Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by orsmga006.jf.intel.com with ESMTP; 12 Oct 2019 00:43:07 -0700 From: "Zhang, Shenglei" To: devel@edk2.groups.io Cc: Siyuan Fu , Jiaxin Wu Subject: [edk2-devel] [PATCH] NetworkPkg/DxeNetLib: Change the order of conditions in IF statement Date: Sat, 12 Oct 2019 15:43:02 +0800 Message-Id: <20191012074302.11928-2-shenglei.zhang@intel.com> In-Reply-To: <20191012074302.11928-1-shenglei.zhang@intel.com> References: <20191012074302.11928-1-shenglei.zhang@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,shenglei.zhang@intel.com X-Gm-Message-State: WDFteHXMUxAL1Zko5ssnwyhmx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1570866188; bh=j+dH7U1OnxnRnqVKAHmswXpdK/CvL8B3qBYGl0HB1f4=; h=Cc:Date:From:Reply-To:Subject:To; b=vV5s4WXYI8BHEqnHTPoxbbT1GZpEZZSxpE688sIibRRQGXMBX7cCYw7X5xnnfHK0cjH MoP6AryVYW24OAT48JrHEoT3pPlo4SZxmG3p5geVpe5QYvE2ZhM8KyNtVDXniSti4oL/l hVnnwdsULm/MmCchgCV3S9A9a8NdtLynSm0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The condition, NET_HEADSPACE(&(Nbuf->BlockOp[Index])) < Len, is meaningless if Index < 0. So 'Index < 0' should be performed first in the if statement. Cc: Siyuan Fu Cc: Jiaxin Wu Signed-off-by: Shenglei Zhang Reviewed-by: Siyuan Fu --- NetworkPkg/Library/DxeNetLib/NetBuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NetworkPkg/Library/DxeNetLib/NetBuffer.c b/NetworkPkg/Library/= DxeNetLib/NetBuffer.c index 2408e9a10456..a35e67aa1f6c 100644 --- a/NetworkPkg/Library/DxeNetLib/NetBuffer.c +++ b/NetworkPkg/Library/DxeNetLib/NetBuffer.c @@ -1063,7 +1063,7 @@ NetbufAllocSpace ( } else { NetbufGetByte (Nbuf, 0, &Index); =20 - if ((NET_HEADSPACE(&(Nbuf->BlockOp[Index])) < Len) && (Index > 0)) { + if ((Index > 0) && (NET_HEADSPACE(&(Nbuf->BlockOp[Index])) < Len)) { Index--; } } --=20 2.18.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48863): https://edk2.groups.io/g/devel/message/48863 Mute This Topic: https://groups.io/mt/34508855/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-