[edk2-devel] [edk2-platforms][PATCH v3 0/5] Various SMBIOS improvements

Pete Batard posted 5 patches 4 years, 5 months ago
Failed in applying to current master (apply log)
Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c   | 198 ++++++++++++--------
Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf |   2 +
Platform/RaspberryPi/RPi3/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c         | 167 ++++++++++++++++-
Platform/RaspberryPi/RPi3/Include/Protocol/RpiFirmware.h                  |  58 ++++--
Platform/RaspberryPi/RPi3/RPi3.dsc                                        |   4 +-
5 files changed, 333 insertions(+), 96 deletions(-)
[edk2-devel] [edk2-platforms][PATCH v3 0/5] Various SMBIOS improvements
Posted by Pete Batard 4 years, 5 months ago
Changes from v2:
- Consistent use of curly brackets for if statements
- Remove unused variables that may produce an issue with git bisect
- Use gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor to populate vendor

Note that 5/5, which has been R-b, is unchanged.

Pete Batard (5):
  Platform/RPi3/RpiFirmwareDxe: Add more query functions
  Platform/RPi3/RpiFirmwareDxe: Improve serial number population
  Platform/RPi3/PlatformSmbiosDxe: Improve population of SMBIOS entries
  Platform/RPi3/PlatformSmbiosDxe: Populate BIOS major/minor from PCD
  Platform/RPi3/PlatformSmbiosDxe: Derive RAM size from board revision

 Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c   | 198 ++++++++++++--------
 Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf |   2 +
 Platform/RaspberryPi/RPi3/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c         | 167 ++++++++++++++++-
 Platform/RaspberryPi/RPi3/Include/Protocol/RpiFirmware.h                  |  58 ++++--
 Platform/RaspberryPi/RPi3/RPi3.dsc                                        |   4 +-
 5 files changed, 333 insertions(+), 96 deletions(-)

-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#48814): https://edk2.groups.io/g/devel/message/48814
Mute This Topic: https://groups.io/mt/34485898/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH v3 0/5] Various SMBIOS improvements
Posted by Leif Lindholm 4 years, 5 months ago
On Fri, Oct 11, 2019 at 12:07:41PM +0100, Pete Batard wrote:
> Changes from v2:
> - Consistent use of curly brackets for if statements
> - Remove unused variables that may produce an issue with git bisect
> - Use gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor to populate vendor
> 
> Note that 5/5, which has been R-b, is unchanged.

For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as 48a95de81ede..2a4e369d588e.

Thanks!

/
    Leif

> Pete Batard (5):
>   Platform/RPi3/RpiFirmwareDxe: Add more query functions
>   Platform/RPi3/RpiFirmwareDxe: Improve serial number population
>   Platform/RPi3/PlatformSmbiosDxe: Improve population of SMBIOS entries
>   Platform/RPi3/PlatformSmbiosDxe: Populate BIOS major/minor from PCD
>   Platform/RPi3/PlatformSmbiosDxe: Derive RAM size from board revision
> 
>  Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c   | 198 ++++++++++++--------
>  Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf |   2 +
>  Platform/RaspberryPi/RPi3/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c         | 167 ++++++++++++++++-
>  Platform/RaspberryPi/RPi3/Include/Protocol/RpiFirmware.h                  |  58 ++++--
>  Platform/RaspberryPi/RPi3/RPi3.dsc                                        |   4 +-
>  5 files changed, 333 insertions(+), 96 deletions(-)
> 
> -- 
> 2.21.0.windows.1
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49028): https://edk2.groups.io/g/devel/message/49028
Mute This Topic: https://groups.io/mt/34485898/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-