From nobody Thu May 2 00:58:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+48778+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+48778+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1570761474; cv=none; d=zoho.com; s=zohoarc; b=WLftvvQKI0+TlW79fVP4cCzHfQ7K4kzOW9342+e9QbOxRnnndHVWqQfgHcxTi7lc+KVYr8k20na5LnKzK9K55sBhMm2W5WdvxOdOku6OpPYWMpHB6mwyGDWXdRigTZx5dMVSkEegVV7ySmcB5elMtURp2oQrbYSXkvhM8uiEnFI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570761474; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To; bh=kluoj+RUzRNaL+TXqUxg/e3to4y0c12rsI/9kTDu/XY=; b=YMBlDqUvg8fySAKJ2/br8wpQmoTcjeFZLU6JCL8eu7M3ryoJu0tDychQUca/6vM+fuAX93wFELmFZ2iCIbCe/kp09JJsackAQDS7B/tnA3Cscnvi+ylTi3PIELGTYK5G8KQQ5YfNt5EjOz5jDx/GvAkfZ5N1Qjb9taAFg4CDTXs= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+48778+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1570761474109517.842489738211; Thu, 10 Oct 2019 19:37:54 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id zYDbYY1788612xikh0U2hS9q; Thu, 10 Oct 2019 19:37:53 -0700 X-Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.5374.1570761473048977067 for ; Thu, 10 Oct 2019 19:37:53 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Oct 2019 19:37:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,282,1566889200"; d="scan'208";a="206305818" X-Received: from xianhu2x-mobl.ccr.corp.intel.com ([10.239.196.115]) by orsmga002.jf.intel.com with ESMTP; 10 Oct 2019 19:37:50 -0700 From: "xianhui liu" To: devel@edk2.groups.io Cc: Heinrich Schuchardt , Supreeth Venkatesh , Eric Jin , xianhui liu Subject: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Sync SNP ReceiveFilters change to IHV Date: Fri, 11 Oct 2019 10:37:47 +0800 Message-Id: <20191011023747.10472-1-xianhuix.liu@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,xianhuix.liu@intel.com X-Gm-Message-State: Qx6Zdkt6XBzp4sSAIVVjM4FDx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1570761473; bh=eg2++X2X6t5pSWy6mXsHpKrdYkL8X/MmY2WKYGIOpEI=; h=Cc:Date:From:Reply-To:Subject:To; b=jN0inYXxKE8t983UsjeWlnfejt55qkwHywG2u4bFKmP5tjGkzYnuLq6fjbcGPCFcEF5 BtI8NEi3SrZP7z4wCh5BJanYgAs5OK+hJl1ZljhluOmieuzLRHKSAr7RmXqfBQdDP3Amx cGXXC0dggFGik+H9ZVI0fczr4DuwzZ27P7Q= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2197 sync commit 3d98de052fcd47f187190802e6201ac6aaabfda7 on file EFI/Protocol/SimpleNetwork/BlackBoxTest /SimpleNetworkBBTestConformance.c to IHV Cc: Heinrich Schuchardt Cc: Supreeth Venkatesh Cc: Eric Jin Signed-off-by: xianhui liu Reviewed-by: Eric Jin --- .../BlackBoxTest/SimpleNetworkBBTestConformance.c | 223 +++++++++++++----= ---- 1 file changed, 138 insertions(+), 85 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleNetwork/Black= BoxTest/SimpleNetworkBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/IH= V/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestConformance.c index c758f560..682076ea 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleNetwork/BlackBoxTest= /SimpleNetworkBBTestConformance.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleNetwork/BlackBoxTest= /SimpleNetworkBBTestConformance.c @@ -626,22 +626,31 @@ BBTestReceiveFilterConformanceTest ( // Call ReceiveFilters() function if network interface not start. // Status =3D SnpInterface->ReceiveFilters (SnpInterface, 0, 0, FALSE, 0, N= ULL); - if ((Status =3D=3D EFI_NOT_STARTED) && (SnpInterface->Mode->State =3D=3D= EfiSimpleNetworkStopped)) { - AssertionType =3D EFI_TEST_ASSERTION_PASSED; + if (Status =3D=3D EFI_UNSUPPORTED) { + StandardLib->RecordMessage( + StandardLib, + EFI_VERBOSE_LEVEL_QUIET, + L"ReceiveFilters isn't supported, Status - %r\n", + Status + ); } else { - AssertionType =3D EFI_TEST_ASSERTION_FAILED; - } + if ((Status =3D=3D EFI_NOT_STARTED) && (SnpInterface->Mode->State =3D= =3D EfiSimpleNetworkStopped)) { + AssertionType =3D EFI_TEST_ASSERTION_PASSED; + } else { + AssertionType =3D EFI_TEST_ASSERTION_FAILED; + } =20 - StandardLib->RecordAssertion ( - StandardLib, - AssertionType, - gSimpleNetworkBBTestConformanceAssertionGuid006, - L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke Rec= eiveFilters() when network interface not start.", - L"%a:%d:Status - %r", - __FILE__, - (UINTN)__LINE__, - Status - ); + StandardLib->RecordAssertion ( + StandardLib, + AssertionType, + gSimpleNetworkBBTestConformanceAssertionGuid006, + L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke R= eceiveFilters() when network interface not start.", + L"%a:%d:Status - %r", + __FILE__, + (UINTN)__LINE__, + Status + ); + } =20 // // Assertion Point 5.6.2.2 @@ -653,22 +662,31 @@ BBTestReceiveFilterConformanceTest ( } =20 Status =3D SnpInterface->ReceiveFilters (SnpInterface, 0, 0, FALSE, 0, N= ULL); - if (Status =3D=3D EFI_DEVICE_ERROR) { - AssertionType =3D EFI_TEST_ASSERTION_PASSED; + if (Status =3D=3D EFI_UNSUPPORTED) { + StandardLib->RecordMessage( + StandardLib, + EFI_VERBOSE_LEVEL_QUIET, + L"ReceiveFilters isn't supported, Status - %r\n", + Status + ); } else { - AssertionType =3D EFI_TEST_ASSERTION_FAILED; - } + if (Status =3D=3D EFI_DEVICE_ERROR) { + AssertionType =3D EFI_TEST_ASSERTION_PASSED; + } else { + AssertionType =3D EFI_TEST_ASSERTION_FAILED; + } =20 - StandardLib->RecordAssertion ( - StandardLib, - AssertionType, - gSimpleNetworkBBTestConformanceAssertionGuid007, - L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke Rec= eiveFilters() when network interface not initialized.", - L"%a:%d:Status - %r", - __FILE__, - (UINTN)__LINE__, - Status - ); + StandardLib->RecordAssertion ( + StandardLib, + AssertionType, + gSimpleNetworkBBTestConformanceAssertionGuid007, + L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke R= eceiveFilters() when network interface not initialized.", + L"%a:%d:Status - %r", + __FILE__, + (UINTN)__LINE__, + Status + ); + } =20 // // Assertion Point 5.6.2.3 @@ -683,22 +701,31 @@ BBTestReceiveFilterConformanceTest ( // Call ReceiveFilters with invalide Enable // Status =3D SnpInterface->ReceiveFilters (SnpInterface, ~(SnpInterface->M= ode->ReceiveFilterMask), 0, FALSE, 0, NULL); - if (Status =3D=3D EFI_INVALID_PARAMETER) { - AssertionType =3D EFI_TEST_ASSERTION_PASSED; + if (Status =3D=3D EFI_UNSUPPORTED) { + StandardLib->RecordMessage( + StandardLib, + EFI_VERBOSE_LEVEL_QUIET, + L"ReceiveFilters isn't supported, Status - %r\n", + Status + ); } else { - AssertionType =3D EFI_TEST_ASSERTION_FAILED; - } + if (Status =3D=3D EFI_INVALID_PARAMETER) { + AssertionType =3D EFI_TEST_ASSERTION_PASSED; + } else { + AssertionType =3D EFI_TEST_ASSERTION_FAILED; + } =20 - StandardLib->RecordAssertion ( - StandardLib, - AssertionType, - gSimpleNetworkBBTestConformanceAssertionGuid008, - L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke Rec= eiveFilters() with invalid Enable.", - L"%a:%d:Status - %r", - __FILE__, - (UINTN)__LINE__, - Status - ); =20 + StandardLib->RecordAssertion ( + StandardLib, + AssertionType, + gSimpleNetworkBBTestConformanceAssertionGuid008, + L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke R= eceiveFilters() with invalid Enable.", + L"%a:%d:Status - %r", + __FILE__, + (UINTN)__LINE__, + Status + ); + } =20 // // Call ReceiveFilters with invalide MCastFilterCnt @@ -713,59 +740,85 @@ BBTestReceiveFilterConformanceTest ( MAC.Addr[5] =3D 0x02; =20 Status =3D SnpInterface->ReceiveFilters (SnpInterface, EFI_SIMPLE_NETW= ORK_RECEIVE_MULTICAST, 0, FALSE, SnpInterface->Mode->MaxMCastFilterCount + = 1, &MAC); - if (Status =3D=3D EFI_INVALID_PARAMETER) { - AssertionType =3D EFI_TEST_ASSERTION_PASSED; + if (Status =3D=3D EFI_UNSUPPORTED) { + StandardLib->RecordMessage( + StandardLib, + EFI_VERBOSE_LEVEL_QUIET, + L"ReceiveFilters isn't supported, Status - %r\n", + Status + ); } else { - AssertionType =3D EFI_TEST_ASSERTION_FAILED; + if (Status =3D=3D EFI_INVALID_PARAMETER) { + AssertionType =3D EFI_TEST_ASSERTION_PASSED; + } else { + AssertionType =3D EFI_TEST_ASSERTION_FAILED; + } + + StandardLib->RecordAssertion ( + StandardLib, + AssertionType, + gSimpleNetworkBBTestConformanceAssertionGuid009, + L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke= ReceiveFilters() with invalid MCastFilterCnt is greater than Snp->Mode->Ma= xMCastFilterCount.", + L"%a:%d:Status - %r", + __FILE__, + (UINTN)__LINE__, + Status + ); } =20 - StandardLib->RecordAssertion ( - StandardLib, - AssertionType, - gSimpleNetworkBBTestConformanceAssertionGuid009, - L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke R= eceiveFilters() with invalid MCastFilterCnt is greater than Snp->Mode->MaxM= CastFilterCount.", - L"%a:%d:Status - %r", - __FILE__, - (UINTN)__LINE__, - Status - ); - Status =3D SnpInterface->ReceiveFilters (SnpInterface, EFI_SIMPLE_NETW= ORK_RECEIVE_MULTICAST, 0, FALSE, 0, &MAC); - if (Status =3D=3D EFI_INVALID_PARAMETER) { - AssertionType =3D EFI_TEST_ASSERTION_PASSED; + if (Status =3D=3D EFI_UNSUPPORTED) { + StandardLib->RecordMessage( + StandardLib, + EFI_VERBOSE_LEVEL_QUIET, + L"ReceiveFilters isn't supported, Status - %r\n", + Status + ); } else { - AssertionType =3D EFI_TEST_ASSERTION_FAILED; + if (Status =3D=3D EFI_INVALID_PARAMETER) { + AssertionType =3D EFI_TEST_ASSERTION_PASSED; + } else { + AssertionType =3D EFI_TEST_ASSERTION_FAILED; + } + + StandardLib->RecordAssertion ( + StandardLib, + AssertionType, + gSimpleNetworkBBTestConformanceAssertionGuid043, + L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke= ReceiveFilters() with invalid MCastFilterCnt is 0.", + L"%a:%d:Status - %r", + __FILE__, + (UINTN)__LINE__, + Status + ); } =20 - StandardLib->RecordAssertion ( - StandardLib, - AssertionType, - gSimpleNetworkBBTestConformanceAssertionGuid043, - L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke R= eceiveFilters() with invalid MCastFilterCnt is 0.", - L"%a:%d:Status - %r", - __FILE__, - (UINTN)__LINE__, - Status - ); - Status =3D SnpInterface->ReceiveFilters (SnpInterface, EFI_SIMPLE_NETW= ORK_RECEIVE_MULTICAST, 0, FALSE, 1, NULL); - if (Status =3D=3D EFI_INVALID_PARAMETER) { - AssertionType =3D EFI_TEST_ASSERTION_PASSED; + if (Status =3D=3D EFI_UNSUPPORTED) { + StandardLib->RecordMessage( + StandardLib, + EFI_VERBOSE_LEVEL_QUIET, + L"ReceiveFilters isn't supported, Status - %r\n", + Status + ); } else { - AssertionType =3D EFI_TEST_ASSERTION_FAILED; + if (Status =3D=3D EFI_INVALID_PARAMETER) { + AssertionType =3D EFI_TEST_ASSERTION_PASSED; + } else { + AssertionType =3D EFI_TEST_ASSERTION_FAILED; + } + + StandardLib->RecordAssertion ( + StandardLib, + AssertionType, + gSimpleNetworkBBTestConformanceAssertionGuid010, + L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invo= ke ReceiveFilters() with MCastFilterCnt not match MCastFilter.", + L"%a:%d:Status - %r", + __FILE__, + (UINTN)__LINE__, + Status + ); } - - StandardLib->RecordAssertion ( - StandardLib, - AssertionType, - gSimpleNetworkBBTestConformanceAssertionGuid010, - L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke R= eceiveFilters() with MCastFilterCnt not match MCastFilter.", - L"%a:%d:Status - %r", - __FILE__, - (UINTN)__LINE__, - Status - ); - } =20 // --=20 2.14.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48778): https://edk2.groups.io/g/devel/message/48778 Mute This Topic: https://groups.io/mt/34482727/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-