From nobody Fri Mar 29 14:04:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+48633+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+48633+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1570614137; cv=none; d=zoho.com; s=zohoarc; b=FwiM/t/7LPXJXvm6hidvEhW1VUDfV1b3SwXknFL7eY0imUY5TJIBEli/S4zKXuNzOlTyrSeyhrOHpY781/p6qnjHrDSegl0NJfAnjVWggpgvEo+pk/PdO5mAvqE652W16zof5a/2iAkrNyv+7guvXpTFF796llRlo1SE+1gnHp0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570614137; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To; bh=MK7X/9wStvjCVcBxXo1SiK3GdTBe3Ma7J4tiOL8qXug=; b=aQjBYEJBqVNXqMofJX2864QxS82SqgPyX19g2/Qt4XbtE12QoCRqyQAZ160N41eZx/WBGETxQ4VFjOolBZAmLgT7nzfSBRvOoEmQ4rmmVj8akItPDuMVXqkMPhsUAlDvUlFecllqAXO1/ZnFjaZUSUBuEEKbzyG3pC4clFxaLhs= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+48633+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1570614136940875.5072495913621; Wed, 9 Oct 2019 02:42:16 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 2AgRYY1788612xP5ypRKUaQe; Wed, 09 Oct 2019 02:42:16 -0700 X-Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.3346.1570614135930429837 for ; Wed, 09 Oct 2019 02:42:15 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2019 02:42:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,273,1566889200"; d="scan'208";a="196871411" X-Received: from xianhu2x-mobl.ccr.corp.intel.com ([10.239.196.134]) by orsmga003.jf.intel.com with ESMTP; 09 Oct 2019 02:42:13 -0700 From: "xianhui liu" To: devel@edk2.groups.io Cc: Heinrich Schuchardt , Supreeth Venkatesh , Eric Jin , xianhui liu Subject: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Sync SNP Statistics change to IHV Date: Wed, 9 Oct 2019 17:42:10 +0800 Message-Id: <20191009094210.3380-1-xianhuix.liu@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,xianhuix.liu@intel.com X-Gm-Message-State: c2smjVTqKjmc2s4LRPe15JcSx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1570614136; bh=fTfwHeInQNSTZuKCOnhXnLKauiPbuBTaBx6i0JrKC7w=; h=Cc:Date:From:Reply-To:Subject:To; b=u04uGD6ZeoTZrP9RwlSJl1O81w2OS0fhDjjFJNv2sFXg9qxFTJK5FGKhyEX/I8NjTUm 0193z2LVbNlp8Y6R0XLPn+++Nmzx5UbSU9iars/6C0ImRNUBMt8+dowUgd66382wN9/FC L93LxECMwoNj72iswL3R5F4Kg+zdlT6//qA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2160 sync commit 269f8a35e44f2093625b3671f372f68e2983c49d on file EFI/Protocol/SimpleNetwork/BlackBoxTest /SimpleNetworkBBTestConformance.c to IHV Cc: Heinrich Schuchardt Cc: Supreeth Venkatesh Cc: Eric Jin Signed-off-by: xianhui liu --- .../BlackBoxTest/SimpleNetworkBBTestConformance.c | 123 ++++++++++++-----= ---- 1 file changed, 72 insertions(+), 51 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleNetwork/Black= BoxTest/SimpleNetworkBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/IH= V/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestConformance.c index 9d5bec18..9bd21a76 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleNetwork/BlackBoxTest= /SimpleNetworkBBTestConformance.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleNetwork/BlackBoxTest= /SimpleNetworkBBTestConformance.c @@ -964,8 +964,7 @@ BBTestStatisticsConformanceTest ( { EFI_STANDARD_TEST_LIBRARY_PROTOCOL *StandardLib; EFI_STATUS Status; - EFI_STATUS StatusBuf[3]; =20 - EFI_TEST_ASSERTION AssertionType[3]; + EFI_TEST_ASSERTION AssertionType; EFI_SIMPLE_NETWORK_PROTOCOL *SnpInterface; EFI_SIMPLE_NETWORK_STATE State1, State2; EFI_NETWORK_STATISTICS StatisticsTable; @@ -1012,31 +1011,68 @@ BBTestStatisticsConformanceTest ( StatisticsSize =3D sizeof (EFI_NETWORK_STATISTICS); // // Assertion Point 5.8.2.1 - // Call Statistics() function if network interface not start. + // Call Statistics() function while network interface is not started. // - StatusBuf[0] =3D SnpInterface->Statistics (SnpInterface, FALSE, &Statist= icsSize, &StatisticsTable); - if ((StatusBuf[0] =3D=3D EFI_NOT_STARTED) && (SnpInterface->Mode->State = =3D=3D EfiSimpleNetworkStopped)) { - AssertionType[0] =3D EFI_TEST_ASSERTION_PASSED; + Status =3D SnpInterface->Statistics (SnpInterface, FALSE, &StatisticsSiz= e, &StatisticsTable); + if (Status =3D=3D EFI_UNSUPPORTED) { + StandardLib->RecordMessage( + StandardLib, + EFI_VERBOSE_LEVEL_QUIET, + L"Statistics isn't supported, Status - %r\n", + Status + ); } else { - AssertionType[0] =3D EFI_TEST_ASSERTION_FAILED; + if ((Status =3D=3D EFI_NOT_STARTED) && (SnpInterface->Mode->State =3D= =3D EfiSimpleNetworkStopped)) { + AssertionType =3D EFI_TEST_ASSERTION_PASSED; + } else { + AssertionType =3D EFI_TEST_ASSERTION_FAILED; + } + StandardLib->RecordAssertion ( + StandardLib, + AssertionType, + gSimpleNetworkBBTestConformanceAssertionGuid014, + L"EFI_SIMPLE_NETWORK_PROTOCOL.Statistics - Invoke Stati= stics() while network interface not started.", + L"%a:%d:Status - %r", + __FILE__, + (UINTN)__LINE__, + Status + ); } =20 // // Assertion Point 5.8.2.2 - // Call Statistics() function if network interface not initialized. + // Call Statistics() function while network interface is not initialized. // Status =3D SnpInterface->Start (SnpInterface); if (EFI_ERROR(Status)) { return Status; } =20 - StatusBuf[1] =3D SnpInterface->Statistics (SnpInterface, FALSE, &Statist= icsSize, &StatisticsTable); - if (StatusBuf[1] =3D=3D EFI_DEVICE_ERROR) { - AssertionType[1] =3D EFI_TEST_ASSERTION_PASSED; + Status =3D SnpInterface->Statistics (SnpInterface, FALSE, &StatisticsSiz= e, &StatisticsTable); + if (Status =3D=3D EFI_UNSUPPORTED) { + StandardLib->RecordMessage( + StandardLib, + EFI_VERBOSE_LEVEL_QUIET, + L"Statistics isn't supported, Status - %r\n", + Status + ); } else { - AssertionType[1] =3D EFI_TEST_ASSERTION_FAILED; + if (Status =3D=3D EFI_DEVICE_ERROR) { + AssertionType =3D EFI_TEST_ASSERTION_PASSED; + } else { + AssertionType =3D EFI_TEST_ASSERTION_FAILED; + } + StandardLib->RecordAssertion ( + StandardLib, + AssertionType, + gSimpleNetworkBBTestConformanceAssertionGuid015, + L"EFI_SIMPLE_NETWORK_PROTOCOL.Statistics - Invoke Stati= stics() while network interface is not initialized.", + L"%a:%d:Status - %r", + __FILE__, + (UINTN)__LINE__, + Status + ); } -=20 =20 // // Assertion Point 5.8.2.3 @@ -1053,47 +1089,32 @@ BBTestStatisticsConformanceTest ( // StatisticsSize =3D 0; =20 - StatusBuf[2] =3D SnpInterface->Statistics (SnpInterface, FALSE, &Statist= icsSize, &StatisticsTable); - if (StatusBuf[2] =3D=3D EFI_BUFFER_TOO_SMALL || Status =3D=3D EFI_UNSUPP= ORTED) { - AssertionType[2] =3D EFI_TEST_ASSERTION_PASSED; + Status =3D SnpInterface->Statistics (SnpInterface, FALSE, &StatisticsSiz= e, &StatisticsTable); + if (Status =3D=3D EFI_UNSUPPORTED) { + StandardLib->RecordMessage( + StandardLib, + EFI_VERBOSE_LEVEL_QUIET, + L"Statistics isn't supported, Status - %r\n", + Status + ); } else { - AssertionType[2] =3D EFI_TEST_ASSERTION_FAILED; + if (Status =3D=3D EFI_BUFFER_TOO_SMALL) { + AssertionType =3D EFI_TEST_ASSERTION_PASSED; + } else { + AssertionType =3D EFI_TEST_ASSERTION_FAILED; + } + StandardLib->RecordAssertion ( + StandardLib, + AssertionType, + gSimpleNetworkBBTestConformanceAssertionGuid017, + L"EFI_SIMPLE_NETWORK_PROTOCOL.Statistics - Invoke Stati= stics() with small buffer.", + L"%a:%d:Status - %r", + __FILE__, + (UINTN)__LINE__, + Status + ); } =20 - =20 - StandardLib->RecordAssertion ( - StandardLib, - AssertionType[0], - gSimpleNetworkBBTestConformanceAssertionGuid014, - L"EFI_SIMPLE_NETWORK_PROTOCOL.Statistics - Invoke Statist= ics() when network interface not start.", - L"%a:%d:Status - %r", - __FILE__, - (UINTN)__LINE__, - StatusBuf[0] - ); - =20 - StandardLib->RecordAssertion ( - StandardLib, - AssertionType[1], - gSimpleNetworkBBTestConformanceAssertionGuid015, - L"EFI_SIMPLE_NETWORK_PROTOCOL.Statistics - Invoke Statist= ics() when network interface not initialized.", - L"%a:%d:Status - %r", - __FILE__, - (UINTN)__LINE__, - StatusBuf[1] - ); - - StandardLib->RecordAssertion ( - StandardLib, - AssertionType[2], - gSimpleNetworkBBTestConformanceAssertionGuid017, - L"EFI_SIMPLE_NETWORK_PROTOCOL.Statistics - Invoke Statist= ics() with small buffer.", - L"%a:%d:Status - %r", - __FILE__, - (UINTN)__LINE__, - StatusBuf[2] - ); - // // Restore SNP State // --=20 2.14.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48633): https://edk2.groups.io/g/devel/message/48633 Mute This Topic: https://groups.io/mt/34461451/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-