From nobody Mon Feb 9 23:57:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+48570+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+48570+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1570538338; cv=none; d=zoho.com; s=zohoarc; b=CjFVTig4CjXT489wQ/FnatCs/EQDnBl6JdEhaLy2YYNcz/I2jLNyaGCOgZ8UOP+5x+DKZnY4ksaQkhkoF5WbtgP5S7IpLkJrbkZjGZgb+wUlxaDHs+Xvew4LEinQNPXF9S6iUaOFrJv223J/tsaZSisTajDuaMfIdLWjbhRpXuE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570538338; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=8da5mS+fAWB9wYEnO543/ttKqwR3bJyhvJJeb3WS+wc=; b=EoO3+HLMxij7DlHe8xRjsl9e3ooFA8QEgakticlgvEbGsAw5NBmIKPRA0YXPVicbqi5fTLRjLoKurbkvi5I7R66ElbD6vzDe7OQp85CClokmFTBBs41USJLnCc7LXlqV1/av+e5n/09xYJGJD7UyIvWPmfVyihktvm3TuMVUEEw= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+48570+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1570538338621698.7462416670667; Tue, 8 Oct 2019 05:38:58 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id aaaaYY1788612xaaaaaaaaaa; Tue, 08 Oct 2019 05:38:58 -0700 X-Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by groups.io with SMTP; Tue, 08 Oct 2019 05:38:57 -0700 X-Received: by mail-wr1-f67.google.com with SMTP id r5so19157640wrm.12 for ; Tue, 08 Oct 2019 05:38:57 -0700 (PDT) X-Gm-Message-State: aaaaaaaaaaaaaaaaaaaaaaaax1787277AA= X-Google-Smtp-Source: APXvYqwN3nxf3u9Ea/aIt0DszKttxAhATXtyrKHKMb4Vn0OZ0RGW0fE861Zw6L5Z9mBYAlODvOiXSA== X-Received: by 2002:a5d:5145:: with SMTP id u5mr12654653wrt.125.1570538335598; Tue, 08 Oct 2019 05:38:55 -0700 (PDT) X-Received: from localhost.localdomain ([84.203.40.122]) by smtp.gmail.com with ESMTPSA id r6sm3203087wmh.38.2019.10.08.05.38.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Oct 2019 05:38:55 -0700 (PDT) From: "Pete Batard" To: devel@edk2.groups.io Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org Subject: [edk2-devel] [edk2-platforms][PATCH v2 2/5] Platform/RPi3/RpiFirmwareDxe: Improve serial number population Date: Tue, 8 Oct 2019 13:38:38 +0100 Message-Id: <20191008123841.12952-3-pete@akeo.ie> In-Reply-To: <20191008123841.12952-1-pete@akeo.ie> References: <20191008123841.12952-1-pete@akeo.ie> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pete@akeo.ie Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1570538338; bh=nXGqZdJ5WOftsFsBV3GG5GVw2JhenCMzpQM38Ve7qcA=; h=Cc:Date:From:Reply-To:Subject:To; b=b1bbt1B9kawPMpC3gGQPsPczCMF73UaXtPPbWx1c083LeegXdT/vDHNDT5I+M10SVan AwIVX1TGNUZ/d8a2hwN4T11vTTZUO/KG1Yl9C1rWwuNx7J+9Vng4hwkLuZDh3rV1Cabhm mxBX0X5oUZgn//84a1t4mwG0q1dBu/a+W0s= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Improve RpiFirmwareGetSerial() to derive a serial number from the MAC address, in case the platform returns 0 for the serial number. Also fix a typo where "%s" was used instead of "%a". Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 11 +++= ++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/Platform/RaspberryPi/RPi3/Drivers/RpiFirmwareDxe/RpiFirmwareDx= e.c b/Platform/RaspberryPi/RPi3/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c index 378c99bcba05..c2344252d2c0 100644 --- a/Platform/RaspberryPi/RPi3/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c +++ b/Platform/RaspberryPi/RPi3/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c @@ -219,7 +219,7 @@ RpiFirmwareSetPowerState ( =20 if (!EFI_ERROR (Status) && PowerState ^ (Cmd->TagBody.PowerState & RPI_MBOX_POWER_STATE_ENABLE)= ) { - DEBUG ((DEBUG_ERROR, "%a: failed to %sable power for device %d\n", + DEBUG ((DEBUG_ERROR, "%a: failed to %aable power for device %d\n", __FUNCTION__, PowerState ? "en" : "dis", DeviceId)); Status =3D EFI_DEVICE_ERROR; } @@ -393,7 +393,14 @@ RpiFirmwareGetSerial ( } =20 *Serial =3D Cmd->TagBody.Serial; - return EFI_SUCCESS; + // Some platforms return 0 for serial. For those, try to use the MAC add= ress. + if (*Serial =3D=3D 0) { + Status =3D RpiFirmwareGetMacAddress ((UINT8*) Serial); + // Convert to a more user-friendly value + *Serial =3D SwapBytes64 (*Serial << 16); + } + + return Status; } =20 #pragma pack() --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48570): https://edk2.groups.io/g/devel/message/48570 Mute This Topic: https://groups.io/mt/34441817/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-