From nobody Fri Apr 26 04:56:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+48489+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+48489+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1570220079; cv=none; d=zoho.com; s=zohoarc; b=UmWegKP2V4MtgfVw6EGFXYYaaiKEe4b5erV07u3G+++K6m2ADec6KI2uKz9Oki2BPSTPeUa+EStYMmk6pi4XPtIPKPCe784z4XppDNfzv0Da/XHMp909N+6DO6NlSV2TabJQdOmdgW4p1m9k+/QlyIvxaRj/SEFHRHK+47s5EAg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570220079; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To:ARC-Authentication-Results; bh=+F9dB87Si8HrK59YXo2UA61niMHfaXnfWstZbtjk5K0=; b=WD8tpstH+SOJFWGezkL6APztMlnVkU3/UBr9/VZOXzpRh9si/vxb7AJoGMF9vAJLgzVezZdWTIFmcdhoImYZzwmx3zGFcc8NUEIzSm6XerzrgXzSOnmDd2j56BwzT3/0E3H2pPqvSpgWB4aKdXF4XF3KabP6or/vVEhsiW2ynH4= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+48489+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1570220079667268.1837413755254; Fri, 4 Oct 2019 13:14:39 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id jB9VYY1788612xI6rYeC1cWO; Fri, 04 Oct 2019 13:14:38 -0700 X-Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Fri, 04 Oct 2019 13:14:37 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2019 13:14:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,257,1566889200"; d="scan'208";a="204420903" X-Received: from nldesimo-desk1.amr.corp.intel.com ([10.7.159.63]) by orsmga002.jf.intel.com with ESMTP; 04 Oct 2019 13:14:37 -0700 From: "Nate DeSimone" To: devel@edk2.groups.io Cc: Chasel Chiu , Michael Kubacki , Sai Chaganty Subject: [edk2-devel] [edk2-platforms] [PATCH V2] KabylakeSiliconPkg: Logic Error in EISS bit ASSERT Date: Fri, 4 Oct 2019 13:14:17 -0700 Message-Id: <20191004201417.5020-1-nathaniel.l.desimone@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com X-Gm-Message-State: jlOzkM6ZHzIRAsnqOhRdY9Mwx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1570220078; bh=PSa8TGNAgpwd2XjNusgPi79omWpjmXGxw3nxy0HPu0I=; h=Cc:Date:From:Reply-To:Subject:To; b=KNGoM/lYIoir0CpPYI9023Jvhy9P7ZG4kLC3fIOO9w7hcpZWGh0X9901skDIJgzRLhT BveZ55pOLEAmkshxqk+7XWID6JZfXEbK7nHMgjhha4lX2IeTOf0y+h0DhmBtw/xwHZNns fRYjq9oEpYGxl9CV5PW8QwcGM5LAG71pQxo= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Current ASSERT logic checks that the EISS bit is still set after we clear it. This is incorrect, it should be checking that that the EISS bit is clear after we clear it. Cc: Chasel Chiu Cc: Michael Kubacki Cc: Sai Chaganty Signed-off-by: Nate DeSimone Reviewed-by: Chasel Chiu Reviewed-by: Michael Kubacki Reviewed-by: Sai Chaganty --- .../Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiL= ib.c b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c index aadc367a9f..c34c378de2 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c @@ -184,7 +184,7 @@ DisableBiosWriteProtect ( B_PCH_SPI_BC_WPD ); =20 - ASSERT ((PciSegmentRead8 (SpiBaseAddress + R_PCH_SPI_BC) & B_PCH_SPI_BC_= EISS) !=3D 0); + ASSERT ((PciSegmentRead8 (SpiBaseAddress + R_PCH_SPI_BC) & B_PCH_SPI_BC_= EISS) =3D=3D 0); =20 return EFI_SUCCESS; } --=20 2.23.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48489): https://edk2.groups.io/g/devel/message/48489 Mute This Topic: https://groups.io/mt/34398391/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-