From nobody Sat Apr 27 02:44:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+48360+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+48360+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1570001801; cv=none; d=zoho.com; s=zohoarc; b=gNFgvYAe/MSa1mM9xwFCK6MIPi+hJWDTjdIDxWLo13fU+w+qAYOINXNYkMa3k5YGFtgqzH+VTm8o/G9b4ZsymMphMNVoPN0vI5Uj/qWkCnsAuuONpeU3h4IlnzPhjPvAN4C/sG6dO69iViAQIj7jxOxnWDD2HwaGbF6s2Q0ugTg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570001801; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To:ARC-Authentication-Results; bh=0FyEh7R3DB42zzAwpHkjxlqa6bXS03rbHFOGoTJOZAY=; b=fh77aaN4zfXswaErfDBUQgtseuPzKaXYieTBOqwEJSG/Llcz+uNqhEgsYH7zuQPpLN9AMZaqu6ivd5wvfVnXpM2P1z2OEx46Wg6OE5k0PyTqn2Lidl+naGaZ0r4QETKPacU47KoqAXj82Nd5QAD6QMTV6F80CVYHAbBhqLD7c/8= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+48360+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1570001801479232.9443492025157; Wed, 2 Oct 2019 00:36:41 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id aaaaYY1788612xaaaaaaaaaa; Wed, 02 Oct 2019 00:36:40 -0700 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Wed, 02 Oct 2019 00:36:39 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2019 00:36:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,573,1559545200"; d="scan'208";a="366626245" X-Received: from nldesimo-desk1.amr.corp.intel.com ([10.7.159.63]) by orsmga005.jf.intel.com with ESMTP; 02 Oct 2019 00:36:38 -0700 From: "Nate DeSimone" To: devel@edk2.groups.io Cc: Chasel Chiu , Michael Kubacki , Sai Chaganty Subject: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeSiliconPkg: Logic Error in EISS bit ASSERT Date: Wed, 2 Oct 2019 00:36:21 -0700 Message-Id: <20191002073621.3355-1-nathaniel.l.desimone@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com X-Gm-Message-State: aaaaaaaaaaaaaaaaaaaaaaaax1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1570001800; bh=GvNcntGRcYcr/AuTBFLBav1UunLrqkw4Vfg9YOfUZpc=; h=Cc:Date:From:Reply-To:Subject:To; b=A4iejopAHvDdCqbKMc98ipz0uuWBi9HH2v085Pig0uPitxc+t0+zXg9q73q6pu7bspM 0wr1GxuoDz0uuQHvRUqnNhyHvmcWObwCxpuOZqs99hn+PbvcMENScFZ9ldhFwGqCW4orS qa8jYqVl7HGjVyEXEpKo0LTYwh3b03MwfOY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Current ASSERT logic checks that the EISS bit is still set after we clear it. This is incorrect, it should be checking that that the EISS bit is clear after we clear it. Cc: Chasel Chiu Cc: Michael Kubacki Cc: Sai Chaganty Signed-off-by: Nate DeSimone Reviewed-by: Sai Chaganty =20 --- .../Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiL= ib.c b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c index aadc367a9f..5fb667dc4a 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c @@ -184,7 +184,7 @@ DisableBiosWriteProtect ( B_PCH_SPI_BC_WPD ); =20 - ASSERT ((PciSegmentRead8 (SpiBaseAddress + R_PCH_SPI_BC) & B_PCH_SPI_BC_= EISS) !=3D 0); + ASSERT ((MmioRead8 (SpiBaseAddress + R_PCH_SPI_BC) & B_PCH_SPI_BC_EISS) = =3D=3D 0); =20 return EFI_SUCCESS; } --=20 2.23.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48360): https://edk2.groups.io/g/devel/message/48360 Mute This Topic: https://groups.io/mt/34367405/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-