From nobody Mon Feb 9 12:10:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+47947+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47947+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1569331198; cv=none; d=zoho.com; s=zohoarc; b=MhmhSBLnv+mVp9CHk5wt4VxRNoz7JlRl6gBMtLIJgQraIZxuSkEMbW2QydDEeyLYfPLdJKrqk4HMU+rgXmZEvPym9RbD76ACBd8z0qnzuODVHG/bqZk4t3pg6I82v7kDwp3eLAWVUhgAPtbjC1QkYPr74Z5gpKov0gd5gKltekY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569331198; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=WoYQoQOssVopr22eHcO+myzs+AMbOmSJtOdQBnmnEAo=; b=MdZAA1NWZPWhq8hjQC3wYzRoqwQMplMB3R4ed8xFTrecj8bAp2zeszNYpuzPCq+zGL4dYDeky12frdaH2teHdfLDx8R398WJQJgcE/8XoA4LYlXrZXudY09p883I5CZddqI8QvonM6Dq6pMoBLUtRzyHt+QKN0jvOuIdFGz8Cmk= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47947+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1569331198672468.0882053914431; Tue, 24 Sep 2019 06:19:58 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id bVQuYY1788612xntwe50xg1I; Tue, 24 Sep 2019 06:19:58 -0700 X-Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Tue, 24 Sep 2019 06:19:57 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2019 06:19:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,544,1559545200"; d="scan'208";a="189365372" X-Received: from dandanbi-mobl2.ccr.corp.intel.com ([10.249.168.26]) by fmsmga007.fm.intel.com with ESMTP; 24 Sep 2019 06:19:55 -0700 From: "Dandan Bi" To: devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu , Liming Gao , Laszlo Ersek , Philippe Mathieu-Daude Subject: [edk2-devel] [patch v3 4/5] MdeModulePkg/PlatformDriOverride: Unload image on EFI_SECURITY_VIOLATION Date: Tue, 24 Sep 2019 21:16:43 +0800 Message-Id: <20190924131644.10412-5-dandan.bi@intel.com> In-Reply-To: <20190924131644.10412-1-dandan.bi@intel.com> References: <20190924131644.10412-1-dandan.bi@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dandan.bi@intel.com X-Gm-Message-State: CAhu27p7aPO6LOxPbYUfTSEUx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1569331198; bh=EN1SgVK6Och+NqB6lrWUdXhSTXfTim46cmr5Q00Sj5w=; h=Cc:Date:From:Reply-To:Subject:To; b=v6SQrUixvbzx4TrJSNRloB7jqLf42sIrqzUSbS4kBfttnp0JVqFf9hx75yzfGxuUJ1r RNPI8Y/biVUbNiBnSb6jcrJEX9o6tJZtSJs0a/eVew3NjwDP/JzSIlkCBwSzoGKva8xrm EdzQ1vLaLkRjBDi/8O5xmGyFQKptjFZvAhQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval, the Image was loaded and an ImageHandle was created with a valid EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now. This follows UEFI Spec. But if the caller of LoadImage() doesn't have the option to defer the execution of an image, we can not treat EFI_SECURITY_VIOLATION like any other LoadImage() error, we should unload image for the EFI_SECURITY_VIOLATION to avoid resource leak. This patch is to do error handling for EFI_SECURITY_VIOLATION explicitly for the caller in PlatformDriOverrideDxe which don't have the policy to defer the execution of the image. Cc: Jian J Wang Cc: Hao A Wu Cc: Liming Gao Cc: Laszlo Ersek Cc: Philippe Mathieu-Daude REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1992 Signed-off-by: Dandan Bi Reviewed-by: Hao A Wu Reviewed-by: Philippe Mathieu-Daude --- .../PlatformDriOverrideDxe/PlatDriOverrideLib.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/PlatformDriOverrideDxe/PlatDriOverrideL= ib.c b/MdeModulePkg/Universal/PlatformDriOverrideDxe/PlatDriOverrideLib.c index 2d3736b468..f91f038b7a 100644 --- a/MdeModulePkg/Universal/PlatformDriOverrideDxe/PlatDriOverrideLib.c +++ b/MdeModulePkg/Universal/PlatformDriOverrideDxe/PlatDriOverrideLib.c @@ -1,9 +1,9 @@ /** @file Implementation of the shared functions to do the platform driver vverrid= e mapping. =20 - Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
+ Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ =20 #include "InternalPlatDriOverrideDxe.h" @@ -1484,10 +1484,19 @@ GetDriverFromMapping ( ); ASSERT (DriverBinding !=3D NULL); DriverImageInfo->ImageHandle =3D ImageHandle; } } else { + // + // With EFI_SECURITY_VIOLATION retval, the Image was loaded = and an ImageHandle was created + // with a valid EFI_LOADED_IMAGE_PROTOCOL, but the image can= not be started right now. + // If the caller doesn't have the option to defer the execut= ion of an image, we should + // unload image for the EFI_SECURITY_VIOLATION to avoid reso= urce leak. + // + if (Status =3D=3D EFI_SECURITY_VIOLATION) { + gBS->UnloadImage (ImageHandle); + } DriverImageInfo->UnLoadable =3D TRUE; DriverImageInfo->ImageHandle =3D NULL; } } } --=20 2.18.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47947): https://edk2.groups.io/g/devel/message/47947 Mute This Topic: https://groups.io/mt/34275945/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-