From nobody Mon Feb 9 10:48:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+47393+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47393+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568749801; cv=none; d=zoho.com; s=zohoarc; b=PAp5zFTHeXrXNeAjNyGQNqSHuFYZdEU9lIkmQLgFTNdQlA6M54lxWvmrvDC6oL/DKXVBijnzieY2vkC+UgQ+beMbssxUYsRqwLp0wPXCjqRm2e9K4jTmoOngpiLiEqQes5WYNw1wHT5XU9p3OJjIiqv4ba27I3qasMHnov0czsE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568749801; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=Jo3PJZjvBjmKGl+fHDC0GEkDUcp+WGCro24lU3W2/cc=; b=JG+mRybR7ldNRUpR+wrFkpFWZOq0Tpm4BvOJGX5kw0j7dP/Ypi1dok5KL/+eCNcGEugWn4vWgt0pMnhf8A6vCPn797yc10yUz+Sebo6nGBse6K6S+X8uOY8zZH2FAikpAW5SWFykr+utYVp1FdYEzIA6LYSp0Hryg2tL4Fv3lGM= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47393+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1568749801860778.5874903384039; Tue, 17 Sep 2019 12:50:01 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id YK1HYY1788612xIIQVcaOyyl; Tue, 17 Sep 2019 12:50:00 -0700 X-Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 17 Sep 2019 12:49:58 -0700 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CC72E30821AE; Tue, 17 Sep 2019 19:49:57 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-37.rdu2.redhat.com [10.10.120.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id 90BBC600C4; Tue, 17 Sep 2019 19:49:56 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Andrew Fish , Jordan Justen , Ray Ni Subject: [edk2-devel] [PATCH 06/35] EmulatorPkg: stop abusing EFI_HANDLE for keystroke notify registration Date: Tue, 17 Sep 2019 21:49:06 +0200 Message-Id: <20190917194935.24322-7-lersek@redhat.com> In-Reply-To: <20190917194935.24322-1-lersek@redhat.com> References: <20190917194935.24322-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 17 Sep 2019 19:49:57 +0000 (UTC) Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com X-Gm-Message-State: 8Nb4SIT8aHepwAYXi0qqSz2Nx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1568749800; bh=CjuAkXpybVuXXLF2Tgjxt5rzJ5bmaEFB0jYMSWy0uVc=; h=Cc:Date:From:Reply-To:Subject:To; b=do+HVtm75XdD9DAS6ssRw8DtWrKL5L4xjWlldN0ah2ua5tG+a+Qq73Y14jmPQ5qLqSm xAVrtCHZuDqTpUS753kcx5NYZZOT791Is3SftVFLKnP/0kdmL5tTnQ6X3a38LcFLk5V9L O2mYGOeFU/wB6E34/oqmOyMcmdKriK1G0nU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" EFI_REGISTER_KEYSTROKE_NOTIFY and EFI_UNREGISTER_KEYSTROKE_NOTIFY require the notification handle to have type (VOID*). The notification handle has nothing to do with the EFI_HANDLE type. This change is a semantic fix; functionally, it's a no-op. Cc: Andrew Fish Cc: Jordan Justen Cc: Ray Ni Signed-off-by: Laszlo Ersek Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Ray Ni --- Notes: build-tested only EmulatorPkg/EmuGopDxe/GopInput.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/EmulatorPkg/EmuGopDxe/GopInput.c b/EmulatorPkg/EmuGopDxe/GopIn= put.c index fdd0b4911555..2a23564a2173 100644 --- a/EmulatorPkg/EmuGopDxe/GopInput.c +++ b/EmulatorPkg/EmuGopDxe/GopInput.c @@ -517,7 +517,7 @@ EmuGopSimpleTextInExRegisterKeyNotify ( IN EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL *This, IN EFI_KEY_DATA *KeyData, IN EFI_KEY_NOTIFY_FUNCTION KeyNotificationFunction, - OUT EFI_HANDLE *NotifyHandle + OUT VOID **NotifyHandle ) { EFI_STATUS Status; @@ -600,7 +600,7 @@ EFI_STATUS EFIAPI EmuGopSimpleTextInExUnregisterKeyNotify ( IN EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL *This, - IN EFI_HANDLE NotificationHandle + IN VOID *NotificationHandle ) /*++ =20 --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47393): https://edk2.groups.io/g/devel/message/47393 Mute This Topic: https://groups.io/mt/34180205/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-