From nobody Mon Feb 9 10:29:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+47390+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47390+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568749794; cv=none; d=zoho.com; s=zohoarc; b=GX2PC5+bJVYWSPkOT3m41fTe/+H2GnhbpdfmVaAnNHj8XG3V3uHOjiAu3KqcF/1zezVme5YdUk96ZJyf4luqufPKpHFdgmsceRBUlSPFEVDk4JjmQP0YYyPHTXXGBMbZ11aRzKatOhAmDL7S0Lz/iR/k+g+kpebYh19FAz5Hd+Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568749794; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=CSutxp/4LQ5MqbNXSurb7Nlbi55P9vYjysl6Mv2N6wc=; b=OqkqpbZACv93fT/Pk5YSZ4mMynz1zMC+fftbfJShY4/tH3S0RiXXvc4IjWYzlCS6dOhk2sikgL0Avwzjc7b9NmG32OL+Pbb5vtr5wIgP8VQ66RR9nE6mnrrQkcwCot/KYCs6hJBMnEvWKj2q5OaBg2HBPmmEMDWMqZqoPiXeceg= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47390+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1568749794384445.5074465500144; Tue, 17 Sep 2019 12:49:54 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 3UIKYY1788612xuZRyE5qMbD; Tue, 17 Sep 2019 12:49:53 -0700 X-Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 17 Sep 2019 12:49:53 -0700 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 242C4300CB26; Tue, 17 Sep 2019 19:49:53 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-37.rdu2.redhat.com [10.10.120.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1B0E3600C4; Tue, 17 Sep 2019 19:49:51 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Ard Biesheuvel , Leif Lindholm Subject: [edk2-devel] [PATCH 03/35] EmbeddedPkg/AndroidFastbootTransportTcpDxe: fix DestroyChild() call Date: Tue, 17 Sep 2019 21:49:03 +0200 Message-Id: <20190917194935.24322-4-lersek@redhat.com> In-Reply-To: <20190917194935.24322-1-lersek@redhat.com> References: <20190917194935.24322-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 17 Sep 2019 19:49:53 +0000 (UTC) Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com X-Gm-Message-State: pOVyyHcOslXcyo3ipgs9UZbux1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1568749793; bh=u3TJNcQvqPtryJedrh5LVoKUuGAzUTxViNIk7pPR5x8=; h=Cc:Date:From:Reply-To:Subject:To; b=jQPZcjpo27Enu76rdzBPcU9XPMGObA+Ta7G8MGUVtEmuL5SgdCRldPNq9O2GreOzEct Jb0unctQd+tjR9AJAi7ZnOxKzkecl1W5/z6w4NVopkv6Ul2QtbLUBFgHRiUZ2NhQ9Sd9O JUOzFdMrjXVSQUeBmE0oYfivFftSd5jCeq8= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" - The 2nd parameter of EFI_SERVICE_BINDING_CREATE_CHILD is: IN OUT EFI_HANDLE *ChildHandle - The 2nd parameter of EFI_SERVICE_BINDING_DESTROY_CHILD is: IN EFI_HANDLE ChildHandle Fix the DestroyChild() call in TcpFastbootTransportStop(). This is an actual bugfix; I don't know why the current code doesn't crash. Perhaps the function is never reached in practice? (It could be tied to an error path.) Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Laszlo Ersek Acked-by: Ard Biesheuvel Reviewed-by: Philippe Mathieu-Daude --- Notes: build-tested only EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c = | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTra= nsportTcp.c b/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTr= ansportTcp.c index 29f23a82c75f..34f9ba74e4db 100644 --- a/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportT= cp.c +++ b/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportT= cp.c @@ -503,7 +503,7 @@ TcpFastbootTransportStop ( Status =3D mTcpListener->Configure (mTcpListener, NULL); ASSERT_EFI_ERROR (Status); =20 - Status =3D mTcpServiceBinding->DestroyChild (mTcpServiceBinding, &mTcpHa= ndle); + Status =3D mTcpServiceBinding->DestroyChild (mTcpServiceBinding, mTcpHan= dle); =20 // Free any data the user didn't pick up Entry =3D (FASTBOOT_TCP_PACKET_LIST *) GetFirstNode (&mPacketListHead); --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47390): https://edk2.groups.io/g/devel/message/47390 Mute This Topic: https://groups.io/mt/34180202/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-