From nobody Mon Feb 9 14:33:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+47418+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47418+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568749842; cv=none; d=zoho.com; s=zohoarc; b=L9iRUQQlN7O5bZDKhWxVlucaQeMMhIUWS5lkPE38NDXCOOLK3VRCyIPAMly/8J/xkqr+JrioifdckdkAbGlGJPsPfMj8Mz+YK0z694yEmwQDo6b7J73Ee00Wpd+44/O9i+Zseqh9mmPZazmKf/rkTHAn43wbasmcu7TMdFwrSpw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568749842; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=1NFudYo2XxlxApwMEST5PMDyouxt6zauhh9pqy4fToA=; b=hHtzZrErQLiaq9JCVqZC14R6W2eXs5VidZ2AEUJXSfQ5CIDKSdc9vlUfXHplzmPjoTD/+7o/EHEVhCwjji7P/xHvxIhnXC6DinaoTL/cQU2o6eqfjYrbWC1W59Np5OUuauFINWFxucwWlaaAk9+Y75toYTIABRz/eXA+mIbalBo= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47418+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1568749842692106.86071705351912; Tue, 17 Sep 2019 12:50:42 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 5lyuYY1788612xrVvusf6Glb; Tue, 17 Sep 2019 12:50:41 -0700 X-Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 17 Sep 2019 12:50:41 -0700 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CD2A730860BD; Tue, 17 Sep 2019 19:50:40 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-37.rdu2.redhat.com [10.10.120.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9081B600C4; Tue, 17 Sep 2019 19:50:39 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Jaben Carsey , Ray Ni , Zhichao Gao Subject: [edk2-devel] [PATCH 31/35] ShellPkg/UefiShellDebug1CommandsLib: fix ShellCloseFile() call Date: Tue, 17 Sep 2019 21:49:31 +0200 Message-Id: <20190917194935.24322-32-lersek@redhat.com> In-Reply-To: <20190917194935.24322-1-lersek@redhat.com> References: <20190917194935.24322-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Tue, 17 Sep 2019 19:50:40 +0000 (UTC) Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com X-Gm-Message-State: EONwtIDlLD2gwpAW66YkksIZx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1568749841; bh=O2GZGSxLnd8GgmlqSdgv9o/YoS+YWuS9M2RD/X5t1JA=; h=Cc:Date:From:Reply-To:Subject:To; b=WsXMQS4W/o+KMzL5Ld+vkbsADqZem0X7LgXKHFQxc8ahAT9WK6f82WNfURf0gBA8xxw MtqvaZy3dotyIkw436j9Sr7UFndGr1UsfpRdGCy2MvKK6vQ0OLPcl/O8ijrFeSvffv2dh pp1kvU1MOcBGzbfDYNLgVwFrve2BFcDRzwU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" In the FileBufferSave() function, we invoke ShellCloseFile() if "Directory Can Not Be Saved". The ShellCloseFile() function takes a (SHELL_FILE_HANDLE*) parameter called "FileHandle", and correctly passes the de-referenced (*FileHandle) to EFI_SHELL_CLOSE_FILE, which takes a SHELL_FILE_HANDLE. However, FileBufferSave() passes SHELL_FILE_HANDLE to ShellCloseFile(), not the expected (SHELL_FILE_HANDLE*). Correct it. This fixes an actual bug that has remained hidden for two reasons: - pointer-to-VOID converts from/to any pointer-to-object type silently, - the bug is on an error path which has likely never fired in practice. Cc: Jaben Carsey Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Laszlo Ersek Reviewed-by: Jaben Carsey Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Zhichao Gao --- Notes: tested: edit (saving a file) ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c = b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c index 464f9de38e52..fd324cc4a861 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c @@ -1462,7 +1462,7 @@ FileBufferSave ( =20 if (Info !=3D NULL && Info->Attribute & EFI_FILE_DIRECTORY) { StatusBarSetStatusString (L"Directory Can Not Be Saved"); - ShellCloseFile(FileHandle); + ShellCloseFile (&FileHandle); FreePool(Info); return EFI_LOAD_ERROR; } --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47418): https://edk2.groups.io/g/devel/message/47418 Mute This Topic: https://groups.io/mt/34180234/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-