From nobody Mon Feb 9 12:26:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+47417+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47417+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568749841; cv=none; d=zoho.com; s=zohoarc; b=WxWWGyTzWz1LX5SQ9hp8gOF+YdFrPPdpMDDcfMAadCpu1ipN9NdtiGXxOVBKl9sCbewBQ2p6afxWegVmhyvqgO8c8HZLN7cdYuJ53zj4Gi+eK9ZCqztu1xO6Lu4iEZ2o6PZboMEXH1SW6R5s+dAEza6w49oFIXCNKbvccRRm1DI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568749841; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=jx3kUOe2vIam1oRIKF74NzqPn7kKohswW9BB3NYr0lo=; b=nqcir4IyiC15Nj3c7sqRiNjarINiTr2vX73HhMPpAHeM4H8/v0avIei1l4psHYBwlFvJhisNtujQsv6pSn/3IBzvQ4PmLI97wb9jfljMvNJ3wzohv/gTMXySkjkl/AnAQ786YQcNPbn2T8D9SD5atvamgb8qg3msR2PgI54nfp0= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47417+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1568749841000725.172326444841; Tue, 17 Sep 2019 12:50:41 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id huVWYY1788612xQqUTZUD3HX; Tue, 17 Sep 2019 12:50:40 -0700 X-Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 17 Sep 2019 12:50:39 -0700 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 327E483F3C; Tue, 17 Sep 2019 19:50:39 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-37.rdu2.redhat.com [10.10.120.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id E660A600C4; Tue, 17 Sep 2019 19:50:37 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Jaben Carsey , Ray Ni , Zhichao Gao Subject: [edk2-devel] [PATCH 30/35] ShellPkg: stop taking EFI_HANDLE in place of SHELL_FILE_HANDLE Date: Tue, 17 Sep 2019 21:49:30 +0200 Message-Id: <20190917194935.24322-31-lersek@redhat.com> In-Reply-To: <20190917194935.24322-1-lersek@redhat.com> References: <20190917194935.24322-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 17 Sep 2019 19:50:39 +0000 (UTC) Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com X-Gm-Message-State: zLTNhcPqKVvL65LPEBkJm7GDx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1568749840; bh=7hmQuzg2uLUsxWXmDh40P5Ls4UcjSPrbe3RdgyXVtzk=; h=Cc:Date:From:Reply-To:Subject:To; b=cccr8zhl97LMxl1rIR9xlLuFj7rMBEG14KsCgH/Xb1qHbUkVXBZh3RssJmP2ligYqxw /Gm2HrbHoR8xa43oIvPGwKm2vuTV6wHoJwB76UGMsdB7Ihl2dE8611KmoM5kQfXX2LUcs 9igpRPE1Wb6z4iSAL8zBtcxcmnCkvh3802M= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" The TouchFileByHandle() and IsDirectoryEmpty() functions are passed SHELL_FILE_HANDLE parameters, and they use those parameters correctly. However, their parameter lists say EFI_HANDLE. Spell out the right type in the parameter lists. In practice, this change is a no-op (because, quite regrettably, both EFI_HANDLE and SHELL_FILE_HANDLE are specified to be typedefs of (VOID*)). Cc: Jaben Carsey Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Laszlo Ersek Reviewed-by: Philippe Mathieu-Daude --- Notes: tested: rm, touch ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c | 2 +- ShellPkg/Library/UefiShellLevel3CommandsLib/Touch.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c b/ShellPkg/Li= brary/UefiShellLevel2CommandsLib/Rm.c index 3a1196f1529e..59f7eec376f2 100644 --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c @@ -24,7 +24,7 @@ STATIC CONST SHELL_PARAM_ITEM ParamList[] =3D { **/ BOOLEAN IsDirectoryEmpty ( - IN EFI_HANDLE FileHandle + IN SHELL_FILE_HANDLE FileHandle ) { EFI_STATUS Status; diff --git a/ShellPkg/Library/UefiShellLevel3CommandsLib/Touch.c b/ShellPkg= /Library/UefiShellLevel3CommandsLib/Touch.c index 0f00344c815e..a215f5774c69 100644 --- a/ShellPkg/Library/UefiShellLevel3CommandsLib/Touch.c +++ b/ShellPkg/Library/UefiShellLevel3CommandsLib/Touch.c @@ -21,7 +21,7 @@ **/ EFI_STATUS TouchFileByHandle ( - IN EFI_HANDLE Handle + IN SHELL_FILE_HANDLE Handle ) { EFI_STATUS Status; --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47417): https://edk2.groups.io/g/devel/message/47417 Mute This Topic: https://groups.io/mt/34180233/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-