From nobody Mon Feb 9 14:33:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+47415+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47415+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568749836; cv=none; d=zoho.com; s=zohoarc; b=VqbaSv5PLrOLSIN/HvSTu6h2bXPO2HJs30zKqCWdsJhavrQ7wQsBNYyJ8hhAQXPLtEtxpF3RIrqNx+LvMGvVS3Eu31eiU+OFKLFPbfw4WBrl6fCxD3LONACB4XbBBb904OPLbqWVsZHTbBAOmWZq3FME9hU96f6r7vQPbrp09Rg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568749836; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=fYVFl+55WCkgf7nPLpweRgg9BuZ2lT+SkJa+H85h0H0=; b=jrFd9rZH8671cNv9//A4cD0kKu4KNmHFDOMG733XKWocWl7jZ2tGRNtL+4JASvXZgfc6bJfgXCZfnQak+gppvOAfp8xf1fIS++v0oUQukg9GQPY0CqLTfylBei5Z0kStHuLRCcHJ5cHwnpQfRGMDnF99VO0QzYgSWsnGtutWoJM= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47415+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1568749836917947.5559574385212; Tue, 17 Sep 2019 12:50:36 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id HvDdYY1788612xm73bgpWD09; Tue, 17 Sep 2019 12:50:36 -0700 X-Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 17 Sep 2019 12:50:36 -0700 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ABEF58980E0; Tue, 17 Sep 2019 19:50:35 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-37.rdu2.redhat.com [10.10.120.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id 70A336012C; Tue, 17 Sep 2019 19:50:34 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Jaben Carsey , Ray Ni , Zhichao Gao Subject: [edk2-devel] [PATCH 28/35] ShellPkg/UefiShellDriver1CommandsLib: fix parameter list typo Date: Tue, 17 Sep 2019 21:49:28 +0200 Message-Id: <20190917194935.24322-29-lersek@redhat.com> In-Reply-To: <20190917194935.24322-1-lersek@redhat.com> References: <20190917194935.24322-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.67]); Tue, 17 Sep 2019 19:50:35 +0000 (UTC) Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com X-Gm-Message-State: CIldXLVy6KXeIpMHER11lLxkx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1568749836; bh=EGY0qrAcdmmRBg1RO0Es1M1TlMT/1Pl/keekS9mBqZQ=; h=Cc:Date:From:Reply-To:Subject:To; b=X/MuwD9zODZxdmEaaxmCCLb7rK+THineojCwQSNjxTrTKbxPrzKBnofh3hwTf1eJBNJ 9Aqo1h4rZb9uoeTtH18WGhN3IrImQ1Ki1eHZbQ8i6AJJT/7RnPW+RkunlA18uSVTEEnG7 pJB8upvzHgkZBohrfWco/hSnAPrMbPos0Qk= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" The ShellCommandRunConnect() function passes EFI_HANDLE -- (VOID*) -- objects to ConvertAndConnectControllers(), and ConvertAndConnectControllers() passes those to gBS->OpenProtocol(). Accordingly, ConvertAndConnectControllers() should specify EFI_HANDLE parameter types, not (EFI_HANDLE*) -- (VOID**) -- types. This typo is masked because (VOID*) converts to and from any pointer-to-object type silently. Note that functionally speaking there is no problem, so this patch does not change beavior, only cleans up the code. Cc: Jaben Carsey Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Laszlo Ersek Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Zhichao Gao --- Notes: tested with "connect -r" ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c b/Shell= Pkg/Library/UefiShellDriver1CommandsLib/Connect.c index 359394dfd291..3f4e132674ea 100644 --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c @@ -346,8 +346,8 @@ ShellConnectFromDevPaths ( **/ EFI_STATUS ConvertAndConnectControllers ( - IN EFI_HANDLE *Handle1 OPTIONAL, - IN EFI_HANDLE *Handle2 OPTIONAL, + IN EFI_HANDLE Handle1 OPTIONAL, + IN EFI_HANDLE Handle2 OPTIONAL, IN CONST BOOLEAN Recursive, IN CONST BOOLEAN Output ) --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47415): https://edk2.groups.io/g/devel/message/47415 Mute This Topic: https://groups.io/mt/34180231/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-