From nobody Tue Feb 10 04:13:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+47414+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47414+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568749835; cv=none; d=zoho.com; s=zohoarc; b=EhDh+zsS9uoIZVnFHIoLA9acZ8KxHcj3HMa11eR9FAccNUaYElnkdXHVY4ZpNOOgFtkeT8NOuaHbo3PYabMaJNjJLKPLUJsIgSdg297vwWbkPQSkkAvib0QUqFLFhTN7fewJuKFfwq6JYzuehifji07FUU7gVY3WJENEmPKPuM4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568749835; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=+lUOoRJnMkUHas+/S0O2Vg3LhcM718HP2cgnCxg8m2Q=; b=AIVXTn3PszmsGoOjgNRIOoT3vPCqrO4Kwl7eBdpT0p58mf8T8LagPCHHJijfWEWQikH81s6Yy5TrpNSiOsBkD5LFvL4SzYft1ZstefahbRwaJcTrpQ1G+Sx2/pshBeI/v7hyuUvQeiRBdJ6P+jTqlMJaNn99O9C1kEzMR7zzcKY= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47414+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 15687498359146.502570952970132; Tue, 17 Sep 2019 12:50:35 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 0uYsYY1788612xx5G6yVK1Hg; Tue, 17 Sep 2019 12:50:34 -0700 X-Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 17 Sep 2019 12:50:34 -0700 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1275337E79; Tue, 17 Sep 2019 19:50:34 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-37.rdu2.redhat.com [10.10.120.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id CAA8A600C8; Tue, 17 Sep 2019 19:50:32 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Chao Zhang , Jian Wang , Jiewen Yao Subject: [edk2-devel] [PATCH 27/35] SecurityPkg: stop abusing EFI_EVENT for protocol notify registration Date: Tue, 17 Sep 2019 21:49:27 +0200 Message-Id: <20190917194935.24322-28-lersek@redhat.com> In-Reply-To: <20190917194935.24322-1-lersek@redhat.com> References: <20190917194935.24322-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 17 Sep 2019 19:50:34 +0000 (UTC) Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com X-Gm-Message-State: Txx9Upc0FVEb0InF6hVTSNR4x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1568749834; bh=KaurmW7ZdSuM1MaFQ6hjorSdVRNgZL2w/q0DxfK22zA=; h=Cc:Date:From:Reply-To:Subject:To; b=MG6+ZQKvHmZsLD3cZbE93QtGhyru6yuP25KTdXKGzn+AHVtTG8fh6VSdzIX5tBglp8H wLIwSlWUARLkKZ5hXho4Rs3plHzen38NnR5xEmSqsWpEPQt1ceBKOiEma/nP1diGMPfBj zzhk2PKrUQ7EJu8QXq+FN9iEkv3OsHZQeVM= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" EfiCreateProtocolNotifyEvent() takes a (VOID**) for "Registration", similarly to gBS->RegisterProtocolNotify(). We should pass the address of an actual pointer-to-VOID, and not the address of an EFI_EVENT. EFI_EVENT just happens to be specified as (VOID*), and has nothing to do with the registration. This change is a no-op in practice; it's a semantic improvement. Cc: Chao Zhang Cc: Jian Wang Cc: Jiewen Yao Signed-off-by: Laszlo Ersek Reviewed-by : Chao Zhang Reviewed-by: Philippe Mathieu-Daude --- Notes: build-tested only SecurityPkg/HddPassword/HddPasswordDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/HddPassword/HddPasswordDxe.c b/SecurityPkg/HddPass= word/HddPasswordDxe.c index b0d795b6597f..051e64091d7f 100644 --- a/SecurityPkg/HddPassword/HddPasswordDxe.c +++ b/SecurityPkg/HddPassword/HddPasswordDxe.c @@ -2770,7 +2770,7 @@ HddPasswordDxeInit ( { EFI_STATUS Status; HDD_PASSWORD_DXE_PRIVATE_DATA *Private; - EFI_EVENT Registration; + VOID *Registration; EFI_EVENT EndOfDxeEvent; EDKII_VARIABLE_LOCK_PROTOCOL *VariableLock; =20 --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47414): https://edk2.groups.io/g/devel/message/47414 Mute This Topic: https://groups.io/mt/34180229/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-