From nobody Mon Feb 9 12:26:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+47413+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47413+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568749833; cv=none; d=zoho.com; s=zohoarc; b=m5H+J8KgQeEsYwks0qvQbBOis5GQw1jWhJP9+ygwv7wp7xviigw8iSLLYtm8Vuu/96A/W64MMGCRnIbCwzPB6Z1y8S0WM5nRX2+3R5zckSSwefn8yCKAcNTTapXNE4i9IXkwVaYDsbmmjhxXoXL8U5/fxFwsY3Tle+lo94UCows= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568749833; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=fOFCK8Txt48oPaPQEnDq37AJgHyrd1bS96nQDxf+ZHg=; b=K/nT81VFkXd8W92PJu6GWYBhhAnTL3Ge4IbCoq77QPHSq/vAtxSH3MbSYlLzEhwrOdwlqvv1nGQVzCuCyDyatXIazrYcAlz/YHytuG2iVCzgay5jHk+L7EQ6psmhBFWKr8w5/fMYnlaamAeiI1WeeBIv6LXUhvkr3feC/8ovyJE= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47413+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1568749833547245.32153922993155; Tue, 17 Sep 2019 12:50:33 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id WgjOYY1788612x6cg3iLPqaM; Tue, 17 Sep 2019 12:50:33 -0700 X-Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 17 Sep 2019 12:50:32 -0700 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6B97110F2E81; Tue, 17 Sep 2019 19:50:32 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-37.rdu2.redhat.com [10.10.120.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id 303D4600C4; Tue, 17 Sep 2019 19:50:30 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Chao Zhang , Jian Wang , Jiewen Yao Subject: [edk2-devel] [PATCH 26/35] SecurityPkg: fix UninstallMultipleProtocolInterfaces() calls Date: Tue, 17 Sep 2019 21:49:26 +0200 Message-Id: <20190917194935.24322-27-lersek@redhat.com> In-Reply-To: <20190917194935.24322-1-lersek@redhat.com> References: <20190917194935.24322-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.66]); Tue, 17 Sep 2019 19:50:32 +0000 (UTC) Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com X-Gm-Message-State: PaHt7j4XfFThoroIdwnumjgRx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1568749833; bh=QsoNwb2jErGVG9FarpWau0s+dBFmCefdp6Ms6iEavDU=; h=Cc:Date:From:Reply-To:Subject:To; b=m1RpGFbR9AfVpJ3fS/OY0DgsJm2XdbCHyB9VzKbD4rcTDjd/kUR9f1DfL+NnuOxafJP 6xrSup/eILTAwT08yA3avqoaKijfNBxP/jSuwKq967k2IE4eq30T0VpeCVyuHNGtx4Ls1 yrOoYtMoGSy6kC5JMBveIDgB2fgwVHPPYhw= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Unlike the InstallMultipleProtocolInterfaces() boot service, which takes an (EFI_HANDLE*) as first parameter, the UninstallMultipleProtocolInterfaces() boot service takes an EFI_HANDLE as first parameter. These are actual bugs. They must have remained hidden until now because they are all in Unload() functions, which are probably exercised infrequently. Fix the UninstallMultipleProtocolInterfaces() calls. Cc: Chao Zhang Cc: Jian Wang Cc: Jiewen Yao Signed-off-by: Laszlo Ersek Reviewed-by: Jiewen Yao Reviewed-by: Philippe Mathieu-Daude --- Notes: build-tested only SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c = | 2 +- SecurityPkg/Tcg/TcgConfigDxe/TcgConfigDriver.c = | 2 +- SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDriv= er.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c b/SecurityPkg/Tc= g/Tcg2Config/Tcg2ConfigDriver.c index 54155a338100..9052eced757d 100644 --- a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c +++ b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c @@ -443,7 +443,7 @@ Tcg2ConfigDriverUnload ( ASSERT (PrivateData->Signature =3D=3D TCG2_CONFIG_PRIVATE_DATA_SIGNATURE= ); =20 gBS->UninstallMultipleProtocolInterfaces ( - &ImageHandle, + ImageHandle, &gEfiCallerIdGuid, PrivateData, NULL diff --git a/SecurityPkg/Tcg/TcgConfigDxe/TcgConfigDriver.c b/SecurityPkg/T= cg/TcgConfigDxe/TcgConfigDriver.c index 341879e4c4ba..fb06624fdb8f 100644 --- a/SecurityPkg/Tcg/TcgConfigDxe/TcgConfigDriver.c +++ b/SecurityPkg/Tcg/TcgConfigDxe/TcgConfigDriver.c @@ -138,7 +138,7 @@ TcgConfigDriverUnload ( ASSERT (PrivateData->Signature =3D=3D TCG_CONFIG_PRIVATE_DATA_SIGNATURE); =20 gBS->UninstallMultipleProtocolInterfaces ( - &ImageHandle, + ImageHandle, &gEfiCallerIdGuid, PrivateData, NULL diff --git a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBo= otConfigDriver.c b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/Se= cureBootConfigDriver.c index 798ef9cfbc01..6c0294151e6c 100644 --- a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfi= gDriver.c +++ b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfi= gDriver.c @@ -115,7 +115,7 @@ SecureBootConfigDriverUnload ( ASSERT (PrivateData->Signature =3D=3D SECUREBOOT_CONFIG_PRIVATE_DATA_SIG= NATURE); =20 gBS->UninstallMultipleProtocolInterfaces ( - &ImageHandle, + ImageHandle, &gEfiCallerIdGuid, PrivateData, NULL --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47413): https://edk2.groups.io/g/devel/message/47413 Mute This Topic: https://groups.io/mt/34180228/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-