From nobody Mon Feb 9 08:57:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+47409+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47409+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568749827; cv=none; d=zoho.com; s=zohoarc; b=hLBuSSMuKRlpNa3wnK8WMh++g0fg2QLN8J1ih4g4WeF0g4cmXYhFPAiwUtGKPkRsz9fxMLbTaU9mQypnKqAczsvFiOHxlzHphqtNH0AZFahcr5NSwVX1mQ8Se4Zfqxbm78rH5xgwxQoFk1knZdnGMTfxHHRgDZItawTYwWviI80= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568749827; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=hcw2caXgULDWeCcQNVJLALJhbu/pHik3lxvGvbeeA7w=; b=JnY54GF5DAByqEisFMKjBxuYPcaJMcdksnhDIZyEN5joxxaq+q9qfauXqlIlOBzh1n6tAYZZ6LHLU4KXZp/jKI+y/DffKmT2CNMjz8+h/k51idBVLLzNh1Bc5gLP5KScbbIOqBs6LKVtEK/U97s0CTPA02+GEoos4DTSbzVFlwo= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47409+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1568749827644610.5472969601691; Tue, 17 Sep 2019 12:50:27 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id AurAYY1788612xvyHQ8MLRBw; Tue, 17 Sep 2019 12:50:27 -0700 X-Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 17 Sep 2019 12:50:26 -0700 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4D6BD1918641; Tue, 17 Sep 2019 19:50:26 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-37.rdu2.redhat.com [10.10.120.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id D1729600C4; Tue, 17 Sep 2019 19:50:24 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall Subject: [edk2-devel] [PATCH 22/35] OvmfPkg/XenBusDxe: fix UninstallMultipleProtocolInterfaces() call Date: Tue, 17 Sep 2019 21:49:22 +0200 Message-Id: <20190917194935.24322-23-lersek@redhat.com> In-Reply-To: <20190917194935.24322-1-lersek@redhat.com> References: <20190917194935.24322-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.70]); Tue, 17 Sep 2019 19:50:26 +0000 (UTC) Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com X-Gm-Message-State: E9hiV5rg9iBl74RxGirmaTnpx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1568749827; bh=fPiNfHH6ma4io6K/+YOVxmgQ3Pwkdy8ISa9bD2yxCD4=; h=Cc:Date:From:Reply-To:Subject:To; b=uSZKxzdr095xzaavAJHC5ofe2yzo71OKNl5CsEPznhAWzSiQxSUMM0bFM1cX+NqgrtD nldadkto8kC8XeT8EDk8GQ0r3L8K6rVJNq8DaaXi2aZlMgGuE+GjD84LuT0jYsqYiBVRM fUmOdZEAjJe3c+WSMcDLcAcidoZ5wIvf33k= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Unlike the InstallMultipleProtocolInterfaces() boot service, which takes an (EFI_HANDLE*) as first parameter, the UninstallMultipleProtocolInterfaces() boot service takes an EFI_HANDLE as first parameter. This is an actual bug. It must have remained hidden until now because it's on an error path. Fix the UninstallMultipleProtocolInterfaces() call. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Julien Grall Signed-off-by: Laszlo Ersek Reviewed-by: Anthony PERARD Reviewed-by: Julien Grall Reviewed-by: Philippe Mathieu-Daude --- Notes: build-tested only OvmfPkg/XenBusDxe/XenBus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/XenBusDxe/XenBus.c b/OvmfPkg/XenBusDxe/XenBus.c index bb8ddbc4d44d..2451e58a5961 100644 --- a/OvmfPkg/XenBusDxe/XenBus.c +++ b/OvmfPkg/XenBusDxe/XenBus.c @@ -210,7 +210,7 @@ XenBusAddDevice ( =20 ErrorOpenProtocolByChild: gBS->UninstallMultipleProtocolInterfaces ( - &Private->Handle, + Private->Handle, &gEfiDevicePathProtocolGuid, Private->DevicePath, &gXenBusProtocolGuid, &Private->XenBusIo, NULL); --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47409): https://edk2.groups.io/g/devel/message/47409 Mute This Topic: https://groups.io/mt/34180223/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-