From nobody Mon Feb 9 11:33:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+47407+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47407+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568749824; cv=none; d=zoho.com; s=zohoarc; b=igIyL3IN+njId1lJcF8Q/h6A1txcyYSnlkwtZOnik9m9zqlhdpZGG6YwFq8d/xglEzPVnzA+6DwZZsR4w6UdojFZJFZWREQ2bFv1wQnmIvSNErquuF3eibwz4705ikoa8Bew/uwAcq6xkwQ8xPh8VI7cMKR/mqVzLvYoWfeJ5i4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568749824; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=p8G3xJseCAQsG9zZXIZIjTef0f7tIpl3BFcTXms9Rp0=; b=dkmibGbO9GE68LLouCCcEL5yAh1T2QFsndAcwRBakbPCJivhVdp15QhxKJiB+U5srC2NRH4aMopkwcEFR4qUJSXeGd3GkZRvgj2VRPD5IFqJ/FXZxcmk4ft550k4rpH4j31mWzNC75Ls0/jsEpDSeyp+i/6AfWlk0DnQJso0XNw= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47407+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1568749824278561.7889068212918; Tue, 17 Sep 2019 12:50:24 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ZiQVYY1788612x6vxSTs8qws; Tue, 17 Sep 2019 12:50:23 -0700 X-Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 17 Sep 2019 12:50:23 -0700 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0CC8A30832EA; Tue, 17 Sep 2019 19:50:23 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-37.rdu2.redhat.com [10.10.120.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id 01ADD600C4; Tue, 17 Sep 2019 19:50:21 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Jiaxin Wu , Siyuan Fu Subject: [edk2-devel] [PATCH 20/35] NetworkPkg/Ip4Dxe: fix NetLibDestroyServiceChild() call Date: Tue, 17 Sep 2019 21:49:20 +0200 Message-Id: <20190917194935.24322-21-lersek@redhat.com> In-Reply-To: <20190917194935.24322-1-lersek@redhat.com> References: <20190917194935.24322-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Tue, 17 Sep 2019 19:50:23 +0000 (UTC) Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com X-Gm-Message-State: Os6ZjEqgx5dvgE9OalyGWgkyx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1568749823; bh=jRW8dbPxGkfDb2vqcQepFZj8awfCTCbAXGdbIUZ3+uI=; h=Cc:Date:From:Reply-To:Subject:To; b=sZgSgr9KGY+Zj67J1cAmYb4Lofz13fnT4hMBSsQVcCzgY1nqmZj0XXzUdiX6rc2reXu 2AQ5U+E/rH6FJGs6ozspwSAyGK9LqXEPpflfbpKVzRre2AZmeN56oCcvn3VPd4aGl8Fa5 eIWQRhpEBm78EqjuKFnvHS3OMRLfuBH7evY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Both NetLibDestroyServiceChild() and EFI_SERVICE_BINDING_DESTROY_CHILD take an EFI_HANDLE for the "ChildHandle" parameter, not an (EFI_HANDLE*). This patch fixes a real bug. Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Laszlo Ersek Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Siyuan Fu --- Notes: possibly only build-tested NetworkPkg/Ip4Dxe/Ip4If.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NetworkPkg/Ip4Dxe/Ip4If.c b/NetworkPkg/Ip4Dxe/Ip4If.c index 44b8d9fc8faf..53a333037f94 100644 --- a/NetworkPkg/Ip4Dxe/Ip4If.c +++ b/NetworkPkg/Ip4Dxe/Ip4If.c @@ -592,7 +592,7 @@ Ip4SetAddress ( Interface->Controller, Interface->Image, &gEfiArpServiceBindingProtocolGuid, - &Interface->ArpHandle + Interface->ArpHandle ); =20 Interface->ArpHandle =3D NULL; @@ -657,7 +657,7 @@ ON_ERROR: Interface->Controller, Interface->Image, &gEfiArpServiceBindingProtocolGuid, - &Interface->ArpHandle + Interface->ArpHandle ); =20 return Status; --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47407): https://edk2.groups.io/g/devel/message/47407 Mute This Topic: https://groups.io/mt/34180221/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-