From nobody Mon Feb 9 08:57:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+47405+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47405+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568749821; cv=none; d=zoho.com; s=zohoarc; b=cj4lB/LrqabO3Dz6tu2IaOIB0reRKc6vdgtHHQ+JaANlDFtQ6AaAPS8j8xNePVnGiO/YotLa2Q4wdo7faReZdceDqsewQCzzs5ctkSvA+wgjlKwcuHfGFLzBtWakKZEGT6b/hWT1LN5VykNQZOszZY08/6dJrBw6E4qHpUnxmi0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568749821; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=gofdJeXW2RRfQZodmYNLS8ackApePI2ceLshvObzDl0=; b=c0rkZixqzTG3RSIRdwgKOVBHmo7s481/Mka4AOunm2zPVhS5FLHTxyLFFeuCtdWl3KX3nNH6LO+T1VFYURmPJuy9TTZnA5pyxDoG0dhfbU0ZDXdPDr6ipCDnsK4phY0UcYUNfGSQNMatBKubFpuJq0sL7WpvWWp19V07C4LWUpQ= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47405+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1568749821532502.5163631770056; Tue, 17 Sep 2019 12:50:21 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id VkAbYY1788612xssAf2LHtYK; Tue, 17 Sep 2019 12:50:21 -0700 X-Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 17 Sep 2019 12:50:20 -0700 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 30CA618C426E; Tue, 17 Sep 2019 19:50:20 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-37.rdu2.redhat.com [10.10.120.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id 25FFA600C4; Tue, 17 Sep 2019 19:50:18 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Jiaxin Wu , Siyuan Fu Subject: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress() Date: Tue, 17 Sep 2019 21:49:18 +0200 Message-Id: <20190917194935.24322-19-lersek@redhat.com> In-Reply-To: <20190917194935.24322-1-lersek@redhat.com> References: <20190917194935.24322-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.62]); Tue, 17 Sep 2019 19:50:20 +0000 (UTC) Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com X-Gm-Message-State: o7TdCuLrlECsCZ4nSjkuNv5hx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1568749821; bh=RnpReZpcVFwoa0cdHFPls/caqU3vuIzp0QCRolcIYNc=; h=Cc:Date:From:Reply-To:Subject:To; b=R4a2KGwvQkAnmoZsir06GHVVtQZzNGHtXMtxX/36/JGfsxkRvWyJkrhp2OQQeNdlGDJ 9tbJeyf8ElLNlrTs/FhqrVvKKJqchcVPXr5qlxG+lMu5qALwCUFKFKv4BtpbVPJGU85t2 oeffCQ+SrfVUGuDgYbSS6W0/h+SwmUZNcJQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" NetLibGetSnpHandle() returns an EFI_HANDLE, not an (EFI_HANDLE*). NetLibGetMacAddress() only uses the return value ("SnpHandle") for a NULL-check. Fix the type of "SnpHandle". This patch is a no-op. Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Laszlo Ersek Reviewed-by: Michael D Kinney Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Siyuan Fu --- Notes: lightly tested: MAC strings are displayed in UiApp NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c b/NetworkPkg/Library/= DxeNetLib/DxeNetLib.c index 8e2f720666ea..a39c20be3d34 100644 --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c @@ -2182,7 +2182,7 @@ NetLibGetMacAddress ( EFI_SIMPLE_NETWORK_MODE SnpModeData; EFI_MANAGED_NETWORK_PROTOCOL *Mnp; EFI_SERVICE_BINDING_PROTOCOL *MnpSb; - EFI_HANDLE *SnpHandle; + EFI_HANDLE SnpHandle; EFI_HANDLE MnpChildHandle; =20 ASSERT (MacAddress !=3D NULL); --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47405): https://edk2.groups.io/g/devel/message/47405 Mute This Topic: https://groups.io/mt/34180219/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-