From nobody Mon Feb 9 12:26:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+47399+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47399+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568749810; cv=none; d=zoho.com; s=zohoarc; b=FBwd2tqv41X026RUurQbLh6p0CsNoyEegm3gMaNwWV68SyocO0Le7f3F33YmYcZCiSQxlaaBmhjVQoIVmL/PsWuswaF4fDfSX3xWIjno9dt9n2Zf+GNLAeM0MVlp8zCO1/Zd/9G1Z4FuoWVPq2XmENozw64l3tht1B0rB9GLyhk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568749810; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=4LaBziHNhI3TSO+QzYIPzomZSMIY02N7LzlbpvkpoVA=; b=Y8xq62UV/eSLHatk9YDahjdcv9JiUThh9n82UvckR7ev6fWBTusAoth6q13k1fDH+GkYmwGMnR+RlbhIk2aQOujMGyOppl6wK1SOPR9CMWKgrOwnUXczhzGu+CrUpsa33NBkdeYTCc/4VVdmOxZgbB1uKOFtXlkdS3Khpb+CTWY= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47399+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1568749810971907.9370122460733; Tue, 17 Sep 2019 12:50:10 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id WPXZYY1788612xDQUWwR8hpQ; Tue, 17 Sep 2019 12:50:10 -0700 X-Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 17 Sep 2019 12:50:10 -0700 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B6B478A1C90; Tue, 17 Sep 2019 19:50:09 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-37.rdu2.redhat.com [10.10.120.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id D8D71600C4; Tue, 17 Sep 2019 19:50:07 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Dandan Bi , Eric Dong , Hao A Wu , Jian J Wang , Ray Ni , Zhichao Gao Subject: [edk2-devel] [PATCH 12/35] MdeModulePkg: stop abusing EFI_HANDLE for keystroke notify registration Date: Tue, 17 Sep 2019 21:49:12 +0200 Message-Id: <20190917194935.24322-13-lersek@redhat.com> In-Reply-To: <20190917194935.24322-1-lersek@redhat.com> References: <20190917194935.24322-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.69]); Tue, 17 Sep 2019 19:50:09 +0000 (UTC) Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com X-Gm-Message-State: UBdkVHtc8N3BWXrf91k6RlREx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1568749810; bh=lkPgrKDUJPnPRe4DcJR0iQR3aqyvhGGVvD2sZ9w06Fs=; h=Cc:Date:From:Reply-To:Subject:To; b=nLNIevd2qD2YfO3swSnXdy9GydwTlIy3PdPKtR0adCSV/r+Cx8+QximjtyNBwiAuz/O kaQWgi0KY2dKVR7+w7u0mlN48+9UoC6bW4TElYyZnK4NIHYPPmOoUd5pXZgo29mtEr8s0 +ZFKYXaziPt7msQEQymgE/gyfSbXIbKb90A= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" EFI_REGISTER_KEYSTROKE_NOTIFY and EFI_UNREGISTER_KEYSTROKE_NOTIFY require the notification handle to have type (VOID*). The notification handle has nothing to do with the EFI_HANDLE type. This change is a semantic fix; functionally, it's a no-op. Cc: Dandan Bi Cc: Eric Dong Cc: Hao A Wu Cc: Jian J Wang Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Laszlo Ersek Reviewed-by: Dandan Bi Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Ray Ni --- Notes: lightly tested: ConSplitterDxe is part of the ArmVirt and OVMF platforms MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 2 +- MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c b/= MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c index 63c814ae1816..9c38271b65f9 100644 --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c @@ -4026,7 +4026,7 @@ ConSplitterTextInRegisterKeyNotify ( if (NewNotify =3D=3D NULL) { return EFI_OUT_OF_RESOURCES; } - NewNotify->NotifyHandleList =3D (EFI_HANDLE *) AllocateZeroPool (sizeof = (EFI_HANDLE) * Private->TextInExListCount); + NewNotify->NotifyHandleList =3D (VOID **) AllocateZeroPool (sizeof (VOID= *) * Private->TextInExListCount); if (NewNotify->NotifyHandleList =3D=3D NULL) { gBS->FreePool (NewNotify); return EFI_OUT_OF_RESOURCES; diff --git a/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c b/MdeMod= ulePkg/Universal/DriverSampleDxe/DriverSample.c index 7cfd5c178861..f98797225b63 100644 --- a/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c +++ b/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c @@ -143,7 +143,7 @@ InternalStartMonitor( EFI_HANDLE *Handles; UINTN HandleCount; UINTN HandleIndex; - EFI_HANDLE NotifyHandle; + VOID *NotifyHandle; =20 Status =3D gBS->LocateHandleBuffer ( ByProtocol, @@ -202,7 +202,7 @@ InternalStopMonitor( EFI_KEY_DATA KeyData; UINTN HandleCount; UINTN HandleIndex; - EFI_HANDLE NotifyHandle; + VOID *NotifyHandle; =20 Status =3D gBS->LocateHandleBuffer ( ByProtocol, --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47399): https://edk2.groups.io/g/devel/message/47399 Mute This Topic: https://groups.io/mt/34180213/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-