From nobody Sun Feb 8 23:41:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+47243+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47243+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1568596144; cv=none; d=zoho.com; s=zohoarc; b=TyztZaJ8f5nKoCWRQKPVVRmrvgTRNYscXewazHg00Et1zABRYMsZf/Bn3kvldvva74Lo80Xy/ypXyqABZYy6h6R+gzmW5aH+lx3tl8QxBcG6E7DwPiAZLhOU8XEB/fLmt3pUDqV9BrZlZ9r5kH+7cQ4pVZDVoUCBuuGwwQ2caAI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568596144; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To:ARC-Authentication-Results; bh=umCHGcdbXuRf3skuckzVCmVgy5b5HV/UWAaKb/X6pSc=; b=P6KLaeqSv6up3yP0ReDXaVLz5Mo8NeOqru7Tv1QrJipvSC0RpJJO9VwCE0hdAP2l4Irx7e8y5xwO1JxFjve5HNuaNEqGXQu5ub6AsFXLJU3g4t5iEQvo2tl9Mx5Ipvr1aSEWEEBXCD83+ePGAlX35a3ZZ3LoSgD7Ub4RGLMP+iM= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47243+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1568596143968980.0113617457073; Sun, 15 Sep 2019 18:09:03 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id VYAEYY1788612x2G14nIYJay; Sun, 15 Sep 2019 18:09:03 -0700 X-Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Sun, 15 Sep 2019 18:09:02 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Sep 2019 18:09:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,492,1559545200"; d="scan'208";a="190930278" X-Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by orsmga006.jf.intel.com with ESMTP; 15 Sep 2019 18:09:00 -0700 From: "Zhang, Shenglei" To: devel@edk2.groups.io Cc: Michael Kubacki , Chasel Chiu , Nate DeSimone , Liming Gao Subject: [edk2-devel] [PATCH v2] MinPlatformPkg/TestPointCheckLib: Add return value when OutTable is NULL Date: Mon, 16 Sep 2019 09:08:57 +0800 Message-Id: <20190916010857.42264-1-shenglei.zhang@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,shenglei.zhang@intel.com X-Gm-Message-State: 4rDPMcqMi0EUEtDWdbTfOTsMx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1568596143; bh=KxQznu5H6hI7YReaeMNAVhdhhLcCH8432dF5tv5SR64=; h=Cc:Date:From:Reply-To:Subject:To; b=cFAyhc9wHKwHf3a62BPNyztl/ZhG1nt8SNOr17eq2V0lxxebgFJRyeaSJMClI+eZbdb x2IwhslK2YLIlyZtbPPNR+qoJUor/xifcwSevO8SbYvFpImWdXqSnhYDKRVNHU+OEFgFe 891Y5qK8Y5esGFKwxP+dsBQHaA77bcFYhzU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Currently there is no check for the parameter OutTable. So add the logic that return value EFI_INVALID_PARAMETER when the OutTable is NULL. Cc: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Shenglei Zhang Reviewed-by: Chasel Chiu Reviewed-by: Michael Kubacki Reviewed-by: Nate DeSimone --- v2:Update the copyright and the if...else statement coding style. .../Test/Library/TestPointCheckLib/DxeCheckAcpi.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/D= xeCheckAcpi.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLi= b/DxeCheckAcpi.c index 263781a2..83736bf3 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck= Acpi.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck= Acpi.c @@ -1,6 +1,6 @@ /** @file =20 -Copyright (c) 2017, Intel Corporation. All rights reserved.
+Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -610,6 +610,8 @@ DumpAcpiRsdt ( =20 if (OutTable !=3D NULL) { *OutTable =3D NULL; + } else{ + return EFI_INVALID_PARAMETER; } =20 ReturnStatus =3D EFI_SUCCESS; @@ -663,6 +665,8 @@ DumpAcpiXsdt ( =20 if (OutTable !=3D NULL) { *OutTable =3D NULL; + } else{ + return EFI_INVALID_PARAMETER; } =20 ReturnStatus =3D EFI_SUCCESS; --=20 2.18.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47243): https://edk2.groups.io/g/devel/message/47243 Mute This Topic: https://groups.io/mt/34159564/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-