[edk2-devel] [edk2-platforms][PATCH V5] AdvancedFeaturePkg/S3: Add S3 PEIM driver

Marc W Chen posted 1 patch 1 week ago
Failed in applying to current master (apply log)
.../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc      |  2 ++
Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c       | 36 ++++++++++++++++++++++
Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf     | 31 +++++++++++++++++++
3 files changed, 69 insertions(+)
create mode 100644 Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c
create mode 100644 Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf

[edk2-devel] [edk2-platforms][PATCH V5] AdvancedFeaturePkg/S3: Add S3 PEIM driver

Posted by Marc W Chen 1 week ago
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2154

Implement a S3 PEIM driver for supporting S3 feature.
So far this driver only install EFI_PEI_MM_ACCESS_PPI for S3 resume case.

Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Marc Chen <marc.w.chen@intel.com>
---
 .../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc      |  2 ++
 Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c       | 36 ++++++++++++++++++++++
 Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf     | 31 +++++++++++++++++++
 3 files changed, 69 insertions(+)
 create mode 100644 Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c
 create mode 100644 Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf

diff --git a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
index a50952dd..2ab706c2 100644
--- a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
+++ b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
@@ -149,5 +149,7 @@
   AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.inf
   AdvancedFeaturePkg/Ipmi/BmcAcpi/BmcAcpi.inf
 
+  AdvancedFeaturePkg/S3/S3Pei.inf
+
 [BuildOptions]
   *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
\ No newline at end of file
diff --git a/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c b/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c
new file mode 100644
index 00000000..b0aaa049
--- /dev/null
+++ b/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c
@@ -0,0 +1,36 @@
+/** @file
+  Source code file for S3 PEI module
+
+Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#include <Library/PeiServicesLib.h>
+#include <Library/SmmAccessLib.h>
+
+/**
+  S3 PEI module entry point
+
+  @param[in]  FileHandle           Not used.
+  @param[in]  PeiServices          General purpose services available to every PEIM.
+
+  @retval     EFI_SUCCESS          The function completes successfully
+  @retval     EFI_OUT_OF_RESOURCES Insufficient resources to create database
+**/
+EFI_STATUS
+EFIAPI
+S3PeiEntryPoint (
+  IN       EFI_PEI_FILE_HANDLE  FileHandle,
+  IN CONST EFI_PEI_SERVICES     **PeiServices
+  )
+{
+  EFI_STATUS Status;
+
+  //
+  // Install EFI_PEI_MM_ACCESS_PPI for S3 resume case
+  //
+  Status = PeiInstallSmmAccessPpi ();
+
+  return Status;
+}
diff --git a/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf b/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf
new file mode 100644
index 00000000..847edd20
--- /dev/null
+++ b/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf
@@ -0,0 +1,31 @@
+### @file
+# Component information file for the S3 PEI module.
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+###
+
+[Defines]
+  INF_VERSION                    = 0x00010017
+  BASE_NAME                      = S3Pei
+  FILE_GUID                      = 8683EFB2-FDE1-4AFF-B2DB-E96449FDD4E9
+  VERSION_STRING                 = 1.0
+  MODULE_TYPE                    = PEIM
+  ENTRY_POINT                    = S3PeiEntryPoint
+
+[LibraryClasses]
+  PeimEntryPoint
+  PeiServicesLib
+  SmmAccessLib
+
+[Packages]
+  MdePkg/MdePkg.dec
+  IntelSiliconPkg/IntelSiliconPkg.dec
+
+[Sources]
+  S3Pei.c
+
+[Depex]
+  gEfiPeiMemoryDiscoveredPpiGuid
-- 
2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47096): https://edk2.groups.io/g/devel/message/47096
Mute This Topic: https://groups.io/mt/34099348/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH V5] AdvancedFeaturePkg/S3: Add S3 PEIM driver

Posted by Chaganty, Rangasai V 1 week ago
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com> 

-----Original Message-----
From: Chen, Marc W 
Sent: Tuesday, September 10, 2019 7:27 PM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Gao, Liming <liming.gao@intel.com>; Chen, Marc W <marc.w.chen@intel.com>
Subject: [edk2-platforms][PATCH V5] AdvancedFeaturePkg/S3: Add S3 PEIM driver

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2154

Implement a S3 PEIM driver for supporting S3 feature.
So far this driver only install EFI_PEI_MM_ACCESS_PPI for S3 resume case.

Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Marc Chen <marc.w.chen@intel.com>
---
 .../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc      |  2 ++
 Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c       | 36 ++++++++++++++++++++++
 Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf     | 31 +++++++++++++++++++
 3 files changed, 69 insertions(+)
 create mode 100644 Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c
 create mode 100644 Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf

diff --git a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
index a50952dd..2ab706c2 100644
--- a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
+++ b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
@@ -149,5 +149,7 @@
   AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.inf
   AdvancedFeaturePkg/Ipmi/BmcAcpi/BmcAcpi.inf
 
+  AdvancedFeaturePkg/S3/S3Pei.inf
+
 [BuildOptions]
   *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES \ No newline at end of file diff --git a/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c b/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c
new file mode 100644
index 00000000..b0aaa049
--- /dev/null
+++ b/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c
@@ -0,0 +1,36 @@
+/** @file
+  Source code file for S3 PEI module
+
+Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#include <Library/PeiServicesLib.h>
+#include <Library/SmmAccessLib.h>
+
+/**
+  S3 PEI module entry point
+
+  @param[in]  FileHandle           Not used.
+  @param[in]  PeiServices          General purpose services available to every PEIM.
+
+  @retval     EFI_SUCCESS          The function completes successfully
+  @retval     EFI_OUT_OF_RESOURCES Insufficient resources to create database
+**/
+EFI_STATUS
+EFIAPI
+S3PeiEntryPoint (
+  IN       EFI_PEI_FILE_HANDLE  FileHandle,
+  IN CONST EFI_PEI_SERVICES     **PeiServices
+  )
+{
+  EFI_STATUS Status;
+
+  //
+  // Install EFI_PEI_MM_ACCESS_PPI for S3 resume case  //  Status = 
+ PeiInstallSmmAccessPpi ();
+
+  return Status;
+}
diff --git a/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf b/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf
new file mode 100644
index 00000000..847edd20
--- /dev/null
+++ b/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf
@@ -0,0 +1,31 @@
+### @file
+# Component information file for the S3 PEI module.
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> # # 
+SPDX-License-Identifier: BSD-2-Clause-Patent # ###
+
+[Defines]
+  INF_VERSION                    = 0x00010017
+  BASE_NAME                      = S3Pei
+  FILE_GUID                      = 8683EFB2-FDE1-4AFF-B2DB-E96449FDD4E9
+  VERSION_STRING                 = 1.0
+  MODULE_TYPE                    = PEIM
+  ENTRY_POINT                    = S3PeiEntryPoint
+
+[LibraryClasses]
+  PeimEntryPoint
+  PeiServicesLib
+  SmmAccessLib
+
+[Packages]
+  MdePkg/MdePkg.dec
+  IntelSiliconPkg/IntelSiliconPkg.dec
+
+[Sources]
+  S3Pei.c
+
+[Depex]
+  gEfiPeiMemoryDiscoveredPpiGuid
--
2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47103): https://edk2.groups.io/g/devel/message/47103
Mute This Topic: https://groups.io/mt/34099348/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH V5] AdvancedFeaturePkg/S3: Add S3 PEIM driver

Posted by Kubacki, Michael A 1 week ago
Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Marc W
> Chen
> Sent: Tuesday, September 10, 2019 7:27 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Gao, Liming <liming.gao@intel.com>; Chen,
> Marc W <marc.w.chen@intel.com>
> Subject: [edk2-devel] [edk2-platforms][PATCH V5] AdvancedFeaturePkg/S3: Add
> S3 PEIM driver
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2154
> 
> Implement a S3 PEIM driver for supporting S3 feature.
> So far this driver only install EFI_PEI_MM_ACCESS_PPI for S3 resume case.
> 
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Marc Chen <marc.w.chen@intel.com>
> ---
>  .../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc      |  2 ++
>  Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c       | 36
> ++++++++++++++++++++++
>  Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf     | 31 +++++++++++++++++++
>  3 files changed, 69 insertions(+)
>  create mode 100644 Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c
>  create mode 100644 Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf
> 
> diff --git a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
> b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
> index a50952dd..2ab706c2 100644
> --- a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
> +++ b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
> @@ -149,5 +149,7 @@
>    AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.inf
>    AdvancedFeaturePkg/Ipmi/BmcAcpi/BmcAcpi.inf
> 
> +  AdvancedFeaturePkg/S3/S3Pei.inf
> +
>  [BuildOptions]
>    *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES \ No newline
> at end of file diff --git a/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c
> b/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c
> new file mode 100644
> index 00000000..b0aaa049
> --- /dev/null
> +++ b/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c
> @@ -0,0 +1,36 @@
> +/** @file
> +  Source code file for S3 PEI module
> +
> +Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#include <Library/PeiServicesLib.h>
> +#include <Library/SmmAccessLib.h>
> +
> +/**
> +  S3 PEI module entry point
> +
> +  @param[in]  FileHandle           Not used.
> +  @param[in]  PeiServices          General purpose services available to every
> PEIM.
> +
> +  @retval     EFI_SUCCESS          The function completes successfully
> +  @retval     EFI_OUT_OF_RESOURCES Insufficient resources to create database
> +**/
> +EFI_STATUS
> +EFIAPI
> +S3PeiEntryPoint (
> +  IN       EFI_PEI_FILE_HANDLE  FileHandle,
> +  IN CONST EFI_PEI_SERVICES     **PeiServices
> +  )
> +{
> +  EFI_STATUS Status;
> +
> +  //
> +  // Install EFI_PEI_MM_ACCESS_PPI for S3 resume case  //  Status =
> + PeiInstallSmmAccessPpi ();
> +
> +  return Status;
> +}
> diff --git a/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf
> b/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf
> new file mode 100644
> index 00000000..847edd20
> --- /dev/null
> +++ b/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf
> @@ -0,0 +1,31 @@
> +### @file
> +# Component information file for the S3 PEI module.
> +#
> +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> # #
> +SPDX-License-Identifier: BSD-2-Clause-Patent # ###
> +
> +[Defines]
> +  INF_VERSION                    = 0x00010017
> +  BASE_NAME                      = S3Pei
> +  FILE_GUID                      = 8683EFB2-FDE1-4AFF-B2DB-E96449FDD4E9
> +  VERSION_STRING                 = 1.0
> +  MODULE_TYPE                    = PEIM
> +  ENTRY_POINT                    = S3PeiEntryPoint
> +
> +[LibraryClasses]
> +  PeimEntryPoint
> +  PeiServicesLib
> +  SmmAccessLib
> +
> +[Packages]
> +  MdePkg/MdePkg.dec
> +  IntelSiliconPkg/IntelSiliconPkg.dec
> +
> +[Sources]
> +  S3Pei.c
> +
> +[Depex]
> +  gEfiPeiMemoryDiscoveredPpiGuid
> --
> 2.16.2.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47102): https://edk2.groups.io/g/devel/message/47102
Mute This Topic: https://groups.io/mt/34099348/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-