[edk2-devel] [Patch 0/3] Clean BaseTools code for build performance

Bob Feng posted 3 patches 1 week ago
Only 0 patches received!
.../Source/Python/AutoGen/AutoGenWorker.py    |  7 +-
BaseTools/Source/Python/AutoGen/GenC.py       | 97 ++++++++++---------
BaseTools/Source/Python/AutoGen/GenMake.py    | 35 ++++---
.../Source/Python/AutoGen/PlatformAutoGen.py  |  8 +-
.../Source/Python/AutoGen/UniClassObject.py   |  5 +-
BaseTools/Source/Python/Common/Misc.py        | 23 +----
6 files changed, 82 insertions(+), 93 deletions(-)

[edk2-devel] [Patch 0/3] Clean BaseTools code for build performance

Posted by Bob Feng 1 week ago
REF:
1 https://bugzilla.tianocore.org/show_bug.cgi?id=2102
2 https://bugzilla.tianocore.org/show_bug.cgi?id=2101
3 https://bugzilla.tianocore.org/show_bug.cgi?id=2183

By profiling build Ovmf with cProfile:

1. re.findall time reduced:
after patch:
0.017  {method 'findall' of '_sre.SRE_Pattern' objects}
original:
0.212  {method 'findall' of '_sre.SRE_Pattern' objects}

2. times of call of os.stat is reduced
after patch:
33307    {built-in method nt.stat}
orignial:
33774    {built-in method nt.stat}

3. rename call is removed.
original:
2.165 {built-in method nt.rename}

Feng, Bob C (3):
  BaseTools: Improve GetDependencyList function
  BaseTools: remove unnecessary calls of os.exist
  BaseTools:Remove the unnecessary operation of renaming a file.

 .../Source/Python/AutoGen/AutoGenWorker.py    |  7 +-
 BaseTools/Source/Python/AutoGen/GenC.py       | 97 ++++++++++---------
 BaseTools/Source/Python/AutoGen/GenMake.py    | 35 ++++---
 .../Source/Python/AutoGen/PlatformAutoGen.py  |  8 +-
 .../Source/Python/AutoGen/UniClassObject.py   |  5 +-
 BaseTools/Source/Python/Common/Misc.py        | 23 +----
 6 files changed, 82 insertions(+), 93 deletions(-)

-- 
2.20.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47073): https://edk2.groups.io/g/devel/message/47073
Mute This Topic: https://groups.io/mt/34090163/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch 0/3] Clean BaseTools code for build performance

Posted by Liming Gao 3 days ago
Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Bob Feng
>Sent: Tuesday, September 10, 2019 5:37 PM
>To: devel@edk2.groups.io
>Subject: [edk2-devel] [Patch 0/3] Clean BaseTools code for build performance
>
>REF:
>1 https://bugzilla.tianocore.org/show_bug.cgi?id=2102
>2 https://bugzilla.tianocore.org/show_bug.cgi?id=2101
>3 https://bugzilla.tianocore.org/show_bug.cgi?id=2183
>
>By profiling build Ovmf with cProfile:
>
>1. re.findall time reduced:
>after patch:
>0.017  {method 'findall' of '_sre.SRE_Pattern' objects}
>original:
>0.212  {method 'findall' of '_sre.SRE_Pattern' objects}
>
>2. times of call of os.stat is reduced
>after patch:
>33307    {built-in method nt.stat}
>orignial:
>33774    {built-in method nt.stat}
>
>3. rename call is removed.
>original:
>2.165 {built-in method nt.rename}
>
>Feng, Bob C (3):
>  BaseTools: Improve GetDependencyList function
>  BaseTools: remove unnecessary calls of os.exist
>  BaseTools:Remove the unnecessary operation of renaming a file.
>
> .../Source/Python/AutoGen/AutoGenWorker.py    |  7 +-
> BaseTools/Source/Python/AutoGen/GenC.py       | 97 ++++++++++---------
> BaseTools/Source/Python/AutoGen/GenMake.py    | 35 ++++---
> .../Source/Python/AutoGen/PlatformAutoGen.py  |  8 +-
> .../Source/Python/AutoGen/UniClassObject.py   |  5 +-
> BaseTools/Source/Python/Common/Misc.py        | 23 +----
> 6 files changed, 82 insertions(+), 93 deletions(-)
>
>--
>2.20.1.windows.1
>
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47320): https://edk2.groups.io/g/devel/message/47320
Mute This Topic: https://groups.io/mt/34090163/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-