From nobody Sat Apr 27 02:35:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+46962+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+46962+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1567753290; cv=none; d=zoho.com; s=zohoarc; b=Vog1idIvG8I3SsbyNGJqGtwSGho6xZAmIUf5Ab+9Or+Nm50VyfKjyZgqc2J/FZdePzAEB1oRyTlSHaZyIqC/vo7jjn+xyZds9PYovCjE2p492lbvfq5082quLKsLBpJwfibTkKs2wXQUTJmwE1f2EaPrmqjCKXL5xuxm7MffmzU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567753290; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To:ARC-Authentication-Results; bh=yHHVnZvNAAbNE2w0+RTR5JTeziukDHXeVxiVwBKud90=; b=gLzCr4Mg1/YWO4cvXtPFzLfaqorqjaL+tSp7KROzF9b+LMfP+Xc+D+1CMgpQACnNUkBJlCJVHQvsz18ctyF28vOWJ057G+JsC6bYOljp1M/a4fQBRNKHaR/1f2azPWMKLjnzZLR+zFoZFD3nMgfRUDIYNo6jzH9RcICBfbEILfk= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+46962+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1567753290079932.9970870981267; Fri, 6 Sep 2019 00:01:30 -0700 (PDT) Return-Path: X-Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Fri, 06 Sep 2019 00:01:29 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Sep 2019 00:01:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,472,1559545200"; d="scan'208";a="383168786" X-Received: from cchiu4-mobl1.gar.corp.intel.com ([10.5.215.135]) by fmsmga005.fm.intel.com with ESMTP; 06 Sep 2019 00:01:27 -0700 From: "Chiu, Chasel" To: devel@edk2.groups.io Cc: Michael Kubacki , Nate DeSimone , Liming Gao Subject: [edk2-devel] [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB Temporary RAM in Dispatch mode. Date: Fri, 6 Sep 2019 15:01:10 +0800 Message-Id: <20190906070110.18204-1-chasel.chiu@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,chasel.chiu@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1567753289; bh=xtbGWLRu8wuqXn+OVGDomTQK9D389tTZLsa6/+WL1MA=; h=Cc:Date:From:Reply-To:Subject:To; b=YstFBCqEHjDwQIkXFYncHx0A69q9bseUb6oYOT1QUABPPQJJvOFyENlsugi0VkCwrX2 4OrCOZGSg3W7UTJMqpYQ04HZD+08JOAxCjRKGzAS8vrV/1HXrKE2kHcMT8VRKGQzrHxiv Egxf1QxJgu9V2DKTP6530GXinvvBPonnOVQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2159 FSP Dispatch mode will share same stack and heap with bootloader so we should not reserve separate temporary ram for FSP. Set PcdFspTemporaryRamSize to 0 in Dispatch mode. Test: internal platform can boot with FSP Dispatch mode with 64KB temporary RAM back. Cc: Michael Kubacki Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Chasel Chiu Reviewed-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc | 6 += ++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgP= cd.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.d= sc index 55ae9f47ac..2009bb225a 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc @@ -69,10 +69,10 @@ gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000 !else # - # FSP Dispatch mode will share the same stack with boot loader, - # here temporary ram size is used by FSP heap and can be smaller + # FSP Dispatch mode will share the same stack and heap with boot loader, + # no separate temporary ram required by FSP. # - gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize | 0x00010000 + gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize | 0 =20 # # In FSP Dispatch mode boot loader stack size must be big enough for exe= cuting --=20 2.13.3.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46962): https://edk2.groups.io/g/devel/message/46962 Mute This Topic: https://groups.io/mt/33163786/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-