From nobody Mon Apr 29 13:08:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+46723+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+46723+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1567534644; cv=none; d=zoho.com; s=zohoarc; b=QL4uK7KhVJFt81q5dpcl3Us/7vPqOkptZRsRpVgTFzNOQjFhmAMd0kl1SgM8fUXGh+sKZA1cEGfUlpm5ADHOc2mGsnIjoUqvcRYcXCCPyt81j/DR7mgaC8ZFZjRi1EtO5fKdV7aACW1van5wxb2/XTHC65YnpDheAG8zaB+h8xk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567534644; h=Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To:ARC-Authentication-Results; bh=4KviI+YUqHkdWOfXMuQzdYbypyGflWB1GHQpNWN2XJ8=; b=M4IivgtYw4xKx6cLKbQL9h0zMvOVi6YtrjOu34JeJIIAsrzlU+iaCj5oRTbUZ8g6rIPTDbf7kkYc/IQrOlKRncTqv7yDxILcJ62qDWRs+dZc9AJzljBTsvOJOKyKusgPRJucm2cCyl28/YqnFT2quBlk28eQy8GAKBYJpEmIMLg= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+46723+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1567534644230853.262442448859; Tue, 3 Sep 2019 11:17:24 -0700 (PDT) Return-Path: X-Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Tue, 03 Sep 2019 11:15:35 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Sep 2019 11:15:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,464,1559545200"; d="scan'208";a="383180812" X-Received: from jelofgre-desk.amr.corp.intel.com ([10.78.26.249]) by fmsmga006.fm.intel.com with ESMTP; 03 Sep 2019 11:15:34 -0700 From: "John E Lofgren" To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH] UefiCpuPkg/CpuExceptionHandlerLib: Fix #AC split lock Date: Tue, 3 Sep 2019 11:15:24 -0700 Message-Id: <20190903181524.1132-1-john.e.lofgren@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,john.e.lofgren@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1567534643; bh=j+neVbrQAiyUrKjClqATHnvibzf4ZdagJ+bUGkxt3CE=; h=Date:From:Reply-To:Subject:To; b=NV2cLM1cRYJgLhCnDZGesx24IMuahghI8CHN9yR0rzC8kU5CsLJbHxyd02QrIf29UBr K459SIqkECrd+nrYWbt6fJZIpSgLY/d8ZbIdj63Dxq3v0mGcgyB1IOyRpW4oCfX0evXgq PABagg7VgYPvpEwF5y1ANjBYv0KXFMgK2Rg= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2150 Fix #AC split lock's caused by seperating base and limit from sgdt and sidt by changing xchg operands to 32-bit to stop from crossing cacheline. Signed-off-by: John E Lofgren --- UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionHandlerAsm.nasm | 1= 2 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionHandler= Asm.nasm b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionHandlerAs= m.nasm index 4db1a09f28..6d83dca4b9 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionHandlerAsm.nasm +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionHandlerAsm.nasm @@ -184,17 +184,17 @@ HasErrorCode: push rax push rax sidt [rsp] - xchg rax, [rsp + 2] - xchg rax, [rsp] - xchg rax, [rsp + 8] + xchg eax, [rsp + 2] + xchg eax, [rsp] + xchg eax, [rsp + 8] =20 xor rax, rax push rax push rax sgdt [rsp] - xchg rax, [rsp + 2] - xchg rax, [rsp] - xchg rax, [rsp + 8] + xchg eax, [rsp + 2] + xchg eax, [rsp] + xchg eax, [rsp + 8] =20 ;; UINT64 Ldtr, Tr; xor rax, rax --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46723): https://edk2.groups.io/g/devel/message/46723 Mute This Topic: https://groups.io/mt/33129650/1787277 Mute #ac: https://groups.io/mk?hashtag=3Dac&subid=3D3901457 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-