From nobody Tue Nov 26 20:17:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+46597+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+46597+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1567119621; cv=none; d=zoho.com; s=zohoarc; b=LjzYks7h40mWaATfPPP8WEdSa26r3MzApaNn1Y1rFnA9/fzZAO2rhaRr0vqpCZluvPH6AX38JPEuO62G16Fr8ZaGqWQXwnp8BUeLSb/ao6Gl/v7zx5Ra6t3QfIuScVeuACkXlMkOKW1uOMI9Eof5aX8xxp+3Bh2reb/wNDQfJs8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567119621; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To:ARC-Authentication-Results; bh=HahGxRyXNECJVoCnbdmoL70gfjjzlJTOknO+U3mWkJw=; b=RaMO59sR3hC7Quc0uj8G8TbMk9QVuKgt7sRHBogosvQcMNr5q4xWpSNX3y1MU4wcLi9KVxPAR7JYm4e8Qj0132+tfrqI5/bKrfFSBVOqo1j34SSDGK//Vl7lO0h7+uvwsvfvITpPOdfGgzyqIG+HP2kY8eb/OgqGGuyuJp6L1Ao= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+46597+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1567119621325909.1187441956571; Thu, 29 Aug 2019 16:00:21 -0700 (PDT) Return-Path: X-Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Thu, 29 Aug 2019 16:00:20 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2019 16:00:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,445,1559545200"; d="scan'208";a="193130917" X-Received: from nldesimo-desk1.amr.corp.intel.com ([10.7.159.63]) by orsmga002.jf.intel.com with ESMTP; 29 Aug 2019 16:00:19 -0700 From: "Nate DeSimone" To: devel@edk2.groups.io Cc: Chasel Chiu , Michael Kubacki , Sai Chaganty Subject: [edk2-devel] [PATCH] CoffeelakeSiliconPkg: Add a needed ZeroMem () Date: Thu, 29 Aug 2019 16:00:12 -0700 Message-Id: <20190829230012.30756-1-nathaniel.l.desimone@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1567119621; bh=Ph2UUdAxfHJfcTkMW049WWYO4C/CYvghq+99lxLGtEo=; h=Cc:Date:From:Reply-To:Subject:To; b=gpx/7DqMtLy++aDhV5p2RHWwlVKwd0OV4+5233JG2p2IXo4jpGrPO7grfV16q2VdNC8 ZDHP9RVzpkSTtDODekKdoHdC3ErmeA5BeC+iwoyxwTz/US175iCGDFUuKm28dFfnZGwqw 9aSsp7DHE8p71WYp2pgbWClOZnJNEyQHa9c= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" AddComponentConfigBlocks () should ZeroMem () the Config Block Header befor= e using it. Cc: Chasel Chiu Cc: Michael Kubacki Cc: Sai Chaganty Signed-off-by: Nate DeSimone Reviewed-by: Chasel Chiu Reviewed-by: Michael Kubacki --- .../Library/BaseSiConfigBlockLib/BaseSiConfigBlockLib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseSiConfigBlockLi= b/BaseSiConfigBlockLib.c b/Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseS= iConfigBlockLib/BaseSiConfigBlockLib.c index 16a14b3245..3c02a4563c 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseSiConfigBlockLib/BaseS= iConfigBlockLib.c +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseSiConfigBlockLib/BaseS= iConfigBlockLib.c @@ -75,6 +75,7 @@ AddComponentConfigBlocks ( // Loop to identify each config block from ComponentBlocks[] Table and a= dd each of them // for (BlockCount =3D 0 ; BlockCount < TotalBlockCount; BlockCount++) { + ZeroMem (&ConfigBlockBuf, sizeof (CONFIG_BLOCK)); CopyMem (&(ConfigBlockBuf.Header.GuidHob.Name), ComponentBlocks[BlockC= ount].Guid, sizeof (EFI_GUID)); ConfigBlockBuf.Header.GuidHob.Header.HobLength =3D ComponentBlocks[Blo= ckCount].Size; ConfigBlockBuf.Header.Revision =3D ComponentBlocks[BlockCount].= Revision; --=20 2.17.1.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46597): https://edk2.groups.io/g/devel/message/46597 Mute This Topic: https://groups.io/mt/33073966/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-