From nobody Mon Apr 29 01:30:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+46534+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+46534+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1566982354; cv=none; d=zoho.com; s=zohoarc; b=b24CE+T3ek+eT29xf/Jh7J5Dq47+PCEEirj6M4PTrSVUxHMPBIwoaGRcmI79YSxxVKm1zNSxlftEmwr/nbOQiobwJGnqbLooVMZcwCOUF5fKG2525v01WLMAHUheWsqFw/cNwiS9LLUqCu2Djn7suD77GlaYEu47Jaij0L5CvyY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566982354; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To:ARC-Authentication-Results; bh=AU4f5lEhnlEAuduv5EY7H7RU8QUf6XuYhlus8LJzDG8=; b=OBLQIFk2SOWz8Zqa+4MNeHw54yXcWNn/psaY0JrmfrQy2TyCaI/ePAL0THooU/rctCo5sBJhy+xUD3ukYqQNcdo7vP03IJtPkrv4Kbo9QnTc4fhL39SNfnHjIKHLZTwq+xDeRTwciiKbbSsDmhG0wLXLIdpbqa+4t6vuHsomclI= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+46534+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1566982354094326.8483342701327; Wed, 28 Aug 2019 01:52:34 -0700 (PDT) Return-Path: X-Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Wed, 28 Aug 2019 01:52:33 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2019 01:52:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,440,1559545200"; d="scan'208";a="185557624" X-Received: from shwdepsi1121.ccr.corp.intel.com ([10.239.158.47]) by orsmga006.jf.intel.com with ESMTP; 28 Aug 2019 01:52:31 -0700 From: "Bob Feng" To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao , Steven Shi Subject: [edk2-devel] [Patch][edk2-stable201908] BaseTools: fix an incremental build issue. Date: Wed, 28 Aug 2019 16:52:09 +0800 Message-Id: <20190828085209.25316-1-bob.c.feng@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,bob.c.feng@intel.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1566982353; bh=QOu7Iztay4aCj2yS1HrlyDfriIx5GeUy/my0W1ECefc=; h=Cc:Date:From:Reply-To:Subject:To; b=XCT01ZzFZMIT4D0UGy7eUcuhG4eJhZsX+CxaIBOUt5fZ1elfZHCavQWGgvY0CEqCsVT YJR+VxTXzgO3VpOewTXTd6jV367AUnkdPVs4MsVQkLyPBW+mQPoXylB6A3I9SDt8DB0ps z7W3xW2XEu4gjWsLT9xLELk1hOuTLUQ351w= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2137 This patch is going to fix a regression issue of incremental build which was introduced by the commit 94459080c. The changing on INF file will not trigger module rebuild. Signed-off-by: Bob Feng Cc: Liming Gao Cc: Steven Shi Acked-by: Michael D Kinney Tested-by: Michael D Kinney --- BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py b/BaseTools/S= ource/Python/AutoGen/ModuleAutoGen.py index 2cd0d3859e..f610365f6d 100755 --- a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py +++ b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py @@ -1764,16 +1764,12 @@ class ModuleAutoGen(AutoGen): for f in self.AutoGenDepSet: FileSet.add (f.Path) =20 if os.path.exists (self.TimeStampPath): os.remove (self.TimeStampPath) - with tempfile.NamedTemporaryFile('w+', dir=3Dos.path.dirname(s= elf.TimeStampPath), delete=3DFalse) as tf: - for f in FileSet: - tf.write(f) - tf.write("\n") - tempname =3D tf.name - SaveFileOnChange(self.TimeStampPath, tempname, False) + + SaveFileOnChange(self.TimeStampPath, "\n".join(FileSet), False) =20 # Ignore generating makefile when it is a binary module if self.IsBinaryModule: return =20 --=20 2.20.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46534): https://edk2.groups.io/g/devel/message/46534 Mute This Topic: https://groups.io/mt/33055144/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-