From nobody Mon Feb 9 16:51:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+46330+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+46330+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1566595387; cv=none; d=zoho.com; s=zohoarc; b=oezIbcVMSO6naNU+vMAgfVfAhXqNTZyHoxoDwUah+BQOPMO3wwidWvfbAb3MAKDbylAW801BpLvbLLfkN4GqyABVDqFe+l331GP+AUd4VjJSdzOv/PeIv5yn/xYmwBwpwi34+sM7p5AI4QtqgvMmqa+KSQ1vqGODbEBxPENAdTA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566595387; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=v21+eTAZWI0iKLv4orlFOszQUh3Zr/hX+rJ2llFFXds=; b=eItd2vUpeJCV6GmLSH0E9U6/KFVfD0EdVvMZyDB2/pDbUezRaAOW3iGWQPi9yludJla8Lj20pwgFNRuFRkD5rZ9LNhEnR/4TN+BZb23ecTkKIxViuQ98PjDjsS5M9DLY40zEuupefSz5dCo8fo+4Sj+vs8JVM4E79Ts7iDcmEBs= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+46330+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1566595387481900.2730089457177; Fri, 23 Aug 2019 14:23:07 -0700 (PDT) Return-Path: X-Received: from mga04.intel.com (mga04.intel.com []) by groups.io with SMTP; Fri, 23 Aug 2019 14:23:06 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Aug 2019 14:23:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,422,1559545200"; d="scan'208";a="191063737" X-Received: from makuback-desk1.amr.corp.intel.com ([10.7.159.162]) by orsmga002.jf.intel.com with ESMTP; 23 Aug 2019 14:23:06 -0700 From: "Kubacki, Michael A" To: devel@edk2.groups.io Cc: Chasel Chiu , Sai Chaganty Subject: [edk2-devel] [edk2-platforms][PATCH V2 1/2] CoffeelakeSiliconPkg: Fix GCC Build Failures Date: Fri, 23 Aug 2019 14:22:34 -0700 Message-Id: <20190823212235.26988-2-michael.a.kubacki@intel.com> In-Reply-To: <20190823212235.26988-1-michael.a.kubacki@intel.com> References: <20190823212235.26988-1-michael.a.kubacki@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.a.kubacki@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1566595387; bh=YVpFGESwIWAEIKJV0G55TYqH8rGSiuWwZDE7Ui6qLoo=; h=Cc:Date:From:Reply-To:Subject:To; b=GHcr+CEINdoHTU+JjfDoxPulBxO8RZqquvlPl/M4IPpu+YYIQAkslSUsNVCsXXU1bnJ +s8AmXHR2aIlJ5YtL4zT2X0ybUoGTYk1hJZ0JWFmBCYQ7FyAtVV7lz4ZIvrJoI6x7yfHB nDkGtoIIWWzXFha2fZq5W7bLRerfoLe3s60= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2124 Fixes build failures on GCC7.3.0. Tested on Ubuntu 18.04.1 LTS. Cc: Chasel Chiu Cc: Sai Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Chasel Chiu Reviewed-by: Nate DeSimone --- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/HdAudioConfig.h= | 2 ++ Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Library/GpioLib.h = | 1 + Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiPchPolicyLib/PeiPchPolic= yLib.c | 2 -- Silicon/Intel/CoffeelakeSiliconPkg/SystemAgent/SaInit/Dxe/SaInitDxe.c = | 1 + 4 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/HdA= udioConfig.h b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/H= dAudioConfig.h index a810d4f1fc..e2c8730f38 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/HdAudioCon= fig.h +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/HdAudioCon= fig.h @@ -9,7 +9,9 @@ #ifndef _HDAUDIO_CONFIG_H_ #define _HDAUDIO_CONFIG_H_ =20 +#include #include +#include =20 #define HDAUDIO_PREMEM_CONFIG_REVISION 1 #define HDAUDIO_CONFIG_REVISION 2 diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Library/GpioLib= .h b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Library/GpioLib.h index 25def24fca..ff76e7c60f 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Library/GpioLib.h +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Library/GpioLib.h @@ -11,6 +11,7 @@ #define _GPIO_LIB_H_ =20 #include +#include =20 #define GPIO_NAME_LENGTH_MAX 32 =20 diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiPchPolicyLib= /PeiPchPolicyLib.c b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiPchP= olicyLib/PeiPchPolicyLib.c index 2a1da20667..ece0be8158 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiPchPolicyLib/PeiPch= PolicyLib.c +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiPchPolicyLib/PeiPch= PolicyLib.c @@ -353,10 +353,8 @@ LoadLanConfigDefault ( ) { PCH_LAN_CONFIG *LanConfig; - UINT16 LpcDid; =20 LanConfig =3D ConfigBlockPointer; - LpcDid =3D PchGetLpcDid (); =20 DEBUG ((DEBUG_INFO, "LanConfig->Header.GuidHob.Name =3D %g\n", &LanConfi= g->Header.GuidHob.Name)); DEBUG ((DEBUG_INFO, "LanConfig->Header.GuidHob.Header.HobLength =3D 0x%x= \n", LanConfig->Header.GuidHob.Header.HobLength)); diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/SystemAgent/SaInit/Dxe/SaIn= itDxe.c b/Silicon/Intel/CoffeelakeSiliconPkg/SystemAgent/SaInit/Dxe/SaInitD= xe.c index d646e60618..e6980f9a65 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/SystemAgent/SaInit/Dxe/SaInitDxe.c +++ b/Silicon/Intel/CoffeelakeSiliconPkg/SystemAgent/SaInit/Dxe/SaInitDxe.c @@ -41,6 +41,7 @@ SaInitEntryPointDxe ( SaInitEntryPoint (); =20 Status =3D SaAcpiInit (ImageHandle); + ASSERT_EFI_ERROR (Status); =20 /// /// Create PCI Enumeration Completed callback for SA --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46330): https://edk2.groups.io/g/devel/message/46330 Mute This Topic: https://groups.io/mt/33006013/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-