From nobody Sun May 5 16:32:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+46300+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+46300+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1566562867; cv=none; d=zoho.com; s=zohoarc; b=gchqUw6aw/BkbV9oRq7YVfsou66BYgwf/Erg63Z9l5bdd7WWWf2Nf9f6x1/4zKItUW+jUbZy3j1h+ra+QeZj72q9TaU3msfv4PVM3LEqJmkWfjr0os8gz3MWScg8rBnpFmOr1IZQcTZyisyruYgu3QrOHMmHuy7H7qFUApqGjyY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566562867; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=b7giWNmGMNRdrJnlILn2Al8dtLkeAVA3tJWzsVG+xWo=; b=UlQBNt7Dd4ol6RRR58H2js9qokSRC4ON4N5rSh/mzC/HsBAaRiVCpJU0tp6ryJ845WXarMuyPVDpf4kiM6HapwkICvqsmyc/3pngXl5EiPjRmRJf1wXXWnVS44wq95l05eCrk3RgqoLbZpVwPnAu2ozVHJC6GQylS6OdHhQ8jpQ= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+46300+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1566562867044821.4132755064502; Fri, 23 Aug 2019 05:21:07 -0700 (PDT) Return-Path: X-Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by groups.io with SMTP; Fri, 23 Aug 2019 05:21:06 -0700 X-Received: by mail-wm1-f67.google.com with SMTP id p74so8715277wme.4 for ; Fri, 23 Aug 2019 05:21:05 -0700 (PDT) X-Gm-Message-State: APjAAAWKvyXJfSMG5plz3iNZDoal4z4iUtqB6raGidsiIiNlFkW4LBF7 twAjwuU7owBUzCmCCKT+rI8ulkEqP14= X-Google-Smtp-Source: APXvYqxtZYlGRN0A/f45Z9ic+nOOKLSS+hK1yYYpgdmAmKhjgLyQ0lYgtzg1zcdUZJl8bhYIrOCMXw== X-Received: by 2002:a7b:c947:: with SMTP id i7mr5079843wml.77.1566562863990; Fri, 23 Aug 2019 05:21:03 -0700 (PDT) X-Received: from localhost.localdomain ([84.203.87.76]) by smtp.gmail.com with ESMTPSA id s19sm4634342wrb.94.2019.08.23.05.21.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Aug 2019 05:21:03 -0700 (PDT) From: "Pete Batard" To: devel@edk2.groups.io Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org Subject: [edk2-devel] [edk2-platforms: PATCH v2 1/1] Platform/Rpi3: Add compatible property to the "usb" Device Tree node Date: Fri, 23 Aug 2019 13:20:50 +0100 Message-Id: <20190823122050.5244-2-pete@akeo.ie> In-Reply-To: <20190823122050.5244-1-pete@akeo.ie> References: <20190823122050.5244-1-pete@akeo.ie> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pete@akeo.ie Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1566562866; bh=RBiZ9NvuWhljBRVbm+XH+8OCmgdTep7AtWrbx3KmYpg=; h=Cc:Date:From:Reply-To:Subject:To; b=i4gmD1e/lQfUKOL+hNgiLoiazyAZNFkU6lGqFDGTCfSKYTAUqNLm14bWsP9o9taqdNn /9tF5b19d74HOuqodWZrQnD7hkHc3BuW7+Cp5GjLAe/vxlbN/YdRzO+RxNs2nYhOcVQBv EUBGzZyDUzzQlbw7l3eIQsDIUt+O88jTKSY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Some Linux kernels (e.g. Debian) require "bcm,bcm2835-usb" to be present in the list of compatible properties for the "usb" node, else they are unable to handle some USB devices. This patch ensures that the compatible property is added if not present. Signed-off-by: Pete Batard Reviewed-by: Leif Lindholm --- Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c | 75 ++++++++++++++++++++ 1 file changed, 75 insertions(+) diff --git a/Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c b/Platform/R= aspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c index 45ffe2e394a2..eb8048930c30 100644 --- a/Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c +++ b/Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c @@ -135,6 +135,76 @@ UpdateMacAddress ( return EFI_SUCCESS; } =20 +// +// Add "bcm2835-usb" to the USB compatible property list, if not present. +// Required because some Linux kernels can't handle USB devices otherwise. +// +STATIC +EFI_STATUS +AddUsbCompatibleProperty ( + VOID + ) +{ + CONST CHAR8 Prop[] =3D "brcm,bcm2708-usb"; + CONST CHAR8 NewProp[] =3D "brcm,bcm2835-usb"; + CONST CHAR8 *List; + CHAR8 *NewList; + INT32 ListSize; + INTN Node; + INTN Retval; + + // Locate the node that the 'usb' alias refers to + Node =3D fdt_path_offset (mFdtImage, "usb"); + if (Node < 0) { + DEBUG ((DEBUG_ERROR, "%a: failed to locate 'usb' alias\n", __FUNCTION_= _)); + return EFI_NOT_FOUND; + } + + // Get the property list. This is a list of NUL terminated strings. + List =3D fdt_getprop (mFdtImage, Node, "compatible", &ListSize); + if (List =3D=3D NULL) { + DEBUG ((DEBUG_ERROR, "%a: failed to locate properties\n", __FUNCTION__= )); + return EFI_NOT_FOUND; + } + + // Check if the compatible value we plan to add is already present + if (fdt_stringlist_contains (List, ListSize, NewProp)) { + DEBUG ((DEBUG_INFO, "%a: property '%a' is already set.\n", + __FUNCTION__, NewProp)); + return EFI_SUCCESS; + } + + // Make sure the compatible device is what we expect + if (!fdt_stringlist_contains (List, ListSize, Prop)) { + DEBUG ((DEBUG_ERROR, "%a: property '%a' is missing!\n", + __FUNCTION__, Prop)); + return EFI_NOT_FOUND; + } + + // Add the new NUL terminated entry to our list + DEBUG ((DEBUG_INFO, "%a: adding '%a' to the properties\n", + __FUNCTION__, NewProp)); + + NewList =3D AllocatePool (ListSize + sizeof (NewProp)); + if (NewList =3D=3D NULL) { + DEBUG ((DEBUG_ERROR, "%a: failed to allocate memory\n", __FUNCTION__)); + return EFI_OUT_OF_RESOURCES;; + } + CopyMem (NewList, List, ListSize); + CopyMem (&NewList[ListSize], NewProp, sizeof (NewProp)); + + Retval =3D fdt_setprop (mFdtImage, Node, "compatible", NewList, + ListSize + sizeof (NewProp)); + FreePool (NewList); + if (Retval !=3D 0) { + DEBUG ((DEBUG_ERROR, "%a: failed to update properties (%d)\n", + __FUNCTION__, Retval)); + return EFI_NOT_FOUND; + } + + return EFI_SUCCESS; +} + STATIC EFI_STATUS CleanMemoryNodes ( @@ -486,6 +556,11 @@ FdtDxeInitialize ( Print (L"Failed to update MAC address: %r\n", Status); } =20 + Status =3D AddUsbCompatibleProperty (); + if (EFI_ERROR (Status)) { + Print (L"Failed to update USB compatible properties: %r\n", Status); + } + if (Internal) { /* * A GPU-provided DTB already has the full command line. --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46300): https://edk2.groups.io/g/devel/message/46300 Mute This Topic: https://groups.io/mt/33000474/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-